Page MenuHomeSoftware Heritage
Differential D1685

cypress: Add basic test for origin-search
ClosedPublic
Actions

Authored by kalpitk on Jul 3 2019, 8:39 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDWAPPS76d9932ca69d: cypress: Basic tests for origin-search
Summary

firstly, tests which don't require additional repos injested will be implemented.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kalpitk created this revision.Jul 3 2019, 8:39 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 3 2019, 8:39 PM
kalpitk retitled this revision from cypress: Add basic test for origin-search to [WIP] cypress: Add basic test for origin-search.Jul 3 2019, 8:42 PM
swh-public-ci added a comment.Jul 3 2019, 8:42 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/580/ for more details.

Harbormaster completed remote builds in B6667: Diff 5657.Jul 3 2019, 8:42 PM
kalpitk updated this revision to Diff 5673.Jul 4 2019, 5:20 PM
  • Add tests
swh-public-ci added a comment.Jul 4 2019, 5:23 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/582/ for more details.

Harbormaster completed remote builds in B6696: Diff 5673.Jul 4 2019, 5:23 PM
kalpitk updated this revision to Diff 5674.Jul 4 2019, 6:18 PM
  • Add tests
kalpitk retitled this revision from [WIP] cypress: Add basic test for origin-search to cypress: Add basic test for origin-search.Jul 4 2019, 6:19 PM
swh-public-ci added a comment.Jul 4 2019, 6:21 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/583/ for more details.

Harbormaster completed remote builds in B6697: Diff 5674.Jul 4 2019, 6:21 PM
anlambert accepted this revision.Jul 8 2019, 11:20 AM
anlambert added a subscriber: anlambert.

Nice work! Apart a small inline comment to handle, this can be landed !

cypress/integration/origin-search.spec.js
51

async keyword is not needed here

This revision is now accepted and ready to land.Jul 8 2019, 11:20 AM
kalpitk updated this revision to Diff 5692.Jul 8 2019, 11:56 AM
  • remove unnecessary async
  • Rebase
swh-public-ci added a comment.Jul 8 2019, 11:59 AM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/586/ for more details.

Harbormaster completed remote builds in B6714: Diff 5692.Jul 8 2019, 11:59 AM
Closed by commit rDWAPPS76d9932ca69d: cypress: Basic tests for origin-search (authored by kalpitk). · Explain WhyJul 8 2019, 1:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
cypress/
integration/
152 lines

Diff 5693

View Options

cypress/integration/origin-search.spec.js

Loading...
About · Developer information · Legal