Page MenuHomeSoftware Heritage
Differential D1652

Add tests for errors
ClosedPublic
Actions

Authored by kalpitk on Jun 27 2019, 2:30 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDWAPPS3feeb9fc12f2: cypress: Add error tests

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kalpitk created this revision.Jun 27 2019, 2:30 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 27 2019, 2:30 PM
swh-public-ci added a comment.Jun 27 2019, 2:42 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/544/ for more details.

Harbormaster completed remote builds in B6520: Diff 5527.Jun 27 2019, 2:42 PM
kalpitk updated this revision to Diff 5566.Jun 28 2019, 7:22 PM
  • Refactor errors.spec
  • Rebase with master
swh-public-ci added a comment.Jun 28 2019, 7:29 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/558/ for more details.

Harbormaster completed remote builds in B6573: Diff 5566.Jun 28 2019, 7:29 PM
kalpitk updated this revision to Diff 5567.Jun 28 2019, 7:51 PM
  • Add test in error.spec
swh-public-ci added a comment.Jun 28 2019, 7:58 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/559/ for more details.

Harbormaster completed remote builds in B6574: Diff 5567.Jun 28 2019, 7:58 PM
kalpitk updated this revision to Diff 5575.Jun 30 2019, 1:02 PM
  • Add another test for errors
swh-public-ci added a comment.Jun 30 2019, 1:10 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/563/ for more details.

Harbormaster completed remote builds in B6582: Diff 5575.Jun 30 2019, 1:10 PM
kalpitk updated this revision to Diff 5587.Jul 1 2019, 1:05 PM
  • Refactor
  • Add tests
  • Rebase
swh-public-ci added a comment.Jul 1 2019, 1:13 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/565/ for more details.

Harbormaster completed remote builds in B6594: Diff 5587.Jul 1 2019, 1:13 PM
kalpitk updated this revision to Diff 5612.Jul 2 2019, 12:34 PM

Add tests

kalpitk retitled this revision from [WIP] Add tests for errors to Add tests for errors.Jul 2 2019, 12:34 PM
kalpitk updated this revision to Diff 5613.Jul 2 2019, 12:37 PM
  • removed unnecessary print (Commited by mistake)
swh-public-ci added a comment.Jul 2 2019, 12:41 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/569/ for more details.

Harbormaster completed remote builds in B6620: Diff 5612.Jul 2 2019, 12:41 PM
swh-public-ci added a comment.Jul 2 2019, 12:48 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/570/ for more details.

Harbormaster completed remote builds in B6621: Diff 5613.Jul 2 2019, 12:48 PM
anlambert requested changes to this revision.Jul 2 2019, 3:30 PM
anlambert added a subscriber: anlambert.

Great work, thanks !

Before landing this, I want you to remove the harcoded swh-web urls in tests implementation (see commit ea8796c I just pushed for examples and my inline comments).

The idea is to use the Urls global javascript object allowing to manipulate named urls instead of raw ones.
This object is made available by the django-js-reverse extension we are using in swh-web.
For each named Django view, it adds a function in the Urls that will generate the raw url from its name and its required arguments.
This way, if we modify a raw url in Python code, we will not need to modify it in the cypress tests implementation.

cypress/integration/errors.spec.js
38

Here, you must add the following global variable declaration:

let Urls;
39

Then add a before hook to get the Urls global object from swh-web:

before(function() {
  cy.visit('/').window().then(win => {
    Urls = win.Urls;
  });
});
41

Replace this line with:

const url = Urls.browse_origin_directory(unarchivedRepo.url);

And do the same in tests below. The naming scheme for the functions of the Urls object is quite straightforward:

  • Urls.browse_origin_<object_type>
  • Urls.browse_<object_type>
  • Urls.api_1_<object_type>

where <object_type> can be one of: content, directory, snapshot, ...

137

Replace this line with:

const url = Urls[`browse_${type}`](invalidChecksum)
This revision now requires changes to proceed.Jul 2 2019, 3:30 PM
kalpitk added a comment.Jul 3 2019, 10:34 AM

@anlambert Thank you for the improvements. I think, it will be even better if we declare Urls object in cypress/support/index.js, no need to repeat in every spec file

anlambert added a comment.Jul 3 2019, 10:40 AM

Thank you for the improvements. I think, it will be even better if we declare Urls object in cypress/support/index.js, no need to repeat in every spec file

Thanks for pointing me to this, I was looking for such a feature yesterday but I missed it in the documentation.

I will commit the improvement today.

anlambert added a comment.Jul 3 2019, 11:22 AM

@kalpitk , the Urls variable is now set globally in the support file (958fd1da20e9). You can access it through this.Urls in tests implementation.

kalpitk updated this revision to Diff 5639.Jul 3 2019, 12:07 PM
  • fetch urls through django-reverse
kalpitk updated this revision to Diff 5641.Jul 3 2019, 12:10 PM
  • fetch api url through django-reverse
swh-public-ci added a comment.Jul 3 2019, 12:13 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/575/ for more details.

Harbormaster completed remote builds in B6649: Diff 5639.Jul 3 2019, 12:13 PM
kalpitk updated this revision to Diff 5643.Jul 3 2019, 12:17 PM

use Urls to fetch url at one more place

swh-public-ci added a comment.Jul 3 2019, 12:18 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/576/ for more details.

Harbormaster completed remote builds in B6651: Diff 5641.Jul 3 2019, 12:18 PM
swh-public-ci added a comment.Jul 3 2019, 12:28 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/578/ for more details.

Harbormaster completed remote builds in B6653: Diff 5643.Jul 3 2019, 12:28 PM
anlambert accepted this revision.Jul 3 2019, 1:39 PM
This revision is now accepted and ready to land.Jul 3 2019, 1:39 PM
kalpitk updated this revision to Diff 5647.Jul 3 2019, 1:53 PM

Rebase

swh-public-ci added a comment.Jul 3 2019, 1:58 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/579/ for more details.

Harbormaster completed remote builds in B6656: Diff 5647.Jul 3 2019, 1:58 PM
Closed by commit rDWAPPS3feeb9fc12f2: cypress: Add error tests (authored by kalpitk). · Explain WhyJul 3 2019, 1:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
cypress/
integration/
153 lines

Diff 5648

View Options

cypress/integration/errors.spec.js

Loading...
About · Developer information · Legal