Page MenuHomeSoftware Heritage
Differential D1649

Reformat docstring for max line length
ClosedPublic
Actions

Authored by twitu on Jun 27 2019, 6:23 AM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDMODdde39f51c0fa: Reformat docstring for max line length
Summary

In reference to T1836, however all violations cannot be removed

Diff Detail

Repository
rDMOD Data model
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

twitu created this revision.Jun 27 2019, 6:23 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 27 2019, 6:23 AM
swh-public-ci added a comment.Jun 27 2019, 6:26 AM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/91/ for more details.

Harbormaster completed remote builds in B6513: Diff 5520.Jun 27 2019, 6:26 AM
twitu retitled this revision from Reformat docstring for max line length In reference to T1836, however all violations cannot be removed to Reformat docstring for max line length.Jun 27 2019, 6:30 AM
twitu edited the summary of this revision. (Show Details)
vlorentz accepted this revision.Jun 27 2019, 11:00 AM
This revision is now accepted and ready to land.Jun 27 2019, 11:00 AM
vlorentz requested changes to this revision.Jun 27 2019, 11:01 AM

You should be able to remove the # noqa flag at the end of the docstring now.

What do you mean by "all violations cannot be removed"?

This revision now requires changes to proceed.Jun 27 2019, 11:01 AM
twitu added inline comments.Jun 27 2019, 4:13 PM
swh/model/identifiers.py
662–663

this one is just exceeding 80 characters, it would mean moving the comment to the next line, which defeats the purpose of the line comment.

vlorentz added inline comments.Jun 27 2019, 4:18 PM
swh/model/identifiers.py
662–663

It should be fine on the next line.

twitu updated this revision to Diff 5532.Jun 27 2019, 6:44 PM

Reformat docstring for max line length

vlorentz accepted this revision.Jun 27 2019, 6:44 PM
This revision is now accepted and ready to land.Jun 27 2019, 6:44 PM
swh-public-ci added a comment.Jun 27 2019, 6:46 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/92/ for more details.

Harbormaster completed remote builds in B6527: Diff 5532.Jun 27 2019, 6:46 PM
Closed by commit rDMODdde39f51c0fa: Reformat docstring for max line length (authored by twitu). · Explain WhyJun 27 2019, 6:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
model/
13 lines

Diff 5534

View Options

swh/model/identifiers.py

Loading...
About · Developer information · Legal