Page MenuHomeSoftware Heritage
Differential D1317

rate limit search in origin-save table
ClosedPublic
Actions

Authored by kalpitk on Mar 28 2019, 5:45 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDWAPPS61accbbfa50a: rate limit search in origin-save table
Summary

Add searchDelay of 1s to DataTable

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kalpitk created this revision.Mar 28 2019, 5:45 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 28 2019, 5:45 PM
swh-public-ci added a comment.Mar 28 2019, 5:48 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/361/ for more details.

Harbormaster completed remote builds in B4939: Diff 4181.Mar 28 2019, 5:48 PM
anlambert added a subscriber: anlambert.Mar 29 2019, 11:24 AM

@kalpitk , can you give me more details about this change ?

Also, please run this in your shell:

arc set-config history.immutable true

Without this, arcanist amend your commit messages which force me to edit them before being able to land your diffs.

kalpitk added a comment.EditedMar 29 2019, 3:58 PM

@anlambert history.immutable is already set to true.

With the current implementation, we have no search delay. i.e. - every keydown triggers a request. In case of a big query, it unnecessarily sends requests. (Piles up unnecessary queries for the server)

with this Diff, request is sent when user finishes typing. (when no key is pressed for 1000 ms)

anlambert requested changes to this revision.Mar 29 2019, 4:48 PM

@anlambert history.immutable is already set to true.

My bad, arcanist seems to apply some commit message template when I call arc patch from my side
to integrate your changes. I am not a big fan of that behavior but anyway.

We have other DataTable uses in swh-web assets. Can you also set the searchDelay option
to the remaining ones ?

Also you will have to rebase on master before updating the diff as we like to keep a linear history.

This revision now requires changes to proceed.Mar 29 2019, 4:48 PM
kalpitk added a comment.Mar 29 2019, 6:18 PM

@anlambert Oh the admin ones. Will update.
Anyways, how do I test as admin when I run it locally?

anlambert added a comment.Mar 29 2019, 6:21 PM

You need to create a superuser account through the following command:

$ python3 -m swh.web.manage createsuperuser

Then reach the /admin endpoint to log in and unlock the admin interface

kalpitk updated this revision to Diff 4195.Mar 29 2019, 6:33 PM
  • add SearchDelay to admin DataTables
anlambert accepted this revision.Mar 29 2019, 6:35 PM

Nice! Can you squash the commits and then i land that diff.

This revision is now accepted and ready to land.Mar 29 2019, 6:35 PM
swh-public-ci added a comment.Mar 29 2019, 6:36 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/363/ for more details.

Harbormaster completed remote builds in B4958: Diff 4195.Mar 29 2019, 6:36 PM
kalpitk updated this revision to Diff 4196.Mar 29 2019, 6:45 PM

squashed commits

swh-public-ci added a comment.Mar 29 2019, 6:48 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/366/ for more details.

Harbormaster completed remote builds in B4959: Diff 4196.Mar 29 2019, 6:48 PM
anlambert added a comment.Mar 29 2019, 6:48 PM

Last one thing, rebase to origin/master as the diff can not be merged otherwise.

kalpitk updated this revision to Diff 4197.Mar 29 2019, 6:56 PM

rebase to master

This revision was landed with ongoing or failed builds.Mar 29 2019, 6:57 PM
Closed by commit rDWAPPS61accbbfa50a: rate limit search in origin-save table (authored by kalpitk, committed by anlambert). · Explain Why
This revision was automatically updated to reflect the committed changes.
anlambert added a comment.Mar 29 2019, 6:58 PM

Thanks, landed!

swh-public-ci added a comment.Mar 29 2019, 6:59 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/367/ for more details.

Harbormaster completed remote builds in B4960: Diff 4197.Mar 29 2019, 6:59 PM

Revision Contents
Changeset List

PathSize
swh/
web/
assets/
src/
bundles/
admin/
3 lines
browse/
1 line

Diff 4198

View Options

swh/web/assets/src/bundles/admin/origin-save.js

Loading...
View Options

swh/web/assets/src/bundles/browse/origin-save.js

Loading...
About · Developer information · Legal