Change Details

Type (for before it's the type after deducing how it's used, it was not defined yet) : ``` before def origin_visit_add(self, origin: str, date: Union[str, datetime.datetime], type: str) -> Optional[Dict[str, Union[str, int]]]: after def origin_visit_add(self, origin_url: str, date: Union[str, datetime.datetime], type: str) -> OriginVisit: ``` Impacts: - swh-loader-core (runtime) - swh-loader-svn (runtime) - swh-journal (tests) - swh-web (tests) - swh-indexer (tests) Depends on D2813

origin_visit_add: Adapt endpoint signature to return OriginVisit Prior to this commit, there was: - no signature in the method - discrepancy between checks on the different backend origin_visit_add endpoint is now typed ``` def origin_visit_add( self, origin_url: str, date: Union[str, datetime.datetime], type: str) -> OriginVisit: ``` This also: - renames appropriately the origin_url parameter (removing 1 FIXME) - align backend implementations' check which were different Impacts: - swh-loader-core (runtime) - swh-loader-svn (runtime) - swh-journal (tests) - swh-web (tests) - swh-indexer (tests)

Type (for before it's the type after deducing how it's usedorigin_visit_add: Adapt endpoint signature to return OriginVisit Prior to this commit, it was not defined yet) :there was: - no signature in the method - discrepancy between checks on the different backend origin_visit_add endpoint is now typed ``` before def origin_visit_add(self, origin: str, date: Union[str, datetime.datetime], type: str) -> Optional[Dict[str, Union[strdef origin_visit_add( self, int]]]: after def origin_visit_add(self, origin_url: str, date: Union[str, datetime.datetime], type: str) -> OriginVisit: ``` This also: - renames appropriately the origin_url parameter (removing 1 FIXME) - align backend implementations' check which were different Impacts: - swh-loader-core (runtime) - swh-loader-svn (runtime) - swh-journal (tests) - swh-web (tests) - swh-indexer (tests) Depends on D2813