HomeSoftware Heritage

Description

Fix

Related T502

Details

Provenance
ardumontAuthored on Jul 20 2016, 7:27 PM
ardumontPushed on Jul 20 2016, 7:28 PM
Parents
rSPSITE79638fbe05f7: Update archiver.ini template according to latest development
Branches
Unknown
Tags
Unknown

Event Timeline

"fix" is a horrible short commit message, even when it comes with a "Related" line later that explains the context.

Hello,

a suggestion of improvment sentence would have been good.

In general, I agree but:

  1. The diff shows clearly the fix without ambiguity. Granted, it depends on

the git client to see the diff. Mine, magit, does so i did not pay much
attention.

  1. It's typically something i'd amend but cannot since it's already pushed

(i do need to push to test since we don't have anything better to test yet).

  1. I suppose the linter could see it but it does not work (i did not take

the time to see why yet).

Now, 'Fix missing ending quote' would have been better indeed.

Cheers,

I've now written https://wiki.softwareheritage.org/index.php?title=Git_style_guide that should give useful advice.
Shout if you think it doesn't answer your doubts.