diff --git a/swh/storage/api/server.py b/swh/storage/api/server.py index 9929dea5..22c69ec0 100644 --- a/swh/storage/api/server.py +++ b/swh/storage/api/server.py @@ -1,183 +1,195 @@ -# Copyright (C) 2015-2020 The Software Heritage developers +# Copyright (C) 2015-2022 The Software Heritage developers # See the AUTHORS file at the top-level directory of this distribution # License: GNU General Public License version 3, or any later version # See top-level LICENSE file for more information import logging import os from typing import Any, Dict, Optional +from psycopg2.errors import QueryCanceled + from swh.core import config from swh.core.api import RPCServerApp from swh.core.api import encode_data_server as encode_data -from swh.core.api import error_handler +from swh.core.api import error_handler, serializers from swh.storage import get_storage as get_swhstorage from ..exc import StorageArgumentException from ..interface import StorageInterface from ..metrics import send_metric, timed from .serializers import DECODERS, ENCODERS def get_storage(): global storage if not storage: storage = get_swhstorage(**app.config["storage"]) return storage class StorageServerApp(RPCServerApp): extra_type_decoders = DECODERS extra_type_encoders = ENCODERS method_decorators = [timed] def _process_metrics(self, metrics, endpoint): for metric, count in metrics.items(): send_metric(metric=metric, count=count, method_name=endpoint) def post_content_add(self, ret, kw): self._process_metrics(ret, "content_add") def post_content_add_metadata(self, ret, kw): self._process_metrics(ret, "content_add_metadata") def post_skipped_content_add(self, ret, kw): self._process_metrics(ret, "skipped_content_add") def post_directory_add(self, ret, kw): self._process_metrics(ret, "directory_add") def post_revision_add(self, ret, kw): self._process_metrics(ret, "revision_add") def post_release_add(self, ret, kw): self._process_metrics(ret, "release_add") def post_snapshot_add(self, ret, kw): self._process_metrics(ret, "snapshot_add") def post_origin_visit_status_add(self, ret, kw): self._process_metrics(ret, "origin_visit_status_add") def post_origin_add(self, ret, kw): self._process_metrics(ret, "origin_add") def post_raw_extrinsic_metadata_add(self, ret, kw): self._process_metrics(ret, "raw_extrinsic_metadata_add") def post_metadata_fetcher_add(self, ret, kw): self._process_metrics(ret, "metadata_fetcher_add") def post_metadata_authority_add(self, ret, kw): self._process_metrics(ret, "metadata_authority_add") def post_extid_add(self, ret, kw): self._process_metrics(ret, "extid_add") def post_origin_visit_add(self, ret, kw): nb_visits = len(ret) send_metric( "origin_visit:add", count=nb_visits, # method_name should be "origin_visit_add", but changing it now would break # existing metrics method_name="origin_visit", ) app = StorageServerApp( __name__, backend_class=StorageInterface, backend_factory=get_storage ) storage = None @app.errorhandler(StorageArgumentException) def argument_error_handler(exception): return error_handler(exception, encode_data, status_code=400) +@app.errorhandler(QueryCanceled) +def querycanceled_error_handler(exception): + # Same as error_handler(exception, encode_data); but does not log or send to Sentry. + # These errors are noisy, and are better logged on the caller's side after it + # retried a few times + response = encode_data(serializers.exception_to_dict(exception)) + response.status_code = 500 + return response + + @app.errorhandler(Exception) -def my_error_handler(exception): +def default_error_handler(exception): return error_handler(exception, encode_data) @app.route("/") @timed def index(): return """
You have reached the
Software Heritage
storage server.
See its
documentation
and API for more information