ddouard  (e) swh   fixer ✚ 1 … 6  ~/s/s/swh-storage  1  pytest --doctest-modules swh/storage/fixer.py ===================================== test session starts ====================================== platform linux -- Python 3.9.2, pytest-6.1.2, py-1.9.0, pluggy-0.13.1 rootdir: /home/ddouard/swh/swh-environment/swh-storage, configfile: pytest.ini plugins: dash-1.18.1, postgresql-2.5.2, asyncio-0.14.0, django-4.1.0, requests-mock-1.8.0, forked-1.3.0, mock-3.3.1, xdist-2.1.0, hypothesis-6.4.3, flask-1.1.0, swh.core-0.12.1.dev3+g189ca1f, swh.journal-0.7.2.dev4+g056c210 collected 5 items swh/storage/fixer.py ..... [100%] ====================================== 5 passed in 0.03s =======================================  ddouard  (e) swh   fixer ✚ 1 … 6  ~/s/s/swh-storage  python -m doctest swh/storage/fixer.py ********************************************************************** File "swh/storage/fixer.py", line 248, in fixer._fix_origin_visit Failed example: _fix_origin_visit({ 'origin': {'url': 'http://foo'}, 'date': date, 'status': 'ongoing', 'snapshot': None }) Expected: Traceback (most recent call last): ... ValueError: Old origin visit format detected... Got: Traceback (most recent call last): File "/usr/lib/python3.9/doctest.py", line 1336, in __run exec(compile(example.source, filename, "single", File "", line 1, in _fix_origin_visit({ File "swh/storage/fixer.py", line 281, in _fix_origin_visit raise ValueError(f"Old origin visit format detected: {visit}") ValueError: Old origin visit format detected: {'origin': {'url': 'http://foo'}, 'date': datetime.datetime(2020, 2, 27, 14, 39, 19, tzinfo=datetime.timezone.utc), 'status': 'ongoing', 'snapshot': None} ********************************************************************** File "swh/storage/fixer.py", line 258, in fixer._fix_origin_visit Failed example: _fix_origin_visit({ 'origin': 'http://foo', 'date': date, 'status': 'ongoing', 'snapshot': None }) Expected: Traceback (most recent call last): ... ValueError: Old origin visit format detected... Got: Traceback (most recent call last): File "/usr/lib/python3.9/doctest.py", line 1336, in __run exec(compile(example.source, filename, "single", File "", line 1, in _fix_origin_visit({ File "swh/storage/fixer.py", line 281, in _fix_origin_visit raise ValueError(f"Old origin visit format detected: {visit}") ValueError: Old origin visit format detected: {'origin': 'http://foo', 'date': datetime.datetime(2020, 2, 27, 14, 39, 19, tzinfo=datetime.timezone.utc), 'status': 'ongoing', 'snapshot': None} Invalid revision date detected: {'author': {'fullname': b'', 'name': b'', 'email': b''}, 'committer': {'fullname': b'', 'name': b'', 'email': b''}, 'date': {'timestamp': {'seconds': 1565096932, 'microseconds': 1000000000}, 'offset': 0}, 'committer_date': {'timestamp': {'seconds': 1565096932, 'microseconds': 0}, 'offset': 0}} Invalid revision date detected: {'author': {'fullname': b'', 'name': b'', 'email': b''}, 'committer': {'fullname': b'', 'name': b'', 'email': b''}, 'date': {'timestamp': {'seconds': 1180591620717411303424, 'microseconds': 0}, 'offset': 0}, 'committer_date': {'timestamp': {'seconds': 1565096932, 'microseconds': 0}, 'offset': 0}} Invalid revision date detected: {'author': {'fullname': b'', 'name': b'', 'email': b''}, 'committer': {'fullname': b'', 'name': b'', 'email': b''}, 'date': {'timestamp': {'seconds': 1565096932, 'microseconds': 0}, 'offset': 0}, 'committer_date': {'timestamp': {'seconds': 1565096932, 'microseconds': 0}, 'offset': 1048576}} ********************************************************************** 1 items had failures: 2 of 8 in fixer._fix_origin_visit ***Test Failed*** 2 failures.