s (s)
User

Projects

User does not belong to any projects.

User Details

User Since: Jan 27 2018, 7:37 AM (360 w, 1 d)

Recent Activity
View All

Jun 6 2018

s added a comment to T782: Web API: make endpoints that expose extracted metadata return *lists* of factual information.

In T782#20044, @zack wrote:

So, good news at last! The CLA is ready, here it is: L3 . (It misses a preamble, but it's pretty short anyway without one.)
@s : Can you have a look and sign it (using your legal name) ?
Happy to answer any question you might have !

Jun 6 2018, 11:50 PM · Indexer, Easy hack, Web app

Apr 20 2018

s added a comment to T782: Web API: make endpoints that expose extracted metadata return *lists* of factual information.

"zack (Stefano Zacchiroli)" <forge@softwareheritage.org> writes:

Apr 20 2018, 8:23 AM · Indexer, Easy hack, Web app

Apr 16 2018

s added a comment to T782: Web API: make endpoints that expose extracted metadata return *lists* of factual information.

@ardumont, Can I:

Apr 16 2018, 8:58 AM · Indexer, Easy hack, Web app

Mar 21 2018

s added a comment to D302: swh.web.common.service: Update lookup_content_license..

In D302#6173, @ardumont wrote:

Tested locally and all fine. Nice job!

Mar 21 2018, 4:55 AM

s added a comment to D301: swh.indexer.storage: Refactor fossology license get.

In D301#6174, @ardumont wrote:

Tested locally and all fine. Nice job!

Mar 21 2018, 4:54 AM

Mar 20 2018

s added a comment to D302: swh.web.common.service: Update lookup_content_license..

In D302#6155, @ardumont wrote:

Oh, also, i believe the tests need some love:
...

Mar 20 2018, 5:49 AM

s added a comment to D301: swh.indexer.storage: Refactor fossology license get.

In D301#6156, @ardumont wrote:

Remains to adapt the tests accordingly ;)

...

Mar 20 2018, 5:47 AM

s updated the diff for D301: swh.indexer.storage: Refactor fossology license get.

swh: Fix test for db_to_fossology_license.
swh: Fix tests in CommonTestStorage.

Mar 20 2018, 5:46 AM

s updated the diff for D302: swh.web.common.service: Update lookup_content_license..

swh.web.tests.common.test_service: Fix tests in ServiceTestCase

Mar 20 2018, 5:31 AM

s added a comment to D302: swh.web.common.service: Update lookup_content_license..

In D302#6155, @ardumont wrote:
Oh, also, i believe the tests need some love:
make test
should give you some hints ;)

Mar 20 2018, 3:54 AM

s added a comment to D302: swh.web.common.service: Update lookup_content_license..

In D302#6153, @ardumont wrote:

Sounds good.

One minor nitpick in the description

Now, lookup_content_license function returns a dictionary with the following keys

Now reading this comment and the code could be confusing (we say it's a dict but the code extract data from list ;)
So clarifying, D301 introduces a dict generator (well, depending on the deployed configuration).
As you mentioned, each dict holds 1 key sha1 and 1 value which are facts, list of {tool + associated detected license for that tool on the sha1}

Mar 20 2018, 3:53 AM

Mar 17 2018

s added inline comments to D301: swh.indexer.storage: Refactor fossology license get.

Mar 17 2018, 9:55 PM

Herald added a reviewer for D302: swh.web.common.service: Update lookup_content_license.: Reviewers.

Mar 17 2018, 9:51 PM

s added a revision to T782: Web API: make endpoints that expose extracted metadata return *lists* of factual information: D302: swh.web.common.service: Update lookup_content_license..

Mar 17 2018, 9:51 PM · Indexer, Easy hack, Web app

s updated the diff for D301: swh.indexer.storage: Refactor fossology license get.

Change structure of yield value for content_fossology_license_get

Mar 17 2018, 9:28 PM

Mar 16 2018

s added a comment to T782: Web API: make endpoints that expose extracted metadata return *lists* of factual information.

Setup

If the changes look good, I'll update the failing tests and submit a patch for code review.

I'd be more than ok if you could open a diff now with arcanist?
(Even if tests are not completely ok yet ;)

Mar 16 2018, 4:52 AM · Indexer, Easy hack, Web app

s created D301: swh.indexer.storage: Refactor fossology license get.

Mar 16 2018, 4:46 AM

s added a revision to T782: Web API: make endpoints that expose extracted metadata return *lists* of factual information: D301: swh.indexer.storage: Refactor fossology license get.

Mar 16 2018, 4:46 AM · Indexer, Easy hack, Web app

Mar 15 2018

s added a comment to T782: Web API: make endpoints that expose extracted metadata return *lists* of factual information.

@ardumont, Thanks for the data dumps (F3040109 and F3040114). I'm able [[ https://ricketyspace.net/tmp/t782-swh-indexer-changes.webm | to test the /api/1/content/sha1:HASH/license/ endpoint ]].

Mar 15 2018, 5:37 AM · Indexer, Easy hack, Web app

Mar 14 2018

s added a comment to T782: Web API: make endpoints that expose extracted metadata return *lists* of factual information.

@ardumont Thank you very much for helping out.

Mar 14 2018, 6:02 AM · Indexer, Easy hack, Web app

Feb 6 2018

s added a comment to T782: Web API: make endpoints that expose extracted metadata return *lists* of factual information.

@zack, I've been getting myself acquainted with the swh codebase for the past few days.

Feb 6 2018, 4:45 AM · Indexer, Easy hack, Web app

Jan 27 2018

s added a comment to T782: Web API: make endpoints that expose extracted metadata return *lists* of factual information.

@zack, I would like to work on this issue.

Jan 27 2018, 7:49 AM · Indexer, Easy hack, Web app