User Details
User Details
- User Since
- Mar 13 2021, 2:03 AM (192 w, 5 d)
Mar 25 2021
Mar 25 2021
rohan-sachan added a comment to D5295: Add type annotations to metadata mappings.
Ok, I'll give another try at rectifying these issues throughout all the files.
Just a quick question, did you review the changes for all the files, or did you review the changes only up to base.py and didn't review further because of the repeated issues?
Mar 24 2021
Mar 24 2021
rohan-sachan added a comment to D5295: Add type annotations to metadata mappings.
rohan-sachan retitled D5295: Add type annotations to metadata mappings from Add type annotations to metadata mappings Closes T2259 to Add type annotations to metadata mappings.
rohan-sachan updated the diff for D5295: Add type annotations to metadata mappings.
Change type annotations to more concrete type
Change Type annotations for all files in swh.indexer.metadata_mapping to reflect more concrete type annotations.
Remove unncesseary usage of # type: ignore
Mar 21 2021
Mar 21 2021
rohan-sachan added a comment to D5295: Add type annotations to metadata mappings.
Thanks for a prompt review.
I'll go level deeper into annotating wherever I have used Any, and wherever it's possible to go a level deeper. Will submit an updated diff by tomorrow.
rohan-sachan retitled D5295: Add type annotations to metadata mappings from Added type annotations to metadata mappings Closes T2259 to Add type annotations to metadata mappings Closes T2259.
rohan-sachan requested review of D5295: Add type annotations to metadata mappings.