Page Menu
Home
Software Heritage
Search
Configure Global Search
Log In
Files
F9341810
D4491.id16112.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Subscribers
None
D4491.id16112.diff
View Options
diff --git a/swh/web/assets/src/bundles/revision/diff-utils.js b/swh/web/assets/src/bundles/revision/diff-utils.js
--- a/swh/web/assets/src/bundles/revision/diff-utils.js
+++ b/swh/web/assets/src/bundles/revision/diff-utils.js
@@ -46,6 +46,8 @@
let selectedDiffLinesInfo;
// URL fragment to append when switching to 'Changes' tab
const changesUrlFragment = '#swh-revision-changes';
+// current displayed tab name
+let currentTabName = 'Files';
// to check if a DOM element is in the viewport
function isInViewport(elt) {
@@ -188,7 +190,9 @@
$('.hljs-ln-line[data-line-number]').css('mix-blend-mode', 'initial');
$('.hljs-ln-numbers[data-line-number]').css('color', '#aaa');
$('.hljs-ln-numbers[data-line-number]').css('font-weight', 'initial');
- window.location.hash = changesUrlFragment;
+ if (currentTabName === 'Changes' && window.location.hash !== changesUrlFragment) {
+ window.location.hash = changesUrlFragment;
+ }
}
// highlight lines in a diff, return first highlighted line numbers element
@@ -660,7 +664,8 @@
// callback when the 'Changes' tab is activated
$(document).on('shown.bs.tab', 'a[data-toggle="tab"]', e => {
- if (e.currentTarget.text.trim() === 'Changes') {
+ currentTabName = e.currentTarget.text.trim();
+ if (currentTabName === 'Changes') {
window.location.hash = changesUrlFragment;
$('#readme-panel').css('display', 'none');
@@ -708,7 +713,7 @@
}
});
- } else if (e.currentTarget.text.trim() === 'Files') {
+ } else if (currentTabName === 'Files') {
removeUrlFragment();
$('#readme-panel').css('display', 'block');
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Jul 3, 12:19 PM (2 w, 4 d ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
3221316
Attached To
D4491: assets/revision/diff-utils: Fix text selection in revision view
Event Timeline
Log In to Comment