No OneTemporary
Actions

Size

147 KB

Subscribers

None

View Options

	diff --git a/PKG-INFO b/PKG-INFO
	index a4f32d45..dbc5700a 100644
	--- a/PKG-INFO
	+++ b/PKG-INFO
	@@ -1,10 +1,10 @@
	Metadata-Version: 1.0
	Name: swh.storage
	-Version: 0.0.30
	+Version: 0.0.31
	Summary: Software Heritage storage manager
	Home-page: https://forge.softwareheritage.org/diffusion/DSTO/
	Author: Software Heritage developers
	Author-email: swh-devel@inria.fr
	License: UNKNOWN
	Description: UNKNOWN
	Platform: UNKNOWN
	diff --git a/debian/changelog b/debian/changelog
	index 70ba400b..cb37593a 100644
	--- a/debian/changelog
	+++ b/debian/changelog
	@@ -1,222 +1,224 @@
	-swh-storage (0.0.30-1~swh1~bpo9+1) stretch-swh; urgency=medium
	+swh-storage (0.0.31-1~swh1) unstable-swh; urgency=medium

	- * Rebuild for stretch-backports.
	+ * v0.0.31
	+ * Deal with occurrence_history.branch, occurrence.branch, release.name
	+ as bytes

	- -- Nicolas Dandrimont <nicolas@dandrimont.eu> Tue, 26 Jan 2016 07:36:44 +0100
	+ -- Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com> Wed, 27 Jan 2016 15:45:53 +0100

	swh-storage (0.0.30-1~swh1) unstable-swh; urgency=medium

	* Prepare swh.storage v0.0.30 release
	* type-agnostic occurrences and revisions

	-- Nicolas Dandrimont <nicolas@dandrimont.eu> Tue, 26 Jan 2016 07:36:43 +0100

	swh-storage (0.0.29-1~swh1) unstable-swh; urgency=medium

	* v0.0.29
	* New:
	* Upgrade sql schema to 041→043
	* Deal with communication downtime between clients and storage
	* Open occurrence_get(origin_id) to retrieve latest occurrences per
	origin
	* Open release_get_by to retrieve a release by origin
	* Open directory_get to retrieve information on directory by id
	* Open entity_get to retrieve information on entity + hierarchy from
	its uuid
	* Open directory_get that retrieve information on directory per id
	* Update:
	* directory_get/directory_ls: Rename to directory_ls
	* revision_log: update to retrieve logs from multiple root revisions
	* revision_get_by: branch name filtering is now optional

	-- Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com> Wed, 20 Jan 2016 16:15:50 +0100

	swh-storage (0.0.28-1~swh1) unstable-swh; urgency=medium

	* v0.0.28
	* Open entity_get api

	-- Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com> Fri, 15 Jan 2016 16:37:27 +0100

	swh-storage (0.0.27-1~swh1) unstable-swh; urgency=medium

	* v0.0.27
	* Open directory_entry_get_by_path api
	* Improve get_revision_by api performance
	* sql/swh-schema: add index on origin(type, url) --> improve origin
	lookup api
	* Bump to 039 db version

	-- Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com> Fri, 15 Jan 2016 12:42:47 +0100

	swh-storage (0.0.26-1~swh1) unstable-swh; urgency=medium

	* v0.0.26
	* Open revision_get_by to retrieve a revision by occurrence criterion
	filtering
	* sql/upgrades/036: add 035→036 upgrade script

	-- Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com> Wed, 13 Jan 2016 12:46:44 +0100

	swh-storage (0.0.25-1~swh1) unstable-swh; urgency=medium

	* v0.0.25
	* Limit results in swh_revision_list*
	* Create the package to align the current db production version on
	https://archive.softwareheritage.org/

	-- Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com> Fri, 08 Jan 2016 11:33:08 +0100

	swh-storage (0.0.24-1~swh1) unstable-swh; urgency=medium

	* Prepare swh.storage release v0.0.24
	* Add a limit argument to revision_log

	-- Nicolas Dandrimont <nicolas@dandrimont.eu> Wed, 06 Jan 2016 15:12:53 +0100

	swh-storage (0.0.23-1~swh1) unstable-swh; urgency=medium

	* v0.0.23
	* Protect against overflow, wrapped in ValueError for client
	* Fix relative path import for remote storage.
	* api to retrieve revision_log is now 'parents' aware

	-- Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com> Wed, 06 Jan 2016 11:30:58 +0100

	swh-storage (0.0.22-1~swh1) unstable-swh; urgency=medium

	* Release v0.0.22
	* Fix relative import for remote storage

	-- Nicolas Dandrimont <nicolas@dandrimont.eu> Wed, 16 Dec 2015 16:04:48 +0100

	swh-storage (0.0.21-1~swh1) unstable-swh; urgency=medium

	* Prepare release v0.0.21
	* Protect the storage api client from overflows
	* Add a get_storage function mapping to local or remote storage

	-- Nicolas Dandrimont <nicolas@dandrimont.eu> Wed, 16 Dec 2015 13:34:46 +0100

	swh-storage (0.0.20-1~swh1) unstable-swh; urgency=medium

	* v0.0.20
	* allow numeric timestamps with offset
	* Open revision_log api
	* start migration to swh.model

	-- Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com> Mon, 07 Dec 2015 15:20:36 +0100

	swh-storage (0.0.19-1~swh1) unstable-swh; urgency=medium

	* v0.0.19
	* Improve directory listing with content data
	* Open person_get
	* Open release_get data reading
	* Improve origin_get api
	* Effort to unify api output on dict (for read)
	* Migrate backend to 032

	-- Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com> Fri, 27 Nov 2015 13:33:34 +0100

	swh-storage (0.0.18-1~swh1) unstable-swh; urgency=medium

	* v0.0.18
	* Improve origin_get to permit retrieval per id
	* Update directory_get implementation (add join from
	* directory_entry_file to content)
	* Open release_get : [sha1] -> [Release]

	-- Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com> Thu, 19 Nov 2015 11:18:35 +0100

	swh-storage (0.0.17-1~swh1) unstable-swh; urgency=medium

	* Prepare deployment of swh.storage v0.0.17
	* Add some entity related entry points

	-- Nicolas Dandrimont <nicolas@dandrimont.eu> Tue, 03 Nov 2015 16:40:59 +0100

	swh-storage (0.0.16-1~swh1) unstable-swh; urgency=medium

	* v0.0.16
	* Add metadata column in revision (db version 29)
	* cache http connection for remote storage client

	-- Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com> Thu, 29 Oct 2015 10:29:00 +0100

	swh-storage (0.0.15-1~swh1) unstable-swh; urgency=medium

	* Prepare deployment of swh.storage v0.0.15
	* Allow population of fetch_history
	* Update organizations / projects as entities
	* Use schema v028 for directory addition

	-- Nicolas Dandrimont <nicolas@dandrimont.eu> Tue, 27 Oct 2015 11:43:39 +0100

	swh-storage (0.0.14-1~swh1) unstable-swh; urgency=medium

	* Prepare swh.storage v0.0.14 deployment

	-- Nicolas Dandrimont <nicolas@dandrimont.eu> Fri, 16 Oct 2015 15:34:08 +0200

	swh-storage (0.0.13-1~swh1) unstable-swh; urgency=medium

	* Prepare deploying swh.storage v0.0.13

	-- Nicolas Dandrimont <nicolas@dandrimont.eu> Fri, 16 Oct 2015 14:51:44 +0200

	swh-storage (0.0.12-1~swh1) unstable-swh; urgency=medium

	* Prepare deploying swh.storage v0.0.12

	-- Nicolas Dandrimont <nicolas@dandrimont.eu> Tue, 13 Oct 2015 12:39:18 +0200

	swh-storage (0.0.11-1~swh1) unstable-swh; urgency=medium

	* Preparing deployment of swh.storage v0.0.11

	-- Nicolas Dandrimont <nicolas@dandrimont.eu> Fri, 09 Oct 2015 17:44:51 +0200

	swh-storage (0.0.10-1~swh1) unstable-swh; urgency=medium

	* Prepare deployment of swh.storage v0.0.10

	-- Nicolas Dandrimont <nicolas@dandrimont.eu> Tue, 06 Oct 2015 17:37:00 +0200

	swh-storage (0.0.9-1~swh1) unstable-swh; urgency=medium

	* Prepare deployment of swh.storage v0.0.9

	-- Nicolas Dandrimont <nicolas@dandrimont.eu> Thu, 01 Oct 2015 19:03:00 +0200

	swh-storage (0.0.8-1~swh1) unstable-swh; urgency=medium

	* Prepare deployment of swh.storage v0.0.8

	-- Nicolas Dandrimont <nicolas@dandrimont.eu> Thu, 01 Oct 2015 11:32:46 +0200

	swh-storage (0.0.7-1~swh1) unstable-swh; urgency=medium

	* Prepare deployment of swh.storage v0.0.7

	-- Nicolas Dandrimont <nicolas@dandrimont.eu> Tue, 29 Sep 2015 16:52:54 +0200

	swh-storage (0.0.6-1~swh1) unstable-swh; urgency=medium

	* Prepare deployment of swh.storage v0.0.6

	-- Nicolas Dandrimont <nicolas@dandrimont.eu> Tue, 29 Sep 2015 16:43:24 +0200

	swh-storage (0.0.5-1~swh1) unstable-swh; urgency=medium

	* Prepare deploying swh.storage v0.0.5

	-- Nicolas Dandrimont <nicolas@dandrimont.eu> Tue, 29 Sep 2015 16:27:00 +0200

	swh-storage (0.0.1-1~swh1) unstable-swh; urgency=medium

	* Initial release
	* swh.storage.api: Properly escape arbitrary byte sequences in
	arguments

	-- Nicolas Dandrimont <nicolas@dandrimont.eu> Tue, 22 Sep 2015 17:02:34 +0200
	diff --git a/sql/swh-func.sql b/sql/swh-func.sql
	index 4f39de02..797ab1a9 100644
	--- a/sql/swh-func.sql
	+++ b/sql/swh-func.sql
	@@ -1,1138 +1,1138 @@
	-- create a temporary table called tmp_TBLNAME, mimicking existing table
	-- TBLNAME
	--
	-- Args:
	-- tblname: name of the table to mimick
	create or replace function swh_mktemp(tblname regclass)
	returns void
	language plpgsql
	as $$
	begin
	execute format('
	create temporary table tmp_%I
	(like %I including defaults)
	on commit drop
	', tblname, tblname);
	return;
	end
	$$;


	-- create a temporary table for directory entries called tmp_TBLNAME,
	-- mimicking existing table TBLNAME with an extra dir_id (sha1_git)
	-- column, and dropping the id column.
	--
	-- This is used to create the tmp_directory_entry_<foo> tables.
	--
	-- Args:
	-- tblname: name of the table to mimick
	create or replace function swh_mktemp_dir_entry(tblname regclass)
	returns void
	language plpgsql
	as $$
	begin
	execute format('
	create temporary table tmp_%I
	(like %I including defaults, dir_id sha1_git)
	on commit drop;
	alter table tmp_%I drop column id;
	', tblname, tblname, tblname, tblname);
	return;
	end
	$$;


	-- create a temporary table for revisions called tmp_revisions,
	-- mimicking existing table revision, replacing the foreign keys to
	-- people with an email and name field
	--
	create or replace function swh_mktemp_revision()
	returns void
	language sql
	as $$
	create temporary table tmp_revision (
	like revision including defaults,
	author_name bytea not null default '',
	author_email bytea not null default '',
	committer_name bytea not null default '',
	committer_email bytea not null default ''
	) on commit drop;
	alter table tmp_revision drop column author;
	alter table tmp_revision drop column committer;
	$$;


	-- create a temporary table for releases called tmp_release,
	-- mimicking existing table release, replacing the foreign keys to
	-- people with an email and name field
	--
	create or replace function swh_mktemp_release()
	returns void
	language sql
	as $$
	create temporary table tmp_release (
	like release including defaults,
	author_name bytea not null default '',
	author_email bytea not null default ''
	) on commit drop;
	alter table tmp_release drop column author;
	$$;

	create or replace function swh_mktemp_release_get()
	returns void
	language sql
	as $$
	create temporary table tmp_release_get(
	id sha1_git primary key
	) on commit drop;
	$$;

	-- create a temporary table for entity_history, sans id
	create or replace function swh_mktemp_entity_history()
	returns void
	language sql
	as $$
	create temporary table tmp_entity_history (
	like entity_history including defaults);
	alter table tmp_entity_history drop column id;
	$$;

	-- create a temporary table for entities called tmp_entity_lister,
	-- with only the columns necessary for retrieving the uuid of a listed
	-- entity.
	create or replace function swh_mktemp_entity_lister()
	returns void
	language sql
	as $$
	create temporary table tmp_entity_lister (
	id bigint,
	lister uuid,
	lister_metadata jsonb
	);
	$$;

	-- a content signature is a set of cryptographic checksums that we use to
	-- uniquely identify content, for the purpose of verifying if we already have
	-- some content or not during content injection
	create type content_signature as (
	sha1 sha1,
	sha1_git sha1_git,
	sha256 sha256
	);


	-- check which entries of tmp_content are missing from content
	--
	-- operates in bulk: 0. swh_mktemp(content), 1. COPY to tmp_content,
	-- 2. call this function
	create or replace function swh_content_missing()
	returns setof content_signature
	language plpgsql
	as $$
	begin
	-- This query is critical for (single-algorithm) hash collision detection,
	-- so we cannot rely only on the fact that a single hash (e.g., sha1) is
	-- missing from the table content to conclude that a given content is
	-- missing. Ideally, we would want to (try to) add to content all entries
	-- in tmp_content that, when considering all columns together, are missing
	-- from content.
	--
	-- But doing that naively would require a compound index on all checksum
	-- columns; that index would not be significantly smaller than the content
	-- table itself, and therefore won't be used. Therefore we union together
	-- all contents that differ on at least one column from what is already
	-- available. If there is a collision on some (but not all) columns, the
	-- relevant tmp_content entry will be included in the set of content to be
	-- added, causing a downstream violation of unicity constraint.
	return query
	(select sha1, sha1_git, sha256 from tmp_content as tmp
	where not exists
	(select 1 from content as c where c.sha1 = tmp.sha1))
	union
	(select sha1, sha1_git, sha256 from tmp_content as tmp
	where not exists
	(select 1 from content as c where c.sha1_git = tmp.sha1_git))
	union
	(select sha1, sha1_git, sha256 from tmp_content as tmp
	where not exists
	(select 1 from content as c where c.sha256 = tmp.sha256));
	return;
	end
	$$;


	-- check which entries of tmp_skipped_content are missing from skipped_content
	--
	-- operates in bulk: 0. swh_mktemp(skipped_content), 1. COPY to tmp_skipped_content,
	-- 2. call this function
	create or replace function swh_skipped_content_missing()
	returns setof content_signature
	language plpgsql
	as $$
	begin
	return query
	select sha1, sha1_git, sha256 from tmp_skipped_content t
	where not exists
	(select 1 from skipped_content s where
	s.sha1 is not distinct from t.sha1 and
	s.sha1_git is not distinct from t.sha1_git and
	s.sha256 is not distinct from t.sha256);
	return;
	end
	$$;


	-- Look up content based on one or several different checksums. Return all
	-- content information if the content is found; a NULL row otherwise.
	--
	-- At least one checksum should be not NULL. If several are not NULL, they will
	-- be AND-ed together in the lookup query.
	--
	-- Note: this function is meant to be used to look up individual contents
	-- (e.g., for the web app), for batch lookup of missing content (e.g., to be
	-- added) see swh_content_missing
	create or replace function swh_content_find(
	sha1 sha1 default NULL,
	sha1_git sha1_git default NULL,
	sha256 sha256 default NULL
	)
	returns content
	language plpgsql
	as $$
	declare
	con content;
	filters text[] := array[] :: text[]; -- AND-clauses used to filter content
	q text;
	begin
	if sha1 is not null then
	filters := filters \|\| format('sha1 = %L', sha1);
	end if;
	if sha1_git is not null then
	filters := filters \|\| format('sha1_git = %L', sha1_git);
	end if;
	if sha256 is not null then
	filters := filters \|\| format('sha256 = %L', sha256);
	end if;

	if cardinality(filters) = 0 then
	return null;
	else
	q = format('select * from content where %s',
	array_to_string(filters, ' and '));
	execute q into con;
	return con;
	end if;
	end
	$$;


	-- add tmp_content entries to content, skipping duplicates
	--
	-- operates in bulk: 0. swh_mktemp(content), 1. COPY to tmp_content,
	-- 2. call this function
	create or replace function swh_content_add()
	returns void
	language plpgsql
	as $$
	begin
	insert into content (sha1, sha1_git, sha256, length, status)
	select distinct sha1, sha1_git, sha256, length, status
	from tmp_content
	where (sha1, sha1_git, sha256) in
	(select * from swh_content_missing());
	-- TODO XXX use postgres 9.5 "UPSERT" support here, when available.
	-- Specifically, using "INSERT .. ON CONFLICT IGNORE" we can avoid
	-- the extra swh_content_missing() query here.
	return;
	end
	$$;


	-- add tmp_skipped_content entries to skipped_content, skipping duplicates
	--
	-- operates in bulk: 0. swh_mktemp(skipped_content), 1. COPY to tmp_skipped_content,
	-- 2. call this function
	create or replace function swh_skipped_content_add()
	returns void
	language plpgsql
	as $$
	begin
	insert into skipped_content (sha1, sha1_git, sha256, length, status, reason, origin)
	select distinct sha1, sha1_git, sha256, length, status, reason, origin
	from tmp_skipped_content
	where (coalesce(sha1, ''), coalesce(sha1_git, ''), coalesce(sha256, '')) in
	(select coalesce(sha1, ''), coalesce(sha1_git, ''), coalesce(sha256, '') from swh_skipped_content_missing());
	-- TODO XXX use postgres 9.5 "UPSERT" support here, when available.
	-- Specifically, using "INSERT .. ON CONFLICT IGNORE" we can avoid
	-- the extra swh_content_missing() query here.
	return;
	end
	$$;


	-- check which entries of tmp_directory are missing from directory
	--
	-- operates in bulk: 0. swh_mktemp(directory), 1. COPY to tmp_directory,
	-- 2. call this function
	create or replace function swh_directory_missing()
	returns setof sha1_git
	language plpgsql
	as $$
	begin
	return query
	select id from tmp_directory t
	where not exists (
	select 1 from directory d
	where d.id = t.id);
	return;
	end
	$$;


	-- Retrieve information on directory from temporary table
	create or replace function swh_directory_get()
	returns setof directory
	language plpgsql
	as $$
	begin
	return query
	select d.*
	from tmp_directory t
	inner join directory d on t.id = d.id;
	return;
	end
	$$;


	create type directory_entry_type as enum('file', 'dir', 'rev');


	-- Add tmp_directory_entry_* entries to directory_entry_* and directory,
	-- skipping duplicates in directory_entry_*. This is a generic function that
	-- works on all kind of directory entries.
	--
	-- operates in bulk: 0. swh_mktemp_dir_entry('directory_entry_*'), 1 COPY to
	-- tmp_directory_entry_*, 2. call this function
	--
	-- Assumption: this function is used in the same transaction that inserts the
	-- context directory in table "directory".
	create or replace function swh_directory_entry_add(typ directory_entry_type)
	returns void
	language plpgsql
	as $$
	begin
	execute format('
	insert into directory_entry_%1$s (target, name, perms)
	select distinct t.target, t.name, t.perms
	from tmp_directory_entry_%1$s t
	where not exists (
	select 1
	from directory_entry_%1$s i
	where t.target = i.target and t.name = i.name and t.perms = i.perms)
	', typ);

	execute format('
	with new_entries as (
	select t.dir_id, array_agg(i.id) as entries
	from tmp_directory_entry_%1$s t
	inner join directory_entry_%1$s i
	using (target, name, perms)
	group by t.dir_id
	)
	update tmp_directory as d
	set %1$s_entries = new_entries.entries
	from new_entries
	where d.id = new_entries.dir_id
	', typ);

	return;
	end
	$$;

	-- Insert the data from tmp_directory, tmp_directory_entry_file,
	-- tmp_directory_entry_dir, tmp_directory_entry_rev into their final
	-- tables.
	--
	-- Prerequisites:
	-- directory ids in tmp_directory
	-- entries in tmp_directory_entry_{file,dir,rev}
	--
	create or replace function swh_directory_add()
	returns void
	language plpgsql
	as $$
	begin
	perform swh_directory_entry_add('file');
	perform swh_directory_entry_add('dir');
	perform swh_directory_entry_add('rev');

	insert into directory
	select * from tmp_directory t
	where not exists (
	select 1 from directory d
	where d.id = t.id);

	return;
	end
	$$;

	-- a directory listing entry with all the metadata
	--
	-- can be used to list a directory, and retrieve all the data in one go.
	create type directory_entry as
	(
	dir_id sha1_git, -- id of the parent directory
	type directory_entry_type, -- type of entry
	target sha1_git, -- id of target
	name unix_path, -- path name, relative to containing dir
	perms file_perms, -- unix-like permissions
	status content_status, -- visible or absent
	sha1 sha1, -- content if sha1 if type is not dir
	sha1_git sha1_git, -- content's sha1 git if type is not dir
	sha256 sha256 -- content's sha256 if type is not dir
	);


	-- List a single level of directory walked_dir_id
	-- FIXME: order by name is not correct. For git, we need to order by
	-- lexicographic order but as if a trailing / is present in directory
	-- name
	create or replace function swh_directory_walk_one(walked_dir_id sha1_git)
	returns setof directory_entry
	language sql
	stable
	as $$
	with dir as (
	select id as dir_id, dir_entries, file_entries, rev_entries
	from directory
	where id = walked_dir_id),
	ls_d as (select dir_id, unnest(dir_entries) as entry_id from dir),
	ls_f as (select dir_id, unnest(file_entries) as entry_id from dir),
	ls_r as (select dir_id, unnest(rev_entries) as entry_id from dir)
	(select dir_id, 'dir'::directory_entry_type as type,
	e.target, e.name, e.perms, NULL::content_status,
	NULL::sha1, NULL::sha1_git, NULL::sha256
	from ls_d
	left join directory_entry_dir e on ls_d.entry_id = e.id)
	union
	(select dir_id, 'file'::directory_entry_type as type,
	e.target, e.name, e.perms, c.status,
	c.sha1, c.sha1_git, c.sha256
	from ls_f
	left join directory_entry_file e on ls_f.entry_id = e.id
	left join content c on e.target = c.sha1_git)
	union
	(select dir_id, 'rev'::directory_entry_type as type,
	e.target, e.name, e.perms, NULL::content_status,
	NULL::sha1, NULL::sha1_git, NULL::sha256
	from ls_r
	left join directory_entry_rev e on ls_r.entry_id = e.id)
	order by name;
	$$;

	-- List recursively the content of a directory
	create or replace function swh_directory_walk(walked_dir_id sha1_git)
	returns setof directory_entry
	language sql
	stable
	as $$
	with recursive entries as (
	select dir_id, type, target, name, perms, status, sha1, sha1_git,
	sha256
	from swh_directory_walk_one(walked_dir_id)
	union all
	select dir_id, type, target, (dirname \|\| '/' \|\| name)::unix_path as name,
	perms, status, sha1, sha1_git, sha256
	from (select (swh_directory_walk_one(dirs.target)).*, dirs.name as dirname
	from (select target, name from entries where type = 'dir') as dirs) as with_parent
	)
	select dir_id, type, target, name, perms, status, sha1, sha1_git, sha256
	from entries
	$$;

	-- Find a directory entry by its path
	create or replace function swh_find_directory_entry_by_path(
	walked_dir_id sha1_git,
	dir_or_content_path bytea[])
	returns directory_entry
	language plpgsql
	as $$
	declare
	end_index integer;
	paths bytea default '';
	path bytea;
	res bytea[];
	r record;
	begin
	end_index := array_upper(dir_or_content_path, 1);
	res[1] := walked_dir_id;

	for i in 1..end_index
	loop
	path := dir_or_content_path[i];
	-- concatenate path for patching the name in the result record (if we found it)
	if i = 1 then
	paths = path;
	else
	paths := paths \|\| '/' \|\| path; -- concatenate paths
	end if;

	if i <> end_index then
	select *
	from swh_directory_walk_one(res[i] :: sha1_git)
	where name=path
	and type = 'dir'
	limit 1 into r;
	else
	select *
	from swh_directory_walk_one(res[i] :: sha1_git)
	where name=path
	limit 1 into r;
	end if;

	-- find the path
	if r is null then
	return null;
	else
	-- store the next dir to lookup the next local path from
	res[i+1] := r.target;
	end if;
	end loop;

	-- at this moment, r is the result. Patch its 'name' with the full path before returning it.
	r.name := paths;
	return r;
	end
	$$;

	-- List all revision IDs starting from a given revision, going back in time
	--
	-- TODO ordering: should be breadth-first right now (what do we want?)
	-- TODO ordering: ORDER BY parent_rank somewhere?
	create or replace function swh_revision_list(root_revisions bytea[], num_revs bigint default NULL)
	returns table (id sha1_git, parents bytea[])
	language sql
	stable
	as $$
	with recursive full_rev_list(id) as (
	(select id from revision where id = ANY(root_revisions))
	union
	(select h.parent_id
	from revision_history as h
	join full_rev_list on h.id = full_rev_list.id)
	),
	rev_list as (select id from full_rev_list limit num_revs)
	select rev_list.id as id,
	array(select rh.parent_id::bytea
	from revision_history rh
	where rh.id = rev_list.id
	order by rh.parent_rank
	) as parent
	from rev_list;
	$$;

	-- List all the children of a given revision
	create or replace function swh_revision_list_children(root_revisions bytea[], num_revs bigint default NULL)
	returns table (id sha1_git, parents bytea[])
	language sql
	stable
	as $$
	with recursive full_rev_list(id) as (
	(select id from revision where id = ANY(root_revisions))
	union
	(select h.id
	from revision_history as h
	join full_rev_list on h.parent_id = full_rev_list.id)
	),
	rev_list as (select id from full_rev_list limit num_revs)
	select rev_list.id as id,
	array(select rh.parent_id::bytea
	from revision_history rh
	where rh.id = rev_list.id
	order by rh.parent_rank
	) as parent
	from rev_list;
	$$;


	-- Detailed entry for a revision
	create type revision_entry as
	(
	id sha1_git,
	date timestamptz,
	date_offset smallint,
	committer_date timestamptz,
	committer_date_offset smallint,
	type revision_type,
	directory sha1_git,
	message bytea,
	author_name bytea,
	author_email bytea,
	committer_name bytea,
	committer_email bytea,
	metadata jsonb,
	synthetic boolean,
	parents bytea[]
	);


	-- "git style" revision log. Similar to swh_revision_list(), but returning all
	-- information associated to each revision, and expanding authors/committers
	create or replace function swh_revision_log(root_revisions bytea[], num_revs bigint default NULL)
	returns setof revision_entry
	language sql
	stable
	as $$
	select t.id, r.date, r.date_offset,
	r.committer_date, r.committer_date_offset,
	r.type, r.directory, r.message,
	a.name, a.email, c.name, c.email, r.metadata, r.synthetic,
	t.parents
	from swh_revision_list(root_revisions, num_revs) as t
	left join revision r on t.id = r.id
	left join person a on a.id = r.author
	left join person c on c.id = r.committer;
	$$;


	-- Retrieve revisions from tmp_revision in bulk
	create or replace function swh_revision_get()
	returns setof revision_entry
	language plpgsql
	as $$
	begin
	return query
	select t.id, r.date, r.date_offset,
	r.committer_date, r.committer_date_offset,
	r.type, r.directory, r.message,
	a.name, a.email, c.name, c.email, r.metadata, r.synthetic,
	array(select rh.parent_id::bytea from revision_history rh where rh.id = t.id order by rh.parent_rank)
	as parents
	from tmp_revision t
	left join revision r on t.id = r.id
	left join person a on a.id = r.author
	left join person c on c.id = r.committer;
	return;
	end
	$$;

	-- List missing revisions from tmp_revision
	create or replace function swh_revision_missing()
	returns setof sha1_git
	language plpgsql
	as $$
	begin
	return query
	select id from tmp_revision t
	where not exists (
	select 1 from revision r
	where r.id = t.id);
	return;
	end
	$$;

	-- Detailed entry for a release
	create type release_entry as
	(
	id sha1_git,
	target sha1_git,
	target_type object_type,
	date timestamptz,
	date_offset smallint,
	- name text,
	+ name bytea,
	comment bytea,
	synthetic boolean,
	author_name bytea,
	author_email bytea
	);

	-- Detailed entry for release
	create or replace function swh_release_get()
	returns setof release_entry
	language plpgsql
	as $$
	begin
	return query
	select r.id, r.target, r.target_type, r.date, r.date_offset, r.name, r.comment,
	r.synthetic, p.name as author_name, p.email as author_email
	from tmp_release_get t
	inner join release r on t.id = r.id
	inner join person p on p.id = r.author;
	return;
	end
	$$;

	-- Create entries in person from tmp_revision
	create or replace function swh_person_add_from_revision()
	returns void
	language plpgsql
	as $$
	begin
	with t as (
	select author_name as name, author_email as email from tmp_revision
	union
	select committer_name as name, committer_email as email from tmp_revision
	) insert into person (name, email)
	select distinct name, email from t
	where not exists (
	select 1
	from person p
	where t.name = p.name and t.email = p.email
	);
	return;
	end
	$$;


	-- Create entries in revision from tmp_revision
	create or replace function swh_revision_add()
	returns void
	language plpgsql
	as $$
	begin
	perform swh_person_add_from_revision();

	insert into revision (id, date, date_offset, committer_date, committer_date_offset, type, directory, message, author, committer, metadata, synthetic)
	select t.id, t.date, t.date_offset, t.committer_date, t.committer_date_offset, t.type, t.directory, t.message, a.id, c.id, t.metadata, t.synthetic
	from tmp_revision t
	left join person a on a.name = t.author_name and a.email = t.author_email
	left join person c on c.name = t.committer_name and c.email = t.committer_email;
	return;
	end
	$$;


	-- List missing releases from tmp_release
	create or replace function swh_release_missing()
	returns setof sha1_git
	language plpgsql
	as $$
	begin
	return query
	select id from tmp_release t
	where not exists (
	select 1 from release r
	where r.id = t.id);
	return;
	end
	$$;


	-- Create entries in person from tmp_release
	create or replace function swh_person_add_from_release()
	returns void
	language plpgsql
	as $$
	begin
	with t as (
	select distinct author_name as name, author_email as email from tmp_release
	) insert into person (name, email)
	select name, email from t
	where not exists (
	select 1
	from person p
	where t.name = p.name and t.email = p.email
	);
	return;
	end
	$$;


	-- Create entries in release from tmp_release
	create or replace function swh_release_add()
	returns void
	language plpgsql
	as $$
	begin
	perform swh_person_add_from_release();

	insert into release (id, target, target_type, date, date_offset, name, comment, author, synthetic)
	select t.id, t.target, t.target_type, t.date, t.date_offset, t.name, t.comment, a.id, t.synthetic
	from tmp_release t
	left join person a on a.name = t.author_name and a.email = t.author_email;
	return;
	end
	$$;

	-- add tmp_occurrence_history entries to occurrence_history
	--
	-- operates in bulk: 0. swh_mktemp(occurrence_history), 1. COPY to tmp_occurrence_history,
	-- 2. call this function
	create or replace function swh_occurrence_history_add()
	returns void
	language plpgsql
	as $$
	begin
	-- Update intervals we have the data to update
	with new_intervals as (
	select t.origin, t.branch, t.authority, t.validity,
	o.validity - t.validity as new_validity
	from tmp_occurrence_history t
	left join occurrence_history o
	using (origin, branch, authority)
	where o.origin is not null),
	-- do not update intervals if they would become empty (perfect overlap)
	to_update as (
	select * from new_intervals
	where not isempty(new_validity))
	update occurrence_history o set validity = t.new_validity
	from to_update t
	where o.origin = t.origin and o.branch = t.branch and o.authority = t.authority;

	-- Now only insert intervals that aren't already present
	insert into occurrence_history (origin, branch, target, target_type, authority, validity)
	select distinct origin, branch, target, target_type, authority, validity
	from tmp_occurrence_history t
	where not exists (
	select 1 from occurrence_history o
	where o.origin = t.origin and o.branch = t.branch and
	o.authority = t.authority and o.target = t.target and
	o.target_type = t.target_type and o.validity = t.validity);
	return;
	end
	$$;


	-- Absolute path: directory reference + complete path relative to it
	create type content_dir as (
	directory sha1_git,
	path unix_path
	);


	-- Find the containing directory of a given content, specified by sha1
	-- (note: not sha1_git).
	--
	-- Return a pair (dir_it, path) where path is a UNIX path that, from the
	-- directory root, reach down to a file with the desired content. Return NULL
	-- if no match is found.
	--
	-- In case of multiple paths (i.e., pretty much always), an arbitrary one is
	-- chosen.
	create or replace function swh_content_find_directory(content_id sha1)
	returns content_dir
	language sql
	stable
	as $$
	with recursive path as (
	-- Recursively build a path from the requested content to a root
	-- directory. Each iteration returns a pair (dir_id, filename) where
	-- filename is relative to dir_id. Stops when no parent directory can
	-- be found.
	(select dir.id as dir_id, dir_entry_f.name as name, 0 as depth
	from directory_entry_file as dir_entry_f
	join content on content.sha1_git = dir_entry_f.target
	join directory as dir on dir.file_entries @> array[dir_entry_f.id]
	where content.sha1 = content_id
	limit 1)
	union all
	(select dir.id as dir_id,
	(dir_entry_d.name \|\| '/' \|\| path.name)::unix_path as name,
	path.depth + 1
	from path
	join directory_entry_dir as dir_entry_d on dir_entry_d.target = path.dir_id
	join directory as dir on dir.dir_entries @> array[dir_entry_d.id]
	limit 1)
	)
	select dir_id, name from path order by depth desc limit 1;
	$$;


	-- Walk the revision history starting from a given revision, until a matching
	-- occurrence is found. Return all occurrence information if one is found, NULL
	-- otherwise.
	create or replace function swh_revision_find_occurrence(revision_id sha1_git)
	returns occurrence
	language sql
	stable
	as $$
	select origin, branch, target, target_type
	from swh_revision_list_children(ARRAY[revision_id] :: bytea[]) as rev_list
	left join occurrence_history occ_hist
	on rev_list.id = occ_hist.target
	where occ_hist.origin is not null and
	occ_hist.target_type = 'revision'
	order by upper(occ_hist.validity) -- TODO filter by authority?
	limit 1;
	$$;


	-- Retrieve occurrence by filtering on origin_id and optionally on
	-- branch_name and/or validity range
	create or replace function swh_occurrence_get_by(
	origin_id bigint,
	- branch_name text default NULL,
	+ branch_name bytea default NULL,
	validity timestamptz default NULL)
	returns setof occurrence_history
	language plpgsql
	as $$
	declare
	filters text[] := array[] :: text[]; -- AND-clauses used to filter content
	q text;
	begin
	if origin_id is not null then
	filters := filters \|\| format('origin = %L', origin_id);
	end if;
	if branch_name is not null then
	filters := filters \|\| format('branch = %L', branch_name);
	end if;
	if validity is not null then
	filters := filters \|\| format('validity @> %L::timestamptz', validity);
	end if;

	if cardinality(filters) = 0 then
	raise exception 'At least one filter amongst (origin_id, branch_name, validity) is needed';
	else
	q = format('select * ' \|\|
	'from occurrence_history ' \|\|
	'where %s ' \|\|
	'order by validity desc',
	array_to_string(filters, ' and '));
	return query execute q;
	end if;
	end
	$$;


	-- Retrieve revisions by occurrence criterion filtering
	create or replace function swh_revision_get_by(
	origin_id bigint,
	- branch_name text default NULL,
	+ branch_name bytea default NULL,
	validity timestamptz default NULL)
	returns setof revision_entry
	language sql
	stable
	as $$
	select r.id, r.date, r.date_offset,
	r.committer_date, r.committer_date_offset,
	r.type, r.directory, r.message,
	a.name, a.email, c.name, c.email, r.metadata, r.synthetic,
	array(select rh.parent_id::bytea
	from revision_history rh
	where rh.id = r.id
	order by rh.parent_rank
	) as parents
	from swh_occurrence_get_by(origin_id, branch_name, validity) as occ
	inner join revision r on occ.target = r.id
	left join person a on a.id = r.author
	left join person c on c.id = r.committer;
	$$;

	-- Retrieve a release by occurrence criterion
	create or replace function swh_release_get_by(
	origin_id bigint)
	returns setof release_entry
	language sql
	stable
	as $$
	select r.id, r.target, r.target_type, r.date, r.date_offset,
	r.name, r.comment, r.synthetic, a.name as author_name,
	a.email as author_email
	from release r
	inner join occurrence_history occ on occ.target = r.target
	left join person a on a.id = r.author
	where occ.origin = origin_id and occ.target_type = 'revision' and r.target_type = 'revision';
	$$;


	-- Occurrence of some content in a given context
	create type content_occurrence as (
	origin_type text,
	origin_url text,
	- branch text,
	+ branch bytea,
	target sha1_git,
	target_type object_type,
	path unix_path
	);


	-- Given the sha1 of some content, look up an occurrence that points to a
	-- revision, which in turns reference (transitively) a tree containing the
	-- content. Answer the question: "where/when did SWH see a given content"?
	-- Return information about an arbitrary occurrence/revision/tree if one is
	-- found, NULL otherwise.
	create or replace function swh_content_find_occurrence(content_id sha1)
	returns content_occurrence
	language plpgsql
	as $$
	declare
	dir content_dir;
	rev sha1_git;
	occ occurrence%ROWTYPE;
	coc content_occurrence;
	begin
	-- each step could fail if no results are found, and that's OK
	select * from swh_content_find_directory(content_id) -- look up directory
	into dir;
	if not found then return null; end if;

	select id from revision where directory = dir.directory -- look up revision
	limit 1
	into rev;
	if not found then return null; end if;

	select * from swh_revision_find_occurrence(rev) -- look up occurrence
	into occ;
	if not found then return null; end if;

	select origin.type, origin.url, occ.branch, occ.target, occ.target_type, dir.path
	from origin
	where origin.id = occ.origin
	into coc;

	return coc; -- might be NULL
	end
	$$;

	-- Create entries in entity_history from tmp_entity_history
	--
	-- TODO: do something smarter to compress the entries if the data
	-- didn't change.
	create or replace function swh_entity_history_add()
	returns void
	language plpgsql
	as $$
	begin
	insert into entity_history (
	uuid, parent, name, type, description, homepage, active, generated,
	lister, lister_metadata, doap, validity
	) select * from tmp_entity_history;
	return;
	end
	$$;


	create or replace function swh_update_entity_from_entity_history()
	returns trigger
	language plpgsql
	as $$
	begin
	with all_entities as (
	select uuid, parent, name, type, description, homepage, active,
	generated, lister, lister_metadata, doap, last_seen, last_id
	from (
	select row_number() over (partition by uuid order by unnest(validity) desc) as row,
	id as last_id, uuid, parent, name, type, description, homepage, active,
	generated, lister, lister_metadata, doap,
	unnest(validity) as last_seen
	from entity_history
	) as latest_entities
	where latest_entities.row = 1
	),
	updated_uuids as (
	update entity set
	parent = all_entities.parent,
	name = all_entities.name,
	type = all_entities.type,
	description = all_entities.description,
	homepage = all_entities.homepage,
	active = all_entities.active,
	generated = all_entities.generated,
	lister = all_entities.lister,
	lister_metadata = all_entities.lister_metadata,
	doap = all_entities.doap,
	last_seen = all_entities.last_seen,
	last_id = all_entities.last_id
	from all_entities
	where entity.uuid = all_entities.uuid
	returning entity.uuid
	)
	insert into entity
	(select * from all_entities
	where uuid not in (select uuid from updated_uuids));
	return null;
	end
	$$;

	create trigger update_entity
	after insert or update or delete or truncate
	on entity_history
	for each statement
	execute procedure swh_update_entity_from_entity_history();

	-- map an id of tmp_entity_lister to a full entity
	create type entity_id as (
	id bigint,
	uuid uuid,
	parent uuid,
	name text,
	type entity_type,
	description text,
	homepage text,
	active boolean,
	generated boolean,
	lister uuid,
	lister_metadata jsonb,
	doap jsonb,
	last_seen timestamptz,
	last_id bigint
	);

	-- find out the uuid of the entries of entity with the metadata
	-- contained in tmp_entity_lister
	create or replace function swh_entity_from_tmp_entity_lister()
	returns setof entity_id
	language plpgsql
	as $$
	begin
	return query
	select t.id, e.*
	from tmp_entity_lister t
	left join entity e
	on t.lister = e.lister AND e.lister_metadata @> t.lister_metadata;
	return;
	end
	$$;

	create or replace function swh_entity_get(entity_uuid uuid)
	returns setof entity
	language sql
	stable
	as $$
	with recursive entity_hierarchy as (
	select e.*
	from entity e where uuid = entity_uuid
	union
	select p.*
	from entity_hierarchy e
	join entity p on e.parent = p.uuid
	)
	select *
	from entity_hierarchy;
	$$;

	-- simple counter mapping a textual label to an integer value
	create type counter as (
	label text,
	value bigint
	);

	-- return statistics about the number of tuples in various SWH tables
	--
	-- Note: the returned values are based on postgres internal statistics
	-- (pg_class table), which are only updated daily (by autovacuum) or so
	create or replace function swh_stat_counters()
	returns setof counter
	language sql
	stable
	as $$
	select relname::text as label, reltuples::bigint as value
	from pg_class
	where oid in (
	'public.content'::regclass,
	'public.directory'::regclass,
	'public.directory_entry_dir'::regclass,
	'public.directory_entry_file'::regclass,
	'public.directory_entry_rev'::regclass,
	'public.occurrence'::regclass,
	'public.occurrence_history'::regclass,
	'public.origin'::regclass,
	'public.person'::regclass,
	'public.entity'::regclass,
	'public.entity_history'::regclass,
	'public.release'::regclass,
	'public.revision'::regclass,
	'public.revision_history'::regclass,
	'public.skipped_content'::regclass
	);
	$$;
	diff --git a/sql/swh-schema.sql b/sql/swh-schema.sql
	index e15e0498..70531351 100644
	--- a/sql/swh-schema.sql
	+++ b/sql/swh-schema.sql
	@@ -1,418 +1,418 @@
	---
	--- Software Heritage Data Model
	---

	-- drop schema if exists swh cascade;
	-- create schema swh;
	-- set search_path to swh;

	create table dbversion
	(
	version int primary key,
	release timestamptz,
	description text
	);

	insert into dbversion(version, release, description)
	- values(46, now(), 'Work In Progress');
	+ values(47, now(), 'Work In Progress');

	-- a SHA1 checksum (not necessarily originating from Git)
	create domain sha1 as bytea check (length(value) = 20);

	-- a Git object ID, i.e., a SHA1 checksum
	create domain sha1_git as bytea check (length(value) = 20);

	-- a SHA256 checksum
	create domain sha256 as bytea check (length(value) = 32);

	-- UNIX path (absolute, relative, individual path component, etc.)
	create domain unix_path as bytea;

	-- a set of UNIX-like access permissions, as manipulated by, e.g., chmod
	create domain file_perms as int;

	create type content_status as enum ('absent', 'visible', 'hidden');

	-- Checksums about actual file content. Note that the content itself is not
	-- stored in the DB, but on external (key-value) storage. A single checksum is
	-- used as key there, but the other can be used to verify that we do not inject
	-- content collisions not knowingly.
	create table content
	(
	sha1 sha1 primary key,
	sha1_git sha1_git not null,
	sha256 sha256 not null,
	length bigint not null,
	ctime timestamptz not null default now(),
	-- creation time, i.e. time of (first) injection into the storage
	status content_status not null default 'visible',
	object_id bigserial
	);

	create unique index on content(sha1_git);
	create unique index on content(sha256);
	create index on content(ctime); -- TODO use a BRIN index here (postgres >= 9.5)

	-- Entities constitute a typed hierarchy of organization, hosting
	-- facilities, groups, people and software projects.
	--
	-- Examples of entities: Software Heritage, Debian, GNU, GitHub,
	-- Apache, The Linux Foundation, the Debian Python Modules Team, the
	-- torvalds GitHub user, the torvalds/linux GitHub project.
	--
	-- The data model is hierarchical (via the parent attribute) and might
	-- store sub-branches of existing entities. The key feature of an
	-- entity is might be listed (if it is available in listable_entity)
	-- to retrieve information about its content, i.e: sub-entities,
	-- projects, origins.

	-- Types of entities.
	--
	-- - organization: a root entity, usually backed by a non-profit, a
	-- company, or another kind of "association". (examples: Software
	-- Heritage, Debian, GNU, GitHub)
	--
	-- - group_of_entities: used for hierarchies, doesn't need to have a
	-- concrete existence. (examples: GNU hosting facilities, Debian
	-- hosting facilities, GitHub users, ...)
	--
	-- - hosting: a hosting facility, can usually be listed to generate
	-- other data. (examples: GitHub git hosting, alioth.debian.org,
	-- snapshot.debian.org)
	--
	-- - group_of_persons: an entity representing a group of
	-- persons. (examples: a GitHub organization, a Debian team)
	--
	-- - person: an entity representing a person. (examples:
	-- a GitHub user, a Debian developer)
	--
	-- - project: an entity representing a software project. (examples: a
	-- GitHub project, Apache httpd, a Debian source package, ...)
	create type entity_type as enum (
	'organization',
	'group_of_entities',
	'hosting',
	'group_of_persons',
	'person',
	'project'
	);

	-- The history of entities. Allows us to keep historical metadata
	-- about entities. The temporal invariant is the uuid. Root
	-- organization uuids are manually generated (and available in
	-- swh-data.sql).
	--
	-- For generated entities (generated = true), we can provide
	-- generation_metadata to allow listers to retrieve the uuids of previous
	-- iterations of the entity.
	--
	-- Inactive entities that have been active in the past (active =
	-- false) should register the timestamp at which we saw them
	-- deactivate, in a new entry of entity_history.
	create table entity_history
	(
	id bigserial primary key,
	uuid uuid,
	parent uuid, -- should reference entity_history(uuid)
	name text not null,
	type entity_type not null,
	description text,
	homepage text,
	active boolean not null, -- whether the entity was seen on the last listing
	generated boolean not null, -- whether this entity has been generated by a lister
	lister uuid, -- should reference entity_history(uuid)
	lister_metadata jsonb, -- lister-specific metadata
	doap jsonb, -- metadata in doap format
	validity timestamptz[] -- timestamps at which we have seen this entity
	);

	create index on entity_history(uuid);
	create index on entity_history(name);

	-- The entity table provides a view of the latest information on a
	-- given entity. It is updated via a trigger on entity_history.
	create table entity
	(
	uuid uuid primary key,
	parent uuid references entity(uuid) deferrable initially deferred,
	name text not null,
	type entity_type not null,
	description text,
	homepage text,
	active boolean not null, -- whether the entity was seen on the last listing
	generated boolean not null, -- whether this entity has been generated by a lister
	lister uuid, -- the entity that created this entity.
	-- References listable_entity(uuid) later on.
	lister_metadata jsonb, -- lister-specific metadata
	doap jsonb, -- metadata in doap format
	last_seen timestamptz, -- last listing time or disappearance time for active=false
	last_id bigint references entity_history(id) -- last listing id
	);

	create index on entity(name);

	-- Register the equivalence between two entities. Allows sideways
	-- navigation in the entity table
	create table entity_equivalence
	(
	entity1 uuid references entity(uuid),
	entity2 uuid references entity(uuid),
	primary key (entity1, entity2),
	constraint order_entities check (entity1 < entity2)
	);

	-- Register a lister for a specific entity.
	create table listable_entity
	(
	uuid uuid references entity(uuid) primary key,
	enabled boolean not null default true, -- do we list this entity automatically?
	list_engine text, -- crawler to be used to list entity's content
	list_url text, -- root URL to start the listing
	list_params json, -- org-specific listing parameter
	latest_list timestamptz -- last time the entity's content has been listed
	);

	-- Add the circular foreign key on entity(lister) -> listable_entity(uuid)
	alter table entity add foreign key (lister) references listable_entity(uuid);

	-- Log of all entity listings (i.e., entity crawling) that have been
	-- done in the past, or are still ongoing.
	create table list_history
	(
	id bigserial primary key,
	entity uuid references listable_entity(uuid),
	date timestamptz not null,
	status boolean, -- true if and only if the listing has been successful
	result json, -- more detailed return value, depending on status
	stdout text,
	stderr text,
	duration interval -- fetch duration of NULL if still ongoing
	);


	-- An origin is a place, identified by an URL, where software can be found. We
	-- support different kinds of origins, e.g., git and other VCS repositories,
	-- web pages that list tarballs URLs (e.g., http://www.kernel.org), indirect
	-- tarball URLs (e.g., http://www.example.org/latest.tar.gz), etc. The key
	-- feature of an origin is that it can be fetched (wget, git clone, svn
	-- checkout, etc.) to retrieve all the contained software.
	create table origin
	(
	id bigserial primary key,
	type text, -- TODO use an enum here (?)
	url text not null,
	lister uuid references listable_entity(uuid),
	project uuid references entity(uuid)
	);

	create index on origin(type, url);

	-- Content we have seen but skipped for some reason. This table is
	-- separate from the content table as we might not have the sha1
	-- checksum of that data (for instance when we inject git
	-- repositories, objects that are too big will be skipped here, and we
	-- will only know their sha1_git). 'reason' contains the reason the
	-- content was skipped. origin is a nullable column allowing to find
	-- out which origin contains that skipped content.
	create table skipped_content
	(
	sha1 sha1,
	sha1_git sha1_git,
	sha256 sha256,
	length bigint not null,
	ctime timestamptz not null default now(),
	status content_status not null default 'absent',
	reason text not null,
	origin bigint references origin(id),
	object_id bigserial,
	unique (sha1, sha1_git, sha256)
	);

	-- those indexes support multiple NULL values.
	create unique index on skipped_content(sha1);
	create unique index on skipped_content(sha1_git);
	create unique index on skipped_content(sha256);


	-- Log of all origin fetches (i.e., origin crawling) that have been done in the
	-- past, or are still ongoing. Similar to list_history, but for origins.
	create table fetch_history
	(
	id bigserial primary key,
	origin bigint references origin(id),
	date timestamptz not null,
	status boolean, -- true if and only if the fetch has been successful
	result json, -- more detailed returned values, times, etc...
	stdout text,
	stderr text, -- null when status is true, filled otherwise
	duration interval -- fetch duration of NULL if still ongoing
	);


	-- A file-system directory. A directory is a list of directory entries (see
	-- tables: directory_entry_{dir,file}).
	--
	-- To list the contents of a directory:
	-- 1. list the contained directory_entry_dir using array dir_entries
	-- 2. list the contained directory_entry_file using array file_entries
	-- 3. list the contained directory_entry_rev using array rev_entries
	-- 4. UNION
	--
	-- Synonyms/mappings:
	-- * git: tree
	create table directory
	(
	id sha1_git primary key,
	dir_entries bigint[], -- sub-directories, reference directory_entry_dir
	file_entries bigint[], -- contained files, reference directory_entry_file
	rev_entries bigint[], -- mounted revisions, reference directory_entry_rev
	object_id bigserial -- short object identifier
	);

	create index on directory using gin (dir_entries);
	create index on directory using gin (file_entries);
	create index on directory using gin (rev_entries);

	-- A directory entry pointing to a sub-directory.
	create table directory_entry_dir
	(
	id bigserial primary key,
	target sha1_git, -- id of target directory
	name unix_path, -- path name, relative to containing dir
	perms file_perms -- unix-like permissions
	);

	create unique index on directory_entry_dir(target, name, perms);

	-- A directory entry pointing to a file.
	create table directory_entry_file
	(
	id bigserial primary key,
	target sha1_git, -- id of target file
	name unix_path, -- path name, relative to containing dir
	perms file_perms -- unix-like permissions
	);

	create unique index on directory_entry_file(target, name, perms);

	-- A directory entry pointing to a revision.
	create table directory_entry_rev
	(
	id bigserial primary key,
	target sha1_git, -- id of target revision
	name unix_path, -- path name, relative to containing dir
	perms file_perms -- unix-like permissions
	);

	create unique index on directory_entry_rev(target, name, perms);

	create table person
	(
	id bigserial primary key,
	name bytea not null default '',
	email bytea not null default ''
	);

	create unique index on person(name, email);

	create type revision_type as enum ('git', 'tar', 'dsc');

	-- the data object types stored in our data model
	create type object_type as enum ('content', 'directory', 'revision', 'release');

	-- A snapshot of a software project at a specific point in time.
	--
	-- Synonyms/mappings:
	-- * git / subversion / etc: commit
	-- * tarball: a specific tarball
	--
	-- Revisions are organized as DAGs. Each revision points to 0, 1, or more (in
	-- case of merges) parent revisions. Each revision points to a directory, i.e.,
	-- a file-system tree containing files and directories.
	create table revision
	(
	id sha1_git primary key,
	date timestamptz,
	date_offset smallint,
	committer_date timestamptz,
	committer_date_offset smallint,
	type revision_type not null,
	directory sha1_git, -- file-system tree
	message bytea,
	author bigint references person(id),
	committer bigint references person(id),
	metadata jsonb, -- extra metadata (tarball checksums, extra commit information, etc...)
	synthetic boolean not null default false, -- true if synthetic (cf. swh-loader-tar)
	object_id bigserial
	);

	create index on revision(directory);

	-- either this table or the sha1_git[] column on the revision table
	create table revision_history
	(
	id sha1_git references revision(id),
	parent_id sha1_git,
	parent_rank int not null default 0,
	-- parent position in merge commits, 0-based
	primary key (id, parent_rank)
	);

	create index on revision_history(parent_id);

	-- The content of software origins is indexed starting from top-level pointers
	-- called "branches". Every time we fetch some origin we store in this table
	-- where the branches pointed to at fetch time.
	--
	-- Synonyms/mappings:
	-- * git: ref (in the "git update-ref" sense)
	create table occurrence_history
	(
	origin bigint references origin(id),
	- branch text, -- e.g., "master" (for VCS), or "sid" (for Debian)
	+ branch bytea, -- e.g., b"master" (for VCS), or b"sid" (for Debian)
	target sha1_git, -- ref target, e.g., commit id
	target_type object_type, -- ref target type
	authority uuid references entity(uuid),
	-- who is claiming to have seen the occurrence.
	-- Note: SWH is such an authority, and has an entry in
	-- the organization table.
	validity tstzrange, -- The time validity of this table entry. If the upper
	-- bound is missing, the entry is still valid.
	object_id bigserial, -- short object identifier
	primary key (object_id)
	);

	create index on occurrence_history(target, target_type);
	create index on occurrence_history(origin, branch);

	-- Materialized view of occurrence_history, storing the current value of each
	-- branch, as last seen by SWH.
	create table occurrence
	(
	origin bigint references origin(id),
	- branch text,
	+ branch bytea,
	target sha1_git,
	target_type object_type, -- ref target type
	primary key(origin, branch)
	);

	-- A "memorable" point in the development history of a project.
	--
	-- Synonyms/mappings:
	-- * git: tag (of the annotated kind, otherwise they are just references)
	-- * tarball: the release version number
	create table release
	(
	id sha1_git primary key,
	target sha1_git,
	target_type object_type,
	date timestamptz,
	date_offset smallint,
	- name text,
	+ name bytea,
	comment bytea,
	author bigint references person(id),
	synthetic boolean not null default false, -- true if synthetic (cf. swh-loader-tar)
	object_id bigserial
	);

	create index on release(target, target_type);
	diff --git a/sql/upgrades/047.sql b/sql/upgrades/047.sql
	new file mode 100644
	index 00000000..62d789e3
	--- /dev/null
	+++ b/sql/upgrades/047.sql
	@@ -0,0 +1,89 @@
	+-- SWH DB schema upgrade
	+-- from_version: 46
	+-- to_version: 47
	+-- description: Change type from text to bytea for release.name, occurrence.branch and occurrence_history.branch
	+
	+-- Update types
	+ALTER TABLE release
	+ALTER COLUMN name
	+SET DATA TYPE bytea
	+USING convert_to(name, 'UTF-8') :: bytea;
	+
	+ALTER TABLE occurrence
	+ALTER COLUMN branch
	+SET DATA TYPE bytea
	+USING convert_to(branch, 'UTF-8') :: bytea;
	+
	+ALTER TABLE occurrence_history
	+ALTER COLUMN branch
	+SET DATA TYPE bytea
	+USING convert_to(branch, 'UTF-8') :: bytea;
	+
	+ALTER TYPE release_entry
	+ALTER ATTRIBUTE name
	+SET DATA TYPE bytea
	+CASCADE;
	+
	+create or replace function swh_occurrence_get_by(
	+ origin_id bigint,
	+ branch_name bytea default NULL,
	+ validity timestamptz default NULL)
	+ returns setof occurrence_history
	+ language plpgsql
	+as $$
	+declare
	+ filters text[] := array[] :: text[]; -- AND-clauses used to filter content
	+ q text;
	+begin
	+ if origin_id is not null then
	+ filters := filters \|\| format('origin = %L', origin_id);
	+ end if;
	+ if branch_name is not null then
	+ filters := filters \|\| format('branch = %L', branch_name);
	+ end if;
	+ if validity is not null then
	+ filters := filters \|\| format('validity @> %L::timestamptz', validity);
	+ end if;
	+
	+ if cardinality(filters) = 0 then
	+ raise exception 'At least one filter amongst (origin_id, branch_name, validity) is needed';
	+ else
	+ q = format('select * ' \|\|
	+ 'from occurrence_history ' \|\|
	+ 'where %s ' \|\|
	+ 'order by validity desc',
	+ array_to_string(filters, ' and '));
	+ return query execute q;
	+ end if;
	+end
	+$$;
	+
	+
	+create or replace function swh_revision_get_by(
	+ origin_id bigint,
	+ branch_name bytea default NULL,
	+ validity timestamptz default NULL)
	+ returns setof revision_entry
	+ language sql
	+ stable
	+as $$
	+ select r.id, r.date, r.date_offset,
	+ r.committer_date, r.committer_date_offset,
	+ r.type, r.directory, r.message,
	+ a.name, a.email, c.name, c.email, r.metadata, r.synthetic,
	+ array(select rh.parent_id::bytea
	+ from revision_history rh
	+ where rh.id = r.id
	+ order by rh.parent_rank
	+ ) as parents
	+ from swh_occurrence_get_by(origin_id, branch_name, validity) as occ
	+ inner join revision r on occ.target = r.id
	+ left join person a on a.id = r.author
	+ left join person c on c.id = r.committer;
	+$$;
	+
	+
	+ALTER TYPE content_occurrence
	+ALTER ATTRIBUTE branch
	+SET DATA TYPE bytea
	+CASCADE;
	diff --git a/swh.storage.egg-info/PKG-INFO b/swh.storage.egg-info/PKG-INFO
	index a4f32d45..dbc5700a 100644
	--- a/swh.storage.egg-info/PKG-INFO
	+++ b/swh.storage.egg-info/PKG-INFO
	@@ -1,10 +1,10 @@
	Metadata-Version: 1.0
	Name: swh.storage
	-Version: 0.0.30
	+Version: 0.0.31
	Summary: Software Heritage storage manager
	Home-page: https://forge.softwareheritage.org/diffusion/DSTO/
	Author: Software Heritage developers
	Author-email: swh-devel@inria.fr
	License: UNKNOWN
	Description: UNKNOWN
	Platform: UNKNOWN
	diff --git a/swh.storage.egg-info/SOURCES.txt b/swh.storage.egg-info/SOURCES.txt
	index 57693cda..85c7563c 100644
	--- a/swh.storage.egg-info/SOURCES.txt
	+++ b/swh.storage.egg-info/SOURCES.txt
	@@ -1,80 +1,81 @@
	.gitignore
	AUTHORS
	LICENSE
	MANIFEST.in
	Makefile
	Makefile.local
	README.db_testing
	README.dev
	requirements.txt
	setup.py
	version.txt
	bin/swh-objstorage-add-dir
	bin/swh-objstorage-fsck
	bin/swh-storage-add-dir
	debian/changelog
	debian/compat
	debian/control
	debian/copyright
	debian/rules
	debian/source/format
	doc/archiver-blueprint.md
	sql/.gitignore
	sql/Makefile
	sql/TODO
	sql/clusters.dot
	sql/swh-data.sql
	sql/swh-func.sql
	sql/swh-init.sql
	sql/swh-schema.sql
	sql/bin/db-upgrade
	sql/bin/dot_add_content
	sql/upgrades/015.sql
	sql/upgrades/016.sql
	sql/upgrades/017.sql
	sql/upgrades/018.sql
	sql/upgrades/019.sql
	sql/upgrades/020.sql
	sql/upgrades/021.sql
	sql/upgrades/022.sql
	sql/upgrades/023.sql
	sql/upgrades/024.sql
	sql/upgrades/025.sql
	sql/upgrades/026.sql
	sql/upgrades/027.sql
	sql/upgrades/028.sql
	sql/upgrades/029.sql
	sql/upgrades/030.sql
	sql/upgrades/032.sql
	sql/upgrades/033.sql
	sql/upgrades/034.sql
	sql/upgrades/035.sql
	sql/upgrades/036.sql
	sql/upgrades/037.sql
	sql/upgrades/038.sql
	sql/upgrades/039.sql
	sql/upgrades/040.sql
	sql/upgrades/041.sql
	sql/upgrades/042.sql
	sql/upgrades/043.sql
	sql/upgrades/044.sql
	sql/upgrades/045.sql
	sql/upgrades/046.sql
	+sql/upgrades/047.sql
	swh.storage.egg-info/PKG-INFO
	swh.storage.egg-info/SOURCES.txt
	swh.storage.egg-info/dependency_links.txt
	swh.storage.egg-info/requires.txt
	swh.storage.egg-info/top_level.txt
	swh/storage/__init__.py
	swh/storage/converters.py
	swh/storage/db.py
	swh/storage/exc.py
	swh/storage/objstorage.py
	swh/storage/storage.py
	swh/storage/api/__init__.py
	swh/storage/api/client.py
	swh/storage/api/server.py
	swh/storage/tests/test_api_client.py
	swh/storage/tests/test_db.py
	swh/storage/tests/test_objstorage.py
	swh/storage/tests/test_storage.py
	\ No newline at end of file
	diff --git a/swh/storage/storage.py b/swh/storage/storage.py
	index 2bf13401..30dc48fa 100644
	--- a/swh/storage/storage.py
	+++ b/swh/storage/storage.py
	@@ -1,1041 +1,1042 @@
	# Copyright (C) 2015 The Software Heritage developers
	# See the AUTHORS file at the top-level directory of this distribution
	# License: GNU General Public License version 3, or any later version
	# See top-level LICENSE file for more information


	from collections import defaultdict
	import datetime
	import functools
	import itertools
	import dateutil.parser
	import psycopg2
	from psycopg2.extras import DateTimeTZRange

	from . import converters
	from .db import Db
	from .objstorage import ObjStorage
	from .exc import ObjNotFoundError, StorageDBError

	from swh.core.hashutil import ALGORITHMS

	# Max block size of contents to return
	BULK_BLOCK_CONTENT_LEN_MAX = 10000


	def db_transaction(meth):
	"""decorator to execute Storage methods within DB transactions

	The decorated method must accept a `cur` keyword argument
	"""
	@functools.wraps(meth)
	def _meth(self, args, *kwargs):
	with self.db.transaction() as cur:
	return meth(self, args, cur=cur, *kwargs)
	return _meth


	def db_transaction_generator(meth):
	"""decorator to execute Storage methods within DB transactions, while
	returning a generator

	The decorated method must accept a `cur` keyword argument

	"""
	@functools.wraps(meth)
	def _meth(self, args, *kwargs):
	with self.db.transaction() as cur:
	yield from meth(self, args, cur=cur, *kwargs)
	return _meth


	class Storage():
	"""SWH storage proxy, encompassing DB and object storage

	"""

	def __init__(self, db_conn, obj_root):
	"""
	Args:
	db_conn: either a libpq connection string, or a psycopg2 connection
	obj_root: path to the root of the object storage

	"""
	try:
	if isinstance(db_conn, psycopg2.extensions.connection):
	self.db = Db(db_conn)
	else:
	self.db = Db.connect(db_conn)
	except psycopg2.OperationalError as e:
	raise StorageDBError(e)

	self.objstorage = ObjStorage(obj_root)

	def content_add(self, content):
	"""Add content blobs to the storage

	Note: in case of DB errors, objects might have already been added to
	the object storage and will not be removed. Since addition to the
	object storage is idempotent, that should not be a problem.

	Args:
	content: iterable of dictionaries representing individual pieces of
	content to add. Each dictionary has the following keys:
	- data (bytes): the actual content
	- length (int): content length (default: -1)
	- one key for each checksum algorithm in
	swh.core.hashutil.ALGORITHMS, mapped to the corresponding
	checksum
	- status (str): one of visible, hidden, absent
	- reason (str): if status = absent, the reason why
	- origin (int): if status = absent, the origin we saw the
	content in

	"""
	db = self.db

	content_by_status = defaultdict(list)
	for d in content:
	if 'status' not in d:
	d['status'] = 'visible'
	if 'length' not in d:
	d['length'] = -1
	content_by_status[d['status']].append(d)

	content_with_data = content_by_status['visible']
	content_without_data = content_by_status['absent']

	missing_content = set(self.content_missing(content_with_data))
	missing_skipped = set(
	sha1_git for sha1, sha1_git, sha256
	in self.skipped_content_missing(content_without_data))

	with db.transaction() as cur:
	if missing_content:
	# create temporary table for metadata injection
	db.mktemp('content', cur)

	def add_to_objstorage(cont):
	self.objstorage.add_bytes(cont['data'],
	obj_id=cont['sha1'])

	content_filtered = (cont for cont in content_with_data
	if cont['sha1'] in missing_content)

	db.copy_to(content_filtered, 'tmp_content',
	['sha1', 'sha1_git', 'sha256', 'length', 'status'],
	cur, item_cb=add_to_objstorage)

	# move metadata in place
	db.content_add_from_temp(cur)

	if missing_skipped:
	missing_filtered = (cont for cont in content_without_data
	if cont['sha1_git'] in missing_skipped)
	db.mktemp('skipped_content', cur)
	db.copy_to(missing_filtered, 'tmp_skipped_content',
	['sha1', 'sha1_git', 'sha256', 'length',
	'reason', 'status', 'origin'], cur)

	# move metadata in place
	db.skipped_content_add_from_temp(cur)

	def content_get(self, content):
	"""Retrieve in bulk contents and their data.

	Args:
	content: iterables of sha1

	Returns:
	Generates streams of contents as dict with their raw data:
	- sha1: sha1's content
	- data: bytes data of the content

	Raises:
	ValueError in case of too much contents are required.
	cf. BULK_BLOCK_CONTENT_LEN_MAX

	"""
	# FIXME: Improve on server module to slice the result
	if len(content) > BULK_BLOCK_CONTENT_LEN_MAX:
	raise ValueError(
	"Send at maximum %s contents." % BULK_BLOCK_CONTENT_LEN_MAX)

	for obj_id in content:
	try:
	data = self.objstorage.get_bytes(obj_id)
	except ObjNotFoundError:
	yield None
	continue

	yield {'sha1': obj_id, 'data': data}

	@db_transaction_generator
	def content_missing(self, content, key_hash='sha1', cur=None):
	"""List content missing from storage

	Args:
	content: iterable of dictionaries containing one key for each
	checksum algorithm in swh.core.hashutil.ALGORITHMS, mapped to
	the corresponding checksum, and a length key mapped to the
	content length.
	key_hash: the name of the hash used as key (default: 'sha1')

	Returns:
	an iterable of `key_hash`es missing from the storage

	Raises:
	TODO: an exception when we get a hash collision.

	"""
	db = self.db

	keys = ['sha1', 'sha1_git', 'sha256']

	if key_hash not in keys:
	raise ValueError("key_hash should be one of %s" % keys)

	key_hash_idx = keys.index(key_hash)

	# Create temporary table for metadata injection
	db.mktemp('content', cur)

	db.copy_to(content, 'tmp_content', keys + ['length'], cur)

	for obj in db.content_missing_from_temp(cur):
	yield obj[key_hash_idx]

	@db_transaction_generator
	def skipped_content_missing(self, content, cur=None):
	"""List skipped_content missing from storage

	Args:
	content: iterable of dictionaries containing the data for each
	checksum algorithm.

	Returns:
	an iterable of signatures missing from the storage
	"""
	keys = ['sha1', 'sha1_git', 'sha256']

	db = self.db

	db.mktemp('skipped_content', cur)
	db.copy_to(content, 'tmp_skipped_content',
	keys + ['length', 'reason'], cur)

	yield from db.skipped_content_missing_from_temp(cur)

	@db_transaction
	def content_find(self, content, cur=None):
	"""Find a content hash in db.

	Args:
	content: a dictionary representing one content hash, mapping
	checksum algorithm names (see swh.core.hashutil.ALGORITHMS) to
	checksum values

	Returns:
	a triplet (sha1, sha1_git, sha256) if the content exist
	or None otherwise.

	Raises:
	ValueError in case the key of the dictionary is not sha1, sha1_git
	nor sha256.

	"""
	db = self.db

	if not set(content).intersection(ALGORITHMS):
	raise ValueError('content keys must contain at least one of: '
	'sha1, sha1_git, sha256')

	c = db.content_find(sha1=content.get('sha1'),
	sha1_git=content.get('sha1_git'),
	sha256=content.get('sha256'),
	cur=cur)
	if c:
	keys = ['sha1', 'sha1_git', 'sha256', 'length', 'ctime', 'status']
	return dict(zip(keys, c))
	return None

	@db_transaction
	def content_find_occurrence(self, content, cur=None):
	"""Find the content's occurrence.

	Args:
	content: a dictionary entry representing one content hash.
	The dictionary key is one of swh.core.hashutil.ALGORITHMS.
	The value mapped to the corresponding checksum.

	Returns:
	The occurrence of the content.

	Raises:
	ValueError in case the key of the dictionary is not sha1, sha1_git
	nor sha256.

	"""
	db = self.db

	c = self.content_find(content)

	if not c:
	return None

	sha1 = c['sha1']

	found_occ = db.content_find_occurrence(sha1, cur=cur)
	if found_occ:
	keys = ['origin_type', 'origin_url', 'branch', 'target',
	'target_type', 'path']
	return dict(zip(keys, found_occ))
	return None

	def directory_add(self, directories):
	"""Add directories to the storage

	Args:
	directories: iterable of dictionaries representing the individual
	directories to add. Each dict has the following keys:
	- id (sha1_git): the id of the directory to add
	- entries (list): list of dicts for each entry in the
	directory. Each dict has the following keys:
	- name (bytes)
	- type (one of 'file', 'dir', 'rev'):
	type of the directory entry (file, directory, revision)
	- target (sha1_git): id of the object pointed at by the
	directory entry
	- perms (int): entry permissions
	"""
	dirs = set()
	dir_entries = {
	'file': defaultdict(list),
	'dir': defaultdict(list),
	'rev': defaultdict(list),
	}

	for cur_dir in directories:
	dir_id = cur_dir['id']
	dirs.add(dir_id)
	for src_entry in cur_dir['entries']:
	entry = src_entry.copy()
	entry['dir_id'] = dir_id
	dir_entries[entry['type']][dir_id].append(entry)

	dirs_missing = set(self.directory_missing(dirs))
	if not dirs_missing:
	return

	db = self.db
	with db.transaction() as cur:
	# Copy directory ids
	dirs_missing_dict = ({'id': dir} for dir in dirs_missing)
	db.mktemp('directory', cur)
	db.copy_to(dirs_missing_dict, 'tmp_directory', ['id'], cur)

	# Copy entries
	for entry_type, entry_list in dir_entries.items():
	entries = itertools.chain.from_iterable(
	entries_for_dir
	for dir_id, entries_for_dir
	in entry_list.items()
	if dir_id in dirs_missing)

	db.mktemp_dir_entry(entry_type)

	db.copy_to(
	entries,
	'tmp_directory_entry_%s' % entry_type,
	['target', 'name', 'perms', 'dir_id'],
	cur,
	)

	# Do the final copy
	db.directory_add_from_temp(cur)

	@db_transaction_generator
	def directory_missing(self, directories, cur):
	"""List directories missing from storage

	Args: an iterable of directory ids
	Returns: a list of missing directory ids
	"""
	db = self.db

	# Create temporary table for metadata injection
	db.mktemp('directory', cur)

	directories_dicts = ({'id': dir} for dir in directories)

	db.copy_to(directories_dicts, 'tmp_directory', ['id'], cur)

	for obj in db.directory_missing_from_temp(cur):
	yield obj[0]

	@db_transaction_generator
	def directory_get(self,
	directories,
	cur=None):
	"""Get information on directories.

	Args:
	- directories: an iterable of directory ids

	Returns:
	List of directories as dict with keys and associated values.

	"""
	db = self.db
	keys = ('id', 'dir_entries', 'file_entries', 'rev_entries')

	db.mktemp('directory', cur)
	db.copy_to(({'id': dir_id} for dir_id in directories),
	'tmp_directory', ['id'], cur)

	dirs = db.directory_get_from_temp(cur)
	for line in dirs:
	yield dict(zip(keys, line))

	@db_transaction_generator
	def directory_ls(self, directory, recursive=False, cur=None):
	"""Get entries for one directory.

	Args:
	- directory: the directory to list entries from.
	- recursive: if flag on, this list recursively from this directory.

	Returns:
	List of entries for such directory.

	"""
	db = self.db
	keys = ['dir_id', 'type', 'target', 'name', 'perms', 'status',
	'sha1', 'sha1_git', 'sha256']

	if recursive:
	res_gen = db.directory_walk(directory)
	else:
	res_gen = db.directory_walk_one(directory)

	for line in res_gen:
	yield dict(zip(keys, line))

	@db_transaction
	def directory_entry_get_by_path(self, directory, paths, cur=None):
	"""Get the directory entry (either file or dir) from directory with
	path.

	Args:
	- directory: sha1 of the top level directory
	- paths: path to lookup from the top level directory. From left
	(top) to right (bottom).

	Returns:
	The corresponding directory entry if found, None otherwise.

	"""
	db = self.db
	keys = ('dir_id', 'type', 'target', 'name', 'perms', 'status',
	'sha1', 'sha1_git', 'sha256')

	res = db.directory_entry_get_by_path(directory, paths, cur)
	if res:
	return dict(zip(keys, res))

	def revision_add(self, revisions):
	"""Add revisions to the storage

	Args:
	revisions: iterable of dictionaries representing the individual
	revisions to add. Each dict has the following keys:
	- id (sha1_git): id of the revision to add
	- date (datetime.DateTime): date the revision was written
	- date_offset (int): offset from UTC in minutes the revision
	was written
	- committer_date (datetime.DateTime): date the revision got
	added to the origin
	- committer_date_offset (int): offset from UTC in minutes the
	revision was added to the origin
	- type (one of 'git', 'tar'): type of the revision added
	- directory (sha1_git): the directory the revision points at
	- message (bytes): the message associated with the revision
	- author_name (bytes): the name of the revision author
	- author_email (bytes): the email of the revision author
	- committer_name (bytes): the name of the revision committer
	- committer_email (bytes): the email of the revision committer
	- metadata (jsonb): extra information as dictionary
	- synthetic (bool): revision's nature (tarball, directory
	creates synthetic revision)
	- parents (list of sha1_git): the parents of this revision
	"""
	db = self.db

	revisions_missing = set(self.revision_missing(
	set(revision['id'] for revision in revisions)))

	if not revisions_missing:
	return

	with db.transaction() as cur:
	db.mktemp_revision(cur)

	revisions_filtered = (
	converters.revision_to_db(revision) for revision in revisions
	if revision['id'] in revisions_missing)

	parents_filtered = []

	db.copy_to(
	revisions_filtered, 'tmp_revision',
	['id', 'date', 'date_offset', 'committer_date',
	'committer_date_offset', 'type', 'directory', 'message',
	'author_name', 'author_email', 'committer_name',
	'committer_email', 'metadata', 'synthetic'],
	cur,
	lambda rev: parents_filtered.extend(rev['parents']))

	db.revision_add_from_temp(cur)

	db.copy_to(parents_filtered, 'revision_history',
	['id', 'parent_id', 'parent_rank'], cur)

	@db_transaction_generator
	def revision_missing(self, revisions, cur):
	"""List revisions missing from storage

	Args: an iterable of revision ids
	Returns: a list of missing revision ids
	"""
	db = self.db

	# Create temporary table for metadata injection
	db.mktemp('revision', cur)

	revisions_dicts = ({'id': dir, 'type': 'git'} for dir in revisions)

	db.copy_to(revisions_dicts, 'tmp_revision', ['id', 'type'], cur)

	for obj in db.revision_missing_from_temp(cur):
	yield obj[0]

	@db_transaction_generator
	def revision_get(self, revisions, cur):
	"""Get all revisions from storage
	Args: an iterable of revision ids
	Returns: an iterable of revisions as dictionaries
	(or None if the revision doesn't exist)
	"""

	keys = ('id', 'date', 'date_offset', 'committer_date',
	'committer_date_offset', 'type', 'directory',
	'message', 'author_name', 'author_email',
	'committer_name', 'committer_email', 'metadata',
	'synthetic', 'parents')

	db = self.db

	# Create temporary table for metadata injection
	db.mktemp('revision', cur)

	revisions_dicts = ({'id': rev, 'type': 'git'} for rev in revisions)

	db.copy_to(revisions_dicts, 'tmp_revision', ['id', 'type'], cur)

	for line in self.db.revision_get_from_temp(cur):
	data = converters.db_to_revision(dict(zip(keys, line)))
	if not data['type']:
	yield None
	continue
	yield data

	@db_transaction_generator
	def revision_log(self, revisions, limit=None, cur=None):
	"""Fetch revision entry from the given root revisions.

	Args:
	- revisions: array of root revision to lookup
	- limit: limitation on the output result. Default to null.

	Yields:
	List of revision log from such revisions root.

	"""
	db = self.db

	keys = ['id', 'date', 'date_offset', 'committer_date',
	'committer_date_offset', 'type', 'directory', 'message',
	'author_name', 'author_email', 'committer_name',
	'committer_email', 'metadata', 'synthetic', 'parents']

	for line in db.revision_log(revisions, limit, cur):
	data = converters.db_to_revision(dict(zip(keys, line)))
	if not data['type']:
	yield None
	continue
	yield data

	@db_transaction_generator
	def revision_log_by(self, origin_id, limit=None, cur=None):
	"""Fetch revision entry from the actual origin_id's latest revision.

	"""
	db = self.db

	keys = ('id', 'date', 'date_offset', 'committer_date',
	'committer_date_offset', 'type', 'directory', 'message',
	'author_name', 'author_email', 'committer_name',
	'committer_email', 'metadata', 'synthetic', 'parents')

	for line in db.revision_log_by(origin_id, limit, cur):
	data = converters.db_to_revision(dict(zip(keys, line)))
	if not data['type']:
	yield None
	continue
	yield data

	def release_add(self, releases):
	"""Add releases to the storage

	Args:
	releases: iterable of dictionaries representing the individual
	releases to add. Each dict has the following keys:
	- id (sha1_git): id of the release to add
	- revision (sha1_git): id of the revision the release points
	to
	- date (datetime.DateTime): the date the release was made
	- date_offset (int): offset from UTC in minutes the release was
	made
	- name (bytes): the name of the release
	- comment (bytes): the comment associated with the release
	- author_name (bytes): the name of the release author
	- author_email (bytes): the email of the release author
	"""
	db = self.db

	release_ids = set(release['id'] for release in releases)
	releases_missing = set(self.release_missing(release_ids))

	if not releases_missing:
	return

	with db.transaction() as cur:
	db.mktemp_release(cur)

	releases_filtered = (
	converters.release_to_db(release) for release in releases
	if release['id'] in releases_missing
	)

	db.copy_to(releases_filtered, 'tmp_release',
	['id', 'target', 'target_type', 'date', 'date_offset',
	'name', 'comment', 'author_name', 'author_email',
	'synthetic'],
	cur)

	db.release_add_from_temp(cur)

	@db_transaction_generator
	def release_missing(self, releases, cur=None):
	"""List releases missing from storage

	Args: an iterable of release ids
	Returns: a list of missing release ids
	"""
	db = self.db

	# Create temporary table for metadata injection
	db.mktemp('release', cur)

	releases_dicts = ({'id': rel} for rel in releases)

	db.copy_to(releases_dicts, 'tmp_release', ['id'], cur)

	for obj in db.release_missing_from_temp(cur):
	yield obj[0]

	@db_transaction_generator
	def release_get(self, releases, cur=None):
	"""Given a list of sha1, return the releases's information

	Args:
	releases: list of sha1s

	Returns:
	Generates the list of releases dict with the following keys:
	- id: origin's id
	- revision: origin's type
	- url: origin's url
	- lister: lister's uuid
	- project: project's uuid (FIXME, retrieve this information)

	Raises:
	ValueError if the keys does not match (url and type) nor id.

	"""
	db = self.db

	keys = ['id', 'target', 'target_type', 'date', 'date_offset', 'name',
	'comment', 'synthetic', 'author_name', 'author_email']

	db.mktemp_release_get(cur)

	releases_dicts = ({'id': rel} for rel in releases)

	db.copy_to(releases_dicts, 'tmp_release_get', ['id'], cur)

	for release in db.release_get_from_temp(cur):
	yield converters.db_to_release(dict(zip(keys, release)))

	@db_transaction
	def occurrence_add(self, occurrences, cur=None):
	"""Add occurrences to the storage

	Args:
	occurrences: iterable of dictionaries representing the individual
	occurrences to add. Each dict has the following keys:
	- origin (int): id of the origin corresponding to the
	occurrence
	- branch (str): the reference name of the occurrence
	- target (sha1_git): the id of the object pointed to by
	the occurrence
	- - target_type (str): the type of object pointed to by the occurrence
	+ - target_type (str): the type of object pointed to by the
	+ occurrence
	- authority (uuid): id of the authority giving the validity
	- validity (datetime.DateTime): the validity date for the given
	occurrence
	"""
	db = self.db

	processed = []
	for occurrence in occurrences:
	validity = occurrence['validity']
	if isinstance(validity, str):
	validity = dateutil.parser.parse(validity)
	if isinstance(validity, datetime.datetime):
	occurrence = occurrence.copy()
	occurrence['validity'] = DateTimeTZRange(lower=validity)

	processed.append(occurrence)

	db.mktemp('occurrence_history', cur)
	db.copy_to(processed, 'tmp_occurrence_history',
	['origin', 'branch', 'target', 'target_type', 'authority',
	'validity'], cur)

	db.occurrence_history_add_from_temp(cur)

	@db_transaction_generator
	def occurrence_get(self, origin_id, cur=None):
	"""Retrieve occurrence information per origin_id.

	Args:
	origin_id: The occurrence's origin.

	Yields:
	List of occurrences matching criterion.

	"""
	db = self.db
	for line in db.occurrence_get(origin_id, cur):
	yield {'origin': line[0],
	'branch': line[1],
	'target': line[2],
	'target_type': line[3],
	'authority': line[4],
	'validity_lower': line[5].lower, # always included
	'validity_upper': line[5].upper} # always excluded

	@db_transaction_generator
	def revision_get_by(self,
	origin_id,
	branch_name=None,
	timestamp=None,
	limit=None,
	cur=None):
	"""Given an origin_id, retrieve occurrences' list per given criterions.

	Args:
	origin_id: The origin to filter on.
	branch_name: optional branch name.
	timestamp:
	limit:

	Yields:
	List of occurrences matching the criterions or None if nothing is
	found.

	"""
	keys = ('id', 'date', 'date_offset', 'committer_date',
	'committer_date_offset', 'type', 'directory',
	'message', 'author_name', 'author_email',
	'committer_name', 'committer_email', 'metadata',
	'synthetic', 'parents')

	for line in self.db.revision_get_by(origin_id,
	branch_name,
	timestamp,
	limit=limit,
	cur=cur):
	data = converters.db_to_revision(dict(zip(keys, line)))
	if not data['type']:
	yield None
	continue
	yield data

	def release_get_by(self, origin_id, limit=None):
	"""Given an origin id, return all the tag objects pointing to heads of
	origin_id.

	Args:
	origin_id: the origin to filter on.
	limit: None by default

	Yields:
	List of releases matching the criterions or None if nothing is
	found.

	"""
	keys = ('id', 'target', 'target_type', 'date', 'date_offset', 'name',
	'comment', 'synthetic', 'author_name', 'author_email')

	for line in self.db.release_get_by(origin_id, limit=limit):
	data = converters.db_to_release(dict(zip(keys, line)))
	yield data

	@db_transaction
	def origin_get(self, origin, cur=None):
	"""Return the origin either identified by its id or its tuple
	(type, url).

	Args:
	origin: dictionary representing the individual
	origin to find.
	This dict has either the keys type and url:
	- type (FIXME: enum TBD): the origin type ('git', 'wget', ...)
	- url (bytes): the url the origin points to
	either the id:
	- id: the origin id

	Returns:
	the origin dict with the keys:
	- id: origin's id
	- type: origin's type
	- url: origin's url
	- lister: lister's uuid
	- project: project's uuid (FIXME, retrieve this information)

	Raises:
	ValueError if the keys does not match (url and type) nor id.

	"""
	db = self.db

	keys = ['id', 'type', 'url', 'lister', 'project']

	origin_id = origin.get('id')
	if origin_id: # check lookup per id first
	ori = db.origin_get(origin_id, cur)
	elif 'type' in origin and 'url' in origin: # or lookup per type, url
	ori = db.origin_get_with(origin['type'], origin['url'], cur)
	else: # unsupported lookup
	raise ValueError('Origin must have either id or (type and url).')

	if ori:
	return dict(zip(keys, ori))
	return None

	@db_transaction
	def _person_add(self, person, cur=None):
	"""Add a person in storage.

	BEWARE: Internal function for now.
	Do not do anything fancy in case a person already exists.
	Please adapt code if more checks are needed.

	Args:
	person dictionary with keys name and email.

	Returns:
	Id of the new person.

	"""
	db = self.db

	return db.person_add(person['name'], person['email'])

	@db_transaction_generator
	def person_get(self, person, cur=None):
	"""Return the persons identified by their ids.

	Args:
	person: array of ids.

	Returns:
	The array of persons corresponding of the ids.

	"""
	db = self.db

	keys = ['id', 'name', 'email']

	for person in db.person_get(person):
	yield dict(zip(keys, person))

	@db_transaction
	def origin_add_one(self, origin, cur=None):
	"""Add origin to the storage

	Args:
	origin: dictionary representing the individual
	origin to add. This dict has the following keys:
	- type (FIXME: enum TBD): the origin type ('git', 'wget', ...)
	- url (bytes): the url the origin points to

	Returns:
	the id of the added origin, or of the identical one that already
	exists.

	"""
	db = self.db

	data = db.origin_get_with(origin['type'], origin['url'], cur)
	if data:
	return data[0]

	return db.origin_add(origin['type'], origin['url'], cur)

	@db_transaction
	def fetch_history_start(self, origin_id, cur=None):
	"""Add an entry for origin origin_id in fetch_history. Returns the id
	of the added fetch_history entry
	"""
	fetch_history = {
	'origin': origin_id,
	'date': datetime.datetime.now(tz=datetime.timezone.utc),
	}

	return self.db.create_fetch_history(fetch_history, cur)

	@db_transaction
	def fetch_history_end(self, fetch_history_id, data, cur=None):
	"""Close the fetch_history entry with id `fetch_history_id`, replacing
	its data with `data`.
	"""
	now = datetime.datetime.now(tz=datetime.timezone.utc)
	fetch_history = self.db.get_fetch_history(fetch_history_id, cur)

	if not fetch_history:
	raise ValueError('No fetch_history with id %d' % fetch_history_id)

	fetch_history['duration'] = now - fetch_history['date']

	fetch_history.update(data)

	self.db.update_fetch_history(fetch_history, cur)

	@db_transaction
	def fetch_history_get(self, fetch_history_id, cur=None):
	"""Get the fetch_history entry with id `fetch_history_id`.
	"""
	return self.db.get_fetch_history(fetch_history_id, cur)

	@db_transaction
	def entity_add(self, entities, cur=None):
	"""Add the given entitites to the database (in entity_history).

	Args:
	- entities: iterable of dictionaries containing the following keys:
	- uuid (uuid): id of the entity
	- parent (uuid): id of the parent entity
	- name (str): name of the entity
	- type (str): type of entity (one of 'organization',
	'group_of_entities', 'hosting', 'group_of_persons',
	'person', 'project')
	- description (str, optional): description of the entity
	- homepage (str): url of the entity's homepage
	- active (bool): whether the entity is active
	- generated (bool): whether the entity was generated
	- lister (uuid): the uuid of the generating entity
	- lister_metadata (dict): lister-specific entity metadata
	- doap (dict): DOAP data for the entity
	- validity (datetime.DateTime array): timestamps at which we
	listed the entity.
	"""
	db = self.db

	cols = list(db.entity_history_cols)
	cols.remove('id')

	db.mktemp_entity_history()
	db.copy_to(entities, 'tmp_entity_history', cols, cur)
	db.entity_history_add_from_temp()

	@db_transaction_generator
	def entity_get_from_lister_metadata(self, entities, cur=None):
	"""Fetch entities from the database, matching with the lister and
	associated metadata.

	Args:
	- entities: iterable of dictionaries containing the following keys:
	- lister (uuid): uuid of the lister
	- lister_metadata (dict): subset of the lister metadata used
	for matching the entity

	Returns:
	A generator of fetched entities with all their attributes. If no
	match was found, the returned entity's uuid is None.
	"""

	db = self.db

	db.mktemp_entity_lister(cur)

	mapped_entities = []
	for i, entity in enumerate(entities):
	mapped_entity = entity.copy()
	mapped_entity['id'] = i
	mapped_entities.append(mapped_entity)

	db.copy_to(mapped_entities, 'tmp_entity_lister',
	['id', 'lister', 'lister_metadata'], cur)

	cur.execute('''select id, %s
	from swh_entity_from_tmp_entity_lister()
	order by id''' %
	','.join(db.entity_cols))

	for id, *entity_vals in cur:
	returned_entity = entities[id].copy()
	fetched_entity = dict(zip(db.entity_cols, entity_vals))
	returned_entity['uuid'] = fetched_entity['uuid']
	if fetched_entity['uuid']:
	returned_entity.update(fetched_entity)
	yield returned_entity

	@db_transaction_generator
	def entity_get(self, uuid, cur=None):
	"""Returns the list of entity per its uuid identifier and also its
	parent hierarchy.

	Args:
	uuid: entity's identifier

	Returns:
	List of entities starting with entity with uuid and the parent
	hierarchy from such entity.

	"""
	db = self.db
	for entity in db.entity_get(uuid, cur):
	yield dict(zip(db.entity_cols, entity))

	@db_transaction
	def stat_counters(self, cur=None):
	"""compute statistics about the number of tuples in various tables

	Returns:
	a dictionary mapping textual labels (e.g., content) to integer
	values (e.g., the number of tuples in table content)

	"""
	return {k: v for (k, v) in self.db.stat_counters()}
	diff --git a/swh/storage/tests/test_storage.py b/swh/storage/tests/test_storage.py
	index c6a7d068..f1193d33 100644
	--- a/swh/storage/tests/test_storage.py
	+++ b/swh/storage/tests/test_storage.py
	@@ -1,1236 +1,1238 @@
	# Copyright (C) 2015 The Software Heritage developers
	# See the AUTHORS file at the top-level directory of this distribution
	# License: GNU General Public License version 3, or any later version
	# See top-level LICENSE file for more information

	import datetime
	import os
	import psycopg2
	import shutil
	import tempfile
	import unittest

	from unittest.mock import patch

	from nose.tools import istest
	from nose.plugins.attrib import attr

	from swh.core.tests.db_testing import DbTestFixture
	from swh.core.hashutil import hex_to_hash
	from swh.storage import Storage


	TEST_DIR = os.path.dirname(os.path.abspath(__file__))
	TEST_DATA_DIR = os.path.join(TEST_DIR, '../../../../swh-storage-testdata')


	@attr('db')
	class AbstractTestStorage(DbTestFixture):
	"""Base class for Storage testing.

	This class is used as-is to test local storage (see TestStorage
	below) and remote storage (see TestRemoteStorage in
	test_remote_storage.py.

	We need to have the two classes inherit from this base class
	separately to avoid nosetests running the tests from the base
	class twice.

	"""
	TEST_DB_DUMP = os.path.join(TEST_DATA_DIR, 'dumps/swh.dump')

	def setUp(self):
	super().setUp()
	self.maxDiff = None
	self.objroot = tempfile.mkdtemp()
	self.storage = Storage(self.conn, self.objroot)

	self.cont = {
	'data': b'42\n',
	'length': 3,
	'sha1': hex_to_hash(
	'34973274ccef6ab4dfaaf86599792fa9c3fe4689'),
	'sha1_git': hex_to_hash(
	'd81cc0710eb6cf9efd5b920a8453e1e07157b6cd'),
	'sha256': hex_to_hash(
	'673650f936cb3b0a2f93ce09d81be107'
	'48b1b203c19e8176b4eefc1964a0cf3a'),
	}

	self.cont2 = {
	'data': b'4242\n',
	'length': 5,
	'sha1': hex_to_hash(
	'61c2b3a30496d329e21af70dd2d7e097046d07b7'),
	'sha1_git': hex_to_hash(
	'36fade77193cb6d2bd826161a0979d64c28ab4fa'),
	'sha256': hex_to_hash(
	'859f0b154fdb2d630f45e1ecae4a8629'
	'15435e663248bb8461d914696fc047cd'),
	}

	self.missing_cont = {
	'data': b'missing\n',
	'length': 8,
	'sha1': hex_to_hash(
	'f9c24e2abb82063a3ba2c44efd2d3c797f28ac90'),
	'sha1_git': hex_to_hash(
	'33e45d56f88993aae6a0198013efa80716fd8919'),
	'sha256': hex_to_hash(
	'6bbd052ab054ef222c1c87be60cd191a'
	'ddedd24cc882d1f5f7f7be61dc61bb3a'),
	}

	self.skipped_cont = {
	'length': 1024 * 1024 * 200,
	'sha1_git': hex_to_hash(
	'33e45d56f88993aae6a0198013efa80716fd8920'),
	'reason': 'Content too long',
	'status': 'absent',
	}

	self.skipped_cont2 = {
	'length': 1024 * 1024 * 300,
	'sha1_git': hex_to_hash(
	'33e45d56f88993aae6a0198013efa80716fd8921'),
	'reason': 'Content too long',
	'status': 'absent',
	}

	self.dir = {
	'id': b'4\x013\x422\x531\x000\xf51\xe62\xa73\xff7\xc3\xa90',
	'entries': [
	{
	'name': b'foo',
	'type': 'file',
	'target': self.cont['sha1_git'],
	'perms': 0o644,
	},
	{
	'name': b'bar\xc3',
	'type': 'dir',
	'target': b'12345678901234567890',
	'perms': 0o2000,
	},
	],
	}

	self.dir2 = {
	'id': b'4\x013\x422\x531\x000\xf51\xe62\xa73\xff7\xc3\xa95',
	'entries': [
	{
	'name': b'oof',
	'type': 'file',
	'target': self.cont2['sha1_git'],
	'perms': 0o644,
	}
	],
	}

	self.dir3 = {
	'id': hex_to_hash('33e45d56f88993aae6a0198013efa80716fd8921'),
	'entries': [
	{
	'name': b'foo',
	'type': 'file',
	'target': self.cont['sha1_git'],
	'perms': 0o644,
	},
	{
	'name': b'bar',
	'type': 'dir',
	'target': b'12345678901234560000',
	'perms': 0o2000,
	},
	{
	'name': b'hello',
	'type': 'file',
	'target': b'12345678901234567890',
	'perms': 0o644,
	},

	],
	}

	self.minus_offset = datetime.timezone(datetime.timedelta(minutes=-120))
	self.plus_offset = datetime.timezone(datetime.timedelta(minutes=120))

	self.revision = {
	'id': b'56789012345678901234',
	'message': b'hello',
	'author': {
	'name': b'Nicolas Dandrimont',
	'email': b'nicolas@example.com',
	},
	'date': datetime.datetime(2015, 1, 1, 22, 0, 0,
	tzinfo=self.plus_offset),
	'committer': {
	'name': b'St\xc3fano Zacchiroli',
	'email': b'stefano@example.com',
	},
	'committer_date': datetime.datetime(2015, 1, 2, 22, 0, 0,
	tzinfo=self.minus_offset),
	'parents': [b'01234567890123456789', b'23434512345123456789'],
	'type': 'git',
	'directory': self.dir['id'],
	'metadata': {'checksums': {'sha1': 'tarball-sha1',
	'sha256': 'tarball-sha256'},
	'signed-off-by': 'some-dude'},
	'synthetic': True
	}

	self.revision2 = {
	'id': b'87659012345678904321',
	'message': b'hello again',
	'author': {
	'name': b'Roberto Dicosmo',
	'email': b'roberto@example.com',
	},
	'date': datetime.datetime(2015, 1, 1, 22, 0, 0,
	tzinfo=self.plus_offset),
	'committer': {
	'name': b'tony',
	'email': b'ar@dumont.fr',
	},
	'committer_date': datetime.datetime(2015, 1, 2, 22, 0, 0,
	tzinfo=self.minus_offset),
	'parents': [b'01234567890123456789'],
	'type': 'git',
	'directory': self.dir2['id'],
	'metadata': None,
	'synthetic': False
	}

	self.revision3 = {
	'id': hex_to_hash('7026b7c1a2af56521e951c01ed20f255fa054238'),
	'message': b'a simple revision with no parents this time',
	'author': {
	'name': b'Roberto Dicosmo',
	'email': b'roberto@example.com',
	},
	'date': datetime.datetime(2015, 10, 1, 22, 0, 0,
	tzinfo=self.plus_offset),
	'committer': {
	'name': b'tony',
	'email': b'ar@dumont.fr',
	},
	'committer_date': datetime.datetime(2015, 10, 2, 22, 0, 0,
	tzinfo=self.minus_offset),
	'parents': [],
	'type': 'git',
	'directory': self.dir2['id'],
	'metadata': None,
	'synthetic': True
	}

	self.revision4 = {
	'id': hex_to_hash('368a48fe15b7db2383775f97c6b247011b3f14f4'),
	'message': b'parent of self.revision2',
	'author': {
	'name': b'me',
	'email': b'me@soft.heri',
	},
	'date': datetime.datetime(2015, 1, 1, 20, 0, 0,
	tzinfo=self.plus_offset),
	'committer': {
	'name': b'committer-dude',
	'email': b'committer@dude.com',
	},
	'committer_date': datetime.datetime(2015, 1, 2, 20, 0, 0,
	tzinfo=self.minus_offset),
	'parents': [self.revision3['id']],
	'type': 'git',
	'directory': self.dir['id'],
	'metadata': None,
	'synthetic': False
	}

	self.origin = {
	'url': 'file:///dev/null',
	'type': 'git',
	}

	self.origin2 = {
	'url': 'file:///dev/zero',
	'type': 'git',
	}

	self.occurrence = {
	- 'branch': 'master',
	+ 'branch': b'master',
	'target': b'67890123456789012345',
	'target_type': 'revision',
	'authority': '5f4d4c51-498a-4e28-88b3-b3e4e8396cba',
	'validity': datetime.datetime(2015, 1, 1, 23, 0, 0,
	tzinfo=datetime.timezone.utc),
	}

	self.occurrence2 = {
	- 'branch': 'master',
	+ 'branch': b'master',
	'target': self.revision2['id'],
	'target_type': 'revision',
	'authority': '5f4d4c51-498a-4e28-88b3-b3e4e8396cba',
	'validity': datetime.datetime(2015, 1, 1, 23, 0, 0,
	tzinfo=datetime.timezone.utc),
	}

	self.release = {
	'id': b'87659012345678901234',
	- 'name': 'v0.0.1',
	+ 'name': b'v0.0.1',
	'date': datetime.datetime(2015, 1, 1, 22, 0, 0,
	tzinfo=self.plus_offset),
	'author': {
	'name': b'olasd',
	'email': b'nic@olasd.fr',
	},
	'target': b'43210987654321098765',
	'target_type': 'revision',
	'message': b'synthetic release',
	'synthetic': True,
	}

	self.release2 = {
	'id': b'56789012348765901234',
	- 'name': 'v0.0.2',
	+ 'name': b'v0.0.2',
	'date': datetime.datetime(2015, 1, 2, 23, 0, 0,
	tzinfo=self.minus_offset),
	'author': {
	'name': b'tony',
	'email': b'ar@dumont.fr',
	},
	'target': b'432109\xa9765432\xc309\x00765',
	'target_type': 'revision',
	'message': b'v0.0.2\nMisc performance improvments + bug fixes',
	'synthetic': False
	}

	self.release3 = {
	'id': b'87659012345678904321',
	- 'name': 'v0.0.2',
	+ 'name': b'v0.0.2',
	'date': datetime.datetime(2016, 1, 1, 19, 0, 0,
	tzinfo=self.plus_offset),
	'author': {
	'name': b'tony',
	'email': b'tony@ardumont.fr',
	},
	'target': self.revision2['id'],
	'target_type': 'revision',
	'message': b'yet another synthetic release',
	'synthetic': True,
	}

	self.fetch_history_date = datetime.datetime(
	2015, 1, 2, 21, 0, 0,
	tzinfo=datetime.timezone.utc)
	self.fetch_history_end = datetime.datetime(
	2015, 1, 2, 23, 0, 0,
	tzinfo=datetime.timezone.utc)

	self.fetch_history_duration = (self.fetch_history_end -
	self.fetch_history_date)

	self.fetch_history_data = {
	'status': True,
	'result': {'foo': 'bar'},
	'stdout': 'blabla',
	'stderr': 'blablabla',
	}

	self.entity1 = {
	'uuid': 'f96a7ec1-0058-4920-90cc-7327e4b5a4bf',
	# GitHub users
	'parent': 'ad6df473-c1d2-4f40-bc58-2b091d4a750e',
	'name': 'github:user:olasd',
	'type': 'person',
	'description': 'Nicolas Dandrimont',
	'homepage': 'http://example.com',
	'active': True,
	'generated': True,
	# swh.lister.github
	'lister': '34bd6b1b-463f-43e5-a697-785107f598e4',
	'lister_metadata': {
	'id': 12877,
	'type': 'user',
	'last_activity': '2015-11-03',
	},
	'doap': None,
	'validity': [
	datetime.datetime(2015, 11, 3, 11, 0, 0,
	tzinfo=datetime.timezone.utc),
	]
	}

	self.entity1_query = {
	'lister': '34bd6b1b-463f-43e5-a697-785107f598e4',
	'lister_metadata': {
	'id': 12877,
	'type': 'user',
	},
	}

	self.entity2 = {
	'uuid': '3903d075-32d6-46d4-9e29-0aef3612c4eb',
	# GitHub users
	'parent': 'ad6df473-c1d2-4f40-bc58-2b091d4a750e',
	'name': 'github:user:zacchiro',
	'type': 'person',
	'description': 'Stefano Zacchiroli',
	'homepage': 'http://example.com',
	'active': True,
	'generated': True,
	# swh.lister.github
	'lister': '34bd6b1b-463f-43e5-a697-785107f598e4',
	'lister_metadata': {
	'id': 216766,
	'type': 'user',
	'last_activity': '2015-11-03',
	},
	'doap': None,
	'validity': [
	datetime.datetime(2015, 11, 3, 11, 0, 0,
	tzinfo=datetime.timezone.utc),
	]
	}

	self.entity3 = {
	'uuid': '111df473-c1d2-4f40-bc58-2b091d4a7111',
	# GitHub users
	'parent': '222df473-c1d2-4f40-bc58-2b091d4a7222',
	'name': 'github:user:ardumont',
	'type': 'person',
	'description': 'Antoine R. Dumont a.k.a tony',
	'homepage': 'https://ardumont.github.io',
	'active': True,
	'generated': True,
	'lister': '34bd6b1b-463f-43e5-a697-785107f598e4',
	'lister_metadata': {
	'id': 666,
	'type': 'user',
	'last_activity': '2016-01-15',
	},
	'doap': None,
	'validity': [
	datetime.datetime(2015, 11, 3, 11, 0, 0,
	tzinfo=datetime.timezone.utc),
	]
	}

	self.entity4 = {
	'uuid': '222df473-c1d2-4f40-bc58-2b091d4a7222',
	# GitHub users
	'parent': None,
	'name': 'github:user:ToNyX',
	'type': 'person',
	'description': 'ToNyX',
	'homepage': 'https://ToNyX.github.io',
	'active': True,
	'generated': True,
	'lister': '34bd6b1b-463f-43e5-a697-785107f598e4',
	'lister_metadata': {
	'id': 999,
	'type': 'user',
	'last_activity': '2015-12-24',
	},
	'doap': None,
	'validity': [
	datetime.datetime(2015, 11, 3, 11, 0, 0,
	tzinfo=datetime.timezone.utc),
	]
	}

	self.entity2_query = {
	'lister': '34bd6b1b-463f-43e5-a697-785107f598e4',
	'lister_metadata': {
	'id': 216766,
	'type': 'user',
	},
	}

	def tearDown(self):
	shutil.rmtree(self.objroot)

	self.cursor.execute("""SELECT table_name FROM information_schema.tables
	WHERE table_schema = %s""", ('public',))

	tables = set(table for (table,) in self.cursor.fetchall())
	tables -= {'dbversion', 'entity', 'entity_history', 'listable_entity'}

	for table in tables:
	self.cursor.execute('truncate table %s cascade' % table)

	self.cursor.execute('delete from entity where generated=true')
	self.cursor.execute('delete from entity_history where generated=true')
	self.conn.commit()

	super().tearDown()

	@istest
	def content_add(self):
	cont = self.cont

	self.storage.content_add([cont])
	if hasattr(self.storage, 'objstorage'):
	self.assertIn(cont['sha1'], self.storage.objstorage)
	self.cursor.execute('SELECT sha1, sha1_git, sha256, length, status'
	' FROM content WHERE sha1 = %s',
	(cont['sha1'],))
	datum = self.cursor.fetchone()
	self.assertEqual(
	(datum[0].tobytes(), datum[1].tobytes(), datum[2].tobytes(),
	datum[3], datum[4]),
	(cont['sha1'], cont['sha1_git'], cont['sha256'],
	cont['length'], 'visible'))

	@istest
	def content_add_collision(self):
	cont1 = self.cont

	# create (corrupted) content with same sha1{,_git} but != sha256
	cont1b = cont1.copy()
	sha256_array = bytearray(cont1b['sha256'])
	sha256_array[0] += 1
	cont1b['sha256'] = bytes(sha256_array)

	with self.assertRaises(psycopg2.IntegrityError):
	self.storage.content_add([cont1, cont1b])

	@istest
	def skipped_content_add(self):
	cont = self.skipped_cont
	cont2 = self.skipped_cont2

	self.storage.content_add([cont])
	self.storage.content_add([cont2])

	self.cursor.execute('SELECT sha1, sha1_git, sha256, length, status,'
	'reason FROM skipped_content ORDER BY sha1_git')

	datum = self.cursor.fetchone()
	self.assertEqual(
	(datum[0], datum[1].tobytes(), datum[2],
	datum[3], datum[4], datum[5]),
	(None, cont['sha1_git'], None,
	cont['length'], 'absent', 'Content too long'))

	datum2 = self.cursor.fetchone()
	self.assertEqual(
	(datum2[0], datum2[1].tobytes(), datum2[2],
	datum2[3], datum2[4], datum2[5]),
	(None, cont2['sha1_git'], None,
	cont2['length'], 'absent', 'Content too long'))

	@istest
	def content_missing(self):
	cont2 = self.cont2
	missing_cont = self.missing_cont
	self.storage.content_add([cont2])
	gen = self.storage.content_missing([cont2, missing_cont])

	self.assertEqual(list(gen), [missing_cont['sha1']])

	@istest
	def directory_get(self):
	# given
	init_missing = list(self.storage.directory_missing([self.dir['id']]))
	self.assertEqual([self.dir['id']], init_missing)

	self.storage.directory_add([self.dir])

	# when
	actual_dirs = list(self.storage.directory_get([self.dir['id']]))

	self.assertEqual(len(actual_dirs), 1)

	dir0 = actual_dirs[0]
	self.assertEqual(dir0['id'], self.dir['id'])
	# ids are generated so non deterministic value
	self.assertEqual(len(dir0['file_entries']), 1)
	self.assertEqual(len(dir0['dir_entries']), 1)
	self.assertIsNone(dir0['rev_entries'])

	after_missing = list(self.storage.directory_missing([self.dir['id']]))
	self.assertEqual([], after_missing)

	@istest
	def directory_add(self):
	init_missing = list(self.storage.directory_missing([self.dir['id']]))
	self.assertEqual([self.dir['id']], init_missing)

	self.storage.directory_add([self.dir])

	stored_data = list(self.storage.directory_ls(self.dir['id']))

	data_to_store = [{
	'dir_id': self.dir['id'],
	'type': ent['type'],
	'target': ent['target'],
	'name': ent['name'],
	'perms': ent['perms'],
	'status': None,
	'sha1': None,
	'sha1_git': None,
	'sha256': None,
	}
	for ent in sorted(self.dir['entries'], key=lambda ent: ent['name'])
	]

	self.assertEqual(data_to_store, stored_data)

	after_missing = list(self.storage.directory_missing([self.dir['id']]))
	self.assertEqual([], after_missing)

	@istest
	def directory_entry_get_by_path(self):
	# given
	init_missing = list(self.storage.directory_missing([self.dir3['id']]))
	self.assertEqual([self.dir3['id']], init_missing)

	self.storage.directory_add([self.dir3])

	expected_entries = [
	{
	'dir_id': self.dir3['id'],
	'name': b'foo',
	'type': 'file',
	'target': self.cont['sha1_git'],
	'sha1': None,
	'sha1_git': None,
	'sha256': None,
	'status': None,
	'perms': 0o644,
	},
	{
	'dir_id': self.dir3['id'],
	'name': b'bar',
	'type': 'dir',
	'target': b'12345678901234560000',
	'sha1': None,
	'sha1_git': None,
	'sha256': None,
	'status': None,
	'perms': 0o2000,
	},
	{
	'dir_id': self.dir3['id'],
	'name': b'hello',
	'type': 'file',
	'target': b'12345678901234567890',
	'sha1': None,
	'sha1_git': None,
	'sha256': None,
	'status': None,
	'perms': 0o644,
	},
	]

	# when (all must be found here)
	for entry, expected_entry in zip(self.dir3['entries'],
	expected_entries):
	actual_entry = self.storage.directory_entry_get_by_path(
	self.dir3['id'],
	[entry['name']])
	self.assertEqual(actual_entry, expected_entry)

	# when (nothing should be found here since self.dir is not persisted.)
	for entry in self.dir['entries']:
	actual_entry = self.storage.directory_entry_get_by_path(
	self.dir['id'],
	[entry['name']])
	self.assertIsNone(actual_entry)

	@istest
	def revision_add(self):
	init_missing = self.storage.revision_missing([self.revision['id']])
	self.assertEqual([self.revision['id']], list(init_missing))

	self.storage.revision_add([self.revision])

	end_missing = self.storage.revision_missing([self.revision['id']])
	self.assertEqual([], list(end_missing))

	@istest
	def revision_log(self):
	# given
	# self.revision4 -is-child-of-> self.revision3
	self.storage.revision_add([self.revision3,
	self.revision4])

	# when
	actual_result = self.storage.revision_log([self.revision4['id']])

	res = list(actual_result)
	self.assertEqual(len(res), 2) # revision4 is a child of revision3

	self.assertEquals(res[0], self.revision4)
	self.assertEquals(res[1], self.revision3)

	@istest
	def revision_log_with_limit(self):
	# given
	# self.revision4 -is-child-of-> self.revision3
	self.storage.revision_add([self.revision3,
	self.revision4])
	actual_result = self.storage.revision_log([self.revision4['id']], 1)

	res = list(actual_result)
	self.assertEqual(len(res), 1)

	self.assertEquals(res[0], self.revision4)

	@istest
	def revision_get(self):
	self.storage.revision_add([self.revision])

	get = list(self.storage.revision_get([self.revision['id'],
	self.revision2['id']]))

	self.assertEqual(len(get), 2)
	self.assertEqual(get[0], self.revision)
	self.assertEqual(get[0]['date'].utcoffset(),
	self.revision['date'].utcoffset())
	self.assertEqual(get[0]['committer_date'].utcoffset(),
	self.revision['committer_date'].utcoffset())
	self.assertEqual(get[1], None)

	@istest
	def revision_get_no_parents(self):
	self.storage.revision_add([self.revision3])

	get = list(self.storage.revision_get([self.revision3['id']]))

	self.assertEqual(len(get), 1)
	self.assertEqual(get[0]['parents'], []) # no parents on this one

	@istest
	def revision_get_by(self):
	# given
	self.storage.content_add([self.cont2])
	self.storage.directory_add([self.dir2]) # point to self.cont
	self.storage.revision_add([self.revision2]) # points to self.dir
	origin_id = self.storage.origin_add_one(self.origin2)

	# occurrence2 points to 'revision2' with branch 'master', we
	# need to point to the right origin
	occurrence2 = self.occurrence2.copy()
	occurrence2.update({'origin': origin_id})
	self.storage.occurrence_add([occurrence2])

	# we want only revision 2
	expected_revisions = list(self.storage.revision_get(
	[self.revision2['id']]))

	# when
	actual_results = list(self.storage.revision_get_by(
	origin_id,
	occurrence2['branch'],
	None))

	self.assertEqual(actual_results[0], expected_revisions[0])

	# when (with no branch filtering, it's still ok)
	actual_results = list(self.storage.revision_get_by(
	origin_id,
	None,
	None))

	self.assertEqual(actual_results[0], expected_revisions[0])

	@istest
	def revision_get_by_multiple_occurrence(self):
	# 2 occurrences pointing to 2 different revisions
	# each occurence have 1 hour delta
	# the api must return the revision whose occurrence is the nearest.

	# given
	self.storage.content_add([self.cont2])
	self.storage.directory_add([self.dir2])
	self.storage.revision_add([self.revision2, self.revision3])
	origin_id = self.storage.origin_add_one(self.origin2)

	# occurrence2 points to 'revision2' with branch 'master', we
	# need to point to the right origin
	occurrence2 = self.occurrence2.copy()
	occurrence2.update({'origin': origin_id,
	'validity': occurrence2['validity']})

	occurrence3 = self.occurrence2.copy()
	occurrence3.update({'origin': origin_id,
	'validity': occurrence3['validity'] +
	datetime.timedelta(days=1),
	'target': self.revision3['id']})

	# 2 occurrences on same revision with lower validity date with 1h delta
	self.storage.occurrence_add([occurrence2])
	self.storage.occurrence_add([occurrence3])

	# when
	actual_results0 = list(self.storage.revision_get_by(
	origin_id,
	occurrence2['branch'],
	occurrence2['validity']))

	expected_revisions = list(self.storage.revision_get(
	[self.revision2['id'],
	self.revision3['id']]))

	self.assertEquals(len(actual_results0), 1)
	self.assertEqual(actual_results0[0]['id'], self.revision2['id'])
	self.assertEqual(actual_results0, [expected_revisions[0]]) # revision2

	# when
	actual_results1 = list(self.storage.revision_get_by(
	origin_id,
	occurrence3['branch'],
	occurrence3['validity']))

	self.assertEquals(len(actual_results1), 1)
	self.assertEqual(actual_results1, [self.revision3])

	# when
	actual_results1 = list(self.storage.revision_get_by(
	origin_id,
	None,
	None))

	self.assertEquals(len(actual_results1), 2)
	self.assertEqual(actual_results1, [self.revision3, self.revision2])

	@istest
	def release_add(self):
	init_missing = self.storage.release_missing([self.release['id'],
	self.release2['id']])
	self.assertEqual([self.release['id'], self.release2['id']],
	list(init_missing))

	self.storage.release_add([self.release, self.release2])

	end_missing = self.storage.release_missing([self.release['id'],
	self.release2['id']])
	self.assertEqual([], list(end_missing))

	@istest
	def release_get(self):
	# given
	self.storage.release_add([self.release, self.release2])

	# when
	actual_releases = self.storage.release_get([self.release['id'],
	self.release2['id']])

	actual_releases = list(actual_releases)

	# then
	self.assertEquals([self.release, self.release2],
	[actual_releases[0], actual_releases[1]])

	@istest
	def release_get_by(self):
	# given
	self.storage.revision_add([self.revision2]) # points to self.dir
	self.storage.release_add([self.release3])
	origin_id = self.storage.origin_add_one(self.origin2)

	# occurrence2 points to 'revision2' with branch 'master', we
	# need to point to the right origin
	occurrence2 = self.occurrence2.copy()
	occurrence2.update({'origin': origin_id})
	self.storage.occurrence_add([occurrence2])

	# we want only revision 2
	expected_releases = list(self.storage.release_get(
	[self.release3['id']]))

	# when
	actual_results = list(self.storage.release_get_by(
	occurrence2['origin']))

	# then
	self.assertEqual(actual_results[0], expected_releases[0])

	@istest
	def origin_add_one(self):
	origin0 = self.storage.origin_get(self.origin)
	self.assertIsNone(origin0)

	id = self.storage.origin_add_one(self.origin)

	actual_origin = self.storage.origin_get({'url': self.origin['url'],
	'type': self.origin['type']})
	self.assertEqual(actual_origin['id'], id)

	id2 = self.storage.origin_add_one(self.origin)

	self.assertEqual(id, id2)

	@istest
	def origin_get(self):
	self.assertIsNone(self.storage.origin_get(self.origin))
	id = self.storage.origin_add_one(self.origin)

	# lookup per type and url (returns id)
	actual_origin0 = self.storage.origin_get({'url': self.origin['url'],
	'type': self.origin['type']})
	self.assertEqual(actual_origin0['id'], id)

	# lookup per id (returns dict)
	actual_origin1 = self.storage.origin_get({'id': id})

	self.assertEqual(actual_origin1, {'id': id,
	'type': self.origin['type'],
	'url': self.origin['url'],
	'lister': None,
	'project': None})

	@istest
	def occurrence_add(self):
	origin_id = self.storage.origin_add_one(self.origin2)

	revision = self.revision.copy()
	revision['id'] = self.occurrence['target']
	self.storage.revision_add([revision])

	occur = self.occurrence
	occur['origin'] = origin_id
	self.storage.occurrence_add([occur])
	self.storage.occurrence_add([occur])

	test_query = '''select origin, branch, target, target_type, authority, validity
	from occurrence_history
	order by origin, validity'''

	self.cursor.execute(test_query)
	ret = self.cursor.fetchall()
	self.assertEqual(len(ret), 1)
	- self.assertEqual((ret[0][0], ret[0][1], ret[0][2].tobytes(), ret[0][3],
	- ret[0][4]), (occur['origin'], occur['branch'],
	- occur['target'], occur['target_type'],
	- occur['authority']))
	+ self.assertEqual((ret[0][0], ret[0][1].tobytes(),
	+ ret[0][2].tobytes(), ret[0][3],
	+ ret[0][4]),
	+ (occur['origin'], occur['branch'],
	+ occur['target'], occur['target_type'],
	+ occur['authority']))

	self.assertEqual(ret[0][5].lower, occur['validity'])
	self.assertEqual(ret[0][5].lower_inc, True)
	self.assertEqual(ret[0][5].upper, datetime.datetime.max)

	orig_validity = occur['validity']
	occur['validity'] += datetime.timedelta(hours=10)
	self.storage.occurrence_add([occur])

	self.cursor.execute(test_query)
	ret = self.cursor.fetchall()
	self.assertEqual(len(ret), 2)
	self.assertEqual(ret[0][5].lower, orig_validity)
	self.assertEqual(ret[0][5].lower_inc, True)
	self.assertEqual(ret[0][5].upper, occur['validity'])
	self.assertEqual(ret[0][5].upper_inc, False)
	self.assertEqual(ret[1][5].lower, occur['validity'])
	self.assertEqual(ret[1][5].lower_inc, True)
	self.assertEqual(ret[1][5].upper, datetime.datetime.max)

	@istest
	def occurrence_get(self):
	# given
	origin_id = self.storage.origin_add_one(self.origin2)

	revision = self.revision.copy()
	revision['id'] = self.occurrence['target']
	self.storage.revision_add([revision])

	occur = self.occurrence
	occur['origin'] = origin_id
	self.storage.occurrence_add([occur])
	self.storage.occurrence_add([occur])

	# when
	actual_occurrence = list(self.storage.occurrence_get(origin_id))

	# then
	expected_occur = occur.copy()
	expected_occur.update({
	'validity_lower': expected_occur['validity'],
	'validity_upper': datetime.datetime(9999, 12, 31, 23, 59, 59,
	999999)
	})
	del expected_occur['validity']

	self.assertEquals(len(actual_occurrence), 1)
	self.assertEquals(actual_occurrence[0], expected_occur)

	@istest
	def content_find_occurrence_with_present_content(self):
	# 1. with something to find
	# given
	self.storage.content_add([self.cont2])
	self.storage.directory_add([self.dir2]) # point to self.cont
	self.storage.revision_add([self.revision2]) # points to self.dir
	origin_id = self.storage.origin_add_one(self.origin2)
	occurrence = self.occurrence2
	occurrence.update({'origin': origin_id})
	self.storage.occurrence_add([occurrence])

	# when
	occ = self.storage.content_find_occurrence(
	{'sha1': self.cont2['sha1']})

	# then
	self.assertEquals(occ['origin_type'], self.origin2['type'])
	self.assertEquals(occ['origin_url'], self.origin2['url'])
	self.assertEquals(occ['branch'], self.occurrence2['branch'])
	self.assertEquals(occ['target'], self.revision2['id'])
	self.assertEquals(occ['target_type'], self.occurrence2['target_type'])
	self.assertEquals(occ['path'], self.dir2['entries'][0]['name'])

	occ2 = self.storage.content_find_occurrence(
	{'sha1_git': self.cont2['sha1_git']})

	self.assertEquals(occ2['origin_type'], self.origin2['type'])
	self.assertEquals(occ2['origin_url'], self.origin2['url'])
	self.assertEquals(occ2['branch'], self.occurrence2['branch'])
	self.assertEquals(occ2['target'], self.revision2['id'])
	self.assertEquals(occ2['target_type'], self.occurrence2['target_type'])
	self.assertEquals(occ2['path'], self.dir2['entries'][0]['name'])

	occ3 = self.storage.content_find_occurrence(
	{'sha256': self.cont2['sha256']})

	self.assertEquals(occ3['origin_type'], self.origin2['type'])
	self.assertEquals(occ3['origin_url'], self.origin2['url'])
	self.assertEquals(occ3['branch'], self.occurrence2['branch'])
	self.assertEquals(occ3['target'], self.revision2['id'])
	self.assertEquals(occ3['target_type'], self.occurrence2['target_type'])
	self.assertEquals(occ3['path'], self.dir2['entries'][0]['name'])

	@istest
	def content_find_occurrence_with_non_present_content(self):
	# 1. with something that does not exist
	missing_cont = self.missing_cont

	occ = self.storage.content_find_occurrence(
	{'sha1': missing_cont['sha1']})

	self.assertEquals(occ, None,
	"Content does not exist so no occurrence")

	# 2. with something that does not exist
	occ = self.storage.content_find_occurrence(
	{'sha1_git': missing_cont['sha1_git']})

	self.assertEquals(occ, None,
	"Content does not exist so no occurrence")

	# 3. with something that does not exist
	occ = self.storage.content_find_occurrence(
	{'sha256': missing_cont['sha256']})

	self.assertEquals(occ, None,
	"Content does not exist so no occurrence")

	@istest
	def content_find_occurrence_bad_input(self):
	# 1. with bad input
	with self.assertRaises(ValueError) as cm:
	self.storage.content_find_occurrence({}) # empty is bad
	self.assertIn('content keys', cm.exception.args[0])

	# 2. with bad input
	with self.assertRaises(ValueError) as cm:
	self.storage.content_find_occurrence(
	{'unknown-sha1': 'something'}) # not the right key
	self.assertIn('content keys', cm.exception.args[0])

	@istest
	def entity_get_from_lister_metadata(self):
	self.storage.entity_add([self.entity1])

	fetched_entities = list(
	self.storage.entity_get_from_lister_metadata(
	[self.entity1_query, self.entity2_query]))

	# Entity 1 should have full metadata, with last_seen/last_id instead
	# of validity
	entity1 = self.entity1.copy()
	entity1['last_seen'] = entity1['validity'][0]
	del fetched_entities[0]['last_id']
	del entity1['validity']
	# Entity 2 should have no metadata
	entity2 = self.entity2_query.copy()
	entity2['uuid'] = None

	self.assertEquals(fetched_entities, [entity1, entity2])

	@istest
	def entity_get(self):
	# given
	self.storage.entity_add([self.entity3, self.entity4])

	# when: entity3 -child-of-> entity4
	actual_entity3 = list(self.storage.entity_get(self.entity3['uuid']))

	self.assertEquals(len(actual_entity3), 2)
	# remove dynamic data (modified by db)
	entity3 = self.entity3.copy()
	entity4 = self.entity4.copy()
	del entity3['validity']
	del entity4['validity']
	del actual_entity3[0]['last_seen']
	del actual_entity3[0]['last_id']
	del actual_entity3[1]['last_seen']
	del actual_entity3[1]['last_id']
	self.assertEquals(actual_entity3, [entity3, entity4])

	# when: entity4 only child
	actual_entity4 = list(self.storage.entity_get(self.entity4['uuid']))

	self.assertEquals(len(actual_entity4), 1)
	# remove dynamic data (modified by db)
	entity4 = self.entity4.copy()
	del entity4['validity']
	del actual_entity4[0]['last_id']
	del actual_entity4[0]['last_seen']

	self.assertEquals(actual_entity4, [entity4])

	@istest
	def stat_counters(self):
	expected_keys = ['content', 'directory', 'directory_entry_dir',
	'occurrence', 'origin', 'person', 'revision']
	counters = self.storage.stat_counters()

	self.assertTrue(set(expected_keys) <= set(counters))
	self.assertIsInstance(counters[expected_keys[0]], int)


	class TestStorage(AbstractTestStorage, unittest.TestCase):
	"""Test the local storage"""

	# Can only be tested with local storage as you can't mock
	# datetimes for the remote server
	@istest
	def fetch_history(self):
	origin = self.storage.origin_add_one(self.origin)
	with patch('datetime.datetime'):
	datetime.datetime.now.return_value = self.fetch_history_date
	fetch_history_id = self.storage.fetch_history_start(origin)
	datetime.datetime.now.assert_called_with(tz=datetime.timezone.utc)

	with patch('datetime.datetime'):
	datetime.datetime.now.return_value = self.fetch_history_end
	self.storage.fetch_history_end(fetch_history_id,
	self.fetch_history_data)

	fetch_history = self.storage.fetch_history_get(fetch_history_id)
	expected_fetch_history = self.fetch_history_data.copy()

	expected_fetch_history['id'] = fetch_history_id
	expected_fetch_history['origin'] = origin
	expected_fetch_history['date'] = self.fetch_history_date
	expected_fetch_history['duration'] = self.fetch_history_duration

	self.assertEqual(expected_fetch_history, fetch_history)

	@istest
	def content_find_with_present_content(self):
	# 1. with something to find
	cont = self.cont
	self.storage.content_add([cont])

	actually_present = self.storage.content_find({'sha1': cont['sha1']})

	actually_present.pop('ctime')
	self.assertEqual(actually_present, {
	'sha1': cont['sha1'],
	'sha256': cont['sha256'],
	'sha1_git': cont['sha1_git'],
	'length': cont['length'],
	'status': 'visible'
	})

	# 2. with something to find
	actually_present = self.storage.content_find(
	{'sha1_git': cont['sha1_git']})

	actually_present.pop('ctime')
	self.assertEqual(actually_present, {
	'sha1': cont['sha1'],
	'sha256': cont['sha256'],
	'sha1_git': cont['sha1_git'],
	'length': cont['length'],
	'status': 'visible'
	})

	# 3. with something to find
	actually_present = self.storage.content_find(
	{'sha256': cont['sha256']})

	actually_present.pop('ctime')
	self.assertEqual(actually_present, {
	'sha1': cont['sha1'],
	'sha256': cont['sha256'],
	'sha1_git': cont['sha1_git'],
	'length': cont['length'],
	'status': 'visible'
	})

	# 4. with something to find
	actually_present = self.storage.content_find(
	{'sha1': cont['sha1'],
	'sha1_git': cont['sha1_git'],
	'sha256': cont['sha256']})

	actually_present.pop('ctime')
	self.assertEqual(actually_present, {
	'sha1': cont['sha1'],
	'sha256': cont['sha256'],
	'sha1_git': cont['sha1_git'],
	'length': cont['length'],
	'status': 'visible'
	})

	@istest
	def content_find_with_non_present_content(self):
	# 1. with something that does not exist
	missing_cont = self.missing_cont

	actually_present = self.storage.content_find(
	{'sha1': missing_cont['sha1']})

	self.assertIsNone(actually_present)

	# 2. with something that does not exist
	actually_present = self.storage.content_find(
	{'sha1_git': missing_cont['sha1_git']})

	self.assertIsNone(actually_present)

	# 3. with something that does not exist
	actually_present = self.storage.content_find(
	{'sha256': missing_cont['sha256']})

	self.assertIsNone(actually_present)

	@istest
	def content_find_bad_input(self):
	# 1. with bad input
	with self.assertRaises(ValueError):
	self.storage.content_find({}) # empty is bad

	# 2. with bad input
	with self.assertRaises(ValueError):
	self.storage.content_find(
	{'unknown-sha1': 'something'}) # not the right key

	@istest
	def person_get(self):
	# given
	person0 = {'name': b'bob', 'email': b'alice@bob'}
	id0 = self.storage._person_add(person0)
	person1 = {'name': b'tony', 'email': b'tony@bob'}
	id1 = self.storage._person_add(person1)

	# when
	actual_persons = self.storage.person_get([id0, id1])

	# given (person injection through release for example)
	self.assertEqual(list(actual_persons), [{'id': id0,
	'name': person0['name'],
	'email': person0['email']},
	{'id': id1,
	'name': person1['name'],
	'email': person1['email']}])
	diff --git a/version.txt b/version.txt
	index 2ad8effb..830b2356 100644
	--- a/version.txt
	+++ b/version.txt
	@@ -1 +1 @@
	-v0.0.30-0-gdcb4c61
	\ No newline at end of file
	+v0.0.31-0-g1e345cf
	\ No newline at end of file

File Metadata

Mime Type: text/x-diff
Expires: Sat, Jun 21, 8:57 PM (3 w, 6 d ago)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 3303181

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions