Page Menu
Home
Software Heritage
Search
Configure Global Search
Log In
Files
F7123864
D3569.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Subscribers
None
D3569.diff
View Options
diff --git a/swh/storage/tests/test_storage.py b/swh/storage/tests/test_storage.py
--- a/swh/storage/tests/test_storage.py
+++ b/swh/storage/tests/test_storage.py
@@ -1050,13 +1050,6 @@
# when
actual_results = list(swh_storage.revision_log([revision4.id]))
- # hack: ids generated
- for actual_result in actual_results:
- if "id" in actual_result["author"]:
- del actual_result["author"]["id"]
- if "id" in actual_result["committer"]:
- del actual_result["committer"]["id"]
-
assert len(actual_results) == 2 # rev4 -child-> rev3
assert actual_results[0] == normalize_entity(revision4)
assert actual_results[1] == normalize_entity(revision3)
@@ -1073,13 +1066,6 @@
swh_storage.revision_add([revision3, revision4])
actual_results = list(swh_storage.revision_log([revision4.id], 1))
- # hack: ids generated
- for actual_result in actual_results:
- if "id" in actual_result["author"]:
- del actual_result["author"]["id"]
- if "id" in actual_result["committer"]:
- del actual_result["committer"]["id"]
-
assert len(actual_results) == 1
assert actual_results[0] == normalize_entity(revision4)
@@ -1118,12 +1104,6 @@
actual_revisions = list(swh_storage.revision_get([revision.id, revision2.id]))
- # when
- if "id" in actual_revisions[0]["author"]:
- del actual_revisions[0]["author"]["id"] # hack: ids are generated
- if "id" in actual_revisions[0]["committer"]:
- del actual_revisions[0]["committer"]["id"]
-
assert len(actual_revisions) == 2
assert actual_revisions[0] == normalize_entity(revision)
assert actual_revisions[1] is None
@@ -1275,10 +1255,6 @@
actual_releases = list(swh_storage.release_get([release.id, release2.id]))
# then
- for actual_release in actual_releases:
- if "id" in actual_release["author"]:
- del actual_release["author"]["id"] # hack: ids are generated
-
assert [actual_releases[0], actual_releases[1],] == [
normalize_entity(release),
normalize_entity(release2),
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Dec 20 2024, 5:05 AM (11 w, 3 d ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
3219665
Attached To
D3569: test_storage: revision/release: Drop no longer needed conditionals
Event Timeline
Log In to Comment