Page Menu
Home
Software Heritage
Search
Configure Global Search
Log In
Files
F9697717
D7859.id28379.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Subscribers
None
D7859.id28379.diff
View Options
diff --git a/assets/src/bundles/add_forge/request-dashboard.js b/assets/src/bundles/add_forge/request-dashboard.js
--- a/assets/src/bundles/add_forge/request-dashboard.js
+++ b/assets/src/bundles/add_forge/request-dashboard.js
@@ -51,13 +51,13 @@
$('#requestURL').text(forgeRequest.forge_url);
$('#requestContactName').text(forgeRequest.forge_contact_name);
$('#requestContactConsent').text(forgeRequest.submitter_forward_username);
- $('#requestContactEmail').text(forgeRequest.forge_contact_email);
+ $('#requestContactEmail').text(encodeURIComponent(forgeRequest.forge_contact_email));
$('#submitterMessage').text(forgeRequest.forge_contact_comment);
$('#updateComment').val('');
// Setting data for the email, now adding static data
- $('#contactForgeAdmin').attr('emailTo', forgeRequest.forge_contact_email);
- $('#contactForgeAdmin').attr('emailCc', forgeRequest.inbound_email_address);
+ $('#contactForgeAdmin').attr('emailTo', encodeURIComponent(forgeRequest.forge_contact_email));
+ $('#contactForgeAdmin').attr('emailCc', encodeURIComponent(forgeRequest.inbound_email_address));
$('#contactForgeAdmin').attr('emailSubject', `Software Heritage archival request for ${forgeRequest.forge_domain}`);
populateRequestHistory(data.history);
populateDecisionSelectOption(forgeRequest.status);
diff --git a/cypress/integration/add-forge-now-request-dashboard.spec.js b/cypress/integration/add-forge-now-request-dashboard.spec.js
--- a/cypress/integration/add-forge-now-request-dashboard.spec.js
+++ b/cypress/integration/add-forge-now-request-dashboard.spec.js
@@ -12,7 +12,7 @@
const requestData = {
forge_type: 'bitbucket',
forge_url: 'test.example.com',
- forge_contact_email: 'test@example.com',
+ forge_contact_email: encodeURIComponent('test@example.com'),
forge_contact_name: 'test user',
submitter_forward_username: true,
forge_contact_comment: 'test comment'
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Aug 18, 12:43 AM (2 w, 2 d ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
3227157
Attached To
D7859: fix mailto encoding for inbound email
Event Timeline
Log In to Comment