Page MenuHomeSoftware Heritage
Feed All Stories

Sep 20 2019

zack committed rDTPL72c29548cef6: add mypy scaffolding (authored by zack).
add mypy scaffolding
Sep 20 2019, 1:29 PM
zack committed rDCORE29801057f216: mypy: ignore django-stubs, needed only by hypothesis (authored by zack).
mypy: ignore django-stubs, needed only by hypothesis
Sep 20 2019, 1:24 PM
zack committed rDCORE5ad4fd3374aa: typing: minimal changes to make a no-op mypy run pass (authored by zack).
typing: minimal changes to make a no-op mypy run pass
Sep 20 2019, 1:24 PM
zack committed rDCOREb5f27e87ae1f: mypy: use conffile to ignore requests_mock (authored by zack).
mypy: use conffile to ignore requests_mock
Sep 20 2019, 1:24 PM
zack closed D2015: typing: minimal changes to make a no-op mypy run pass.
Sep 20 2019, 1:24 PM
swh-public-ci added a comment to D2016: typing: minimal changes to make a no-op mypy run pass.

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/127/ for more details.

Sep 20 2019, 12:15 PM
zack added inline comments to D2016: typing: minimal changes to make a no-op mypy run pass.
Sep 20 2019, 12:14 PM
zack updated the diff for D2016: typing: minimal changes to make a no-op mypy run pass.
  • mypy: ignore django-stubs, needed only by hypothesis
  • identifiers.py: do not inherit from on-the-fly namedtuple
Sep 20 2019, 12:14 PM
swh-public-ci added a comment to D2015: typing: minimal changes to make a no-op mypy run pass.

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/289/ for more details.

Sep 20 2019, 12:06 PM
zack updated the diff for D2015: typing: minimal changes to make a no-op mypy run pass.
  • mypy: ignore django-stubs, needed only by hypothesis
Sep 20 2019, 12:04 PM
vlorentz added inline comments to D2016: typing: minimal changes to make a no-op mypy run pass.
Sep 20 2019, 11:44 AM
vlorentz accepted D2015: typing: minimal changes to make a no-op mypy run pass.
Sep 20 2019, 11:37 AM
swh-public-ci added a comment to D2015: typing: minimal changes to make a no-op mypy run pass.

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/288/ for more details.

Sep 20 2019, 11:32 AM
zack updated the diff for D2015: typing: minimal changes to make a no-op mypy run pass.
  • mypy: use conffile to ignore requests_mock
Sep 20 2019, 11:30 AM
swh-public-ci added a comment to D2016: typing: minimal changes to make a no-op mypy run pass.

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/126/ for more details.

Sep 20 2019, 11:29 AM
zack updated the diff for D2016: typing: minimal changes to make a no-op mypy run pass.
  • mypy.ini: remove left-over sample section
Sep 20 2019, 11:28 AM
swh-public-ci added a comment to D2015: typing: minimal changes to make a no-op mypy run pass.

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/287/ for more details.

Sep 20 2019, 11:25 AM
swh-public-ci added a comment to D2016: typing: minimal changes to make a no-op mypy run pass.

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/125/ for more details.

Sep 20 2019, 11:24 AM
zack created D2016: typing: minimal changes to make a no-op mypy run pass.
Sep 20 2019, 11:23 AM
zack created D2015: typing: minimal changes to make a no-op mypy run pass.
Sep 20 2019, 11:22 AM
ardumont committed rDLS85d001067aa8: setup.py: Kill deprecated swh-lister command (authored by ardumont).
setup.py: Kill deprecated swh-lister command
Sep 20 2019, 11:21 AM
ardumont closed D2014: swh-lister: Remove deprecated console scripts `swh-lister`.
Sep 20 2019, 11:21 AM · SWH command line interface, Lister
anlambert accepted D2014: swh-lister: Remove deprecated console scripts `swh-lister`.
Sep 20 2019, 11:18 AM · SWH command line interface, Lister
zack committed rDENV1864119c727a: Makefile.python: drop spurious -p argument to mypy invocation (authored by zack).
Makefile.python: drop spurious -p argument to mypy invocation
Sep 20 2019, 11:18 AM
zack committed rDENVf21086656eb8: mypy: run on the swh/ dir rather than package (authored by zack).
mypy: run on the swh/ dir rather than package
Sep 20 2019, 11:16 AM
swh-public-ci added a comment to D2014: swh-lister: Remove deprecated console scripts `swh-lister`.

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/375/ for more details.

Sep 20 2019, 11:15 AM · SWH command line interface, Lister
ardumont retitled D2014: swh-lister: Remove deprecated console scripts `swh-lister` from setup.py: Fix wrong console scripts entry point for swh-lister command to swh-lister: Remove deprecated console scripts `swh-lister`.
Sep 20 2019, 11:13 AM · SWH command line interface, Lister
ardumont updated the diff for D2014: swh-lister: Remove deprecated console scripts `swh-lister`.

In the end, kill the deprecated and unused command

Sep 20 2019, 11:12 AM · SWH command line interface, Lister
swh-public-ci added a comment to D2014: swh-lister: Remove deprecated console scripts `swh-lister`.

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/374/ for more details.

Sep 20 2019, 10:05 AM · SWH command line interface, Lister
ardumont updated the test plan for D2014: swh-lister: Remove deprecated console scripts `swh-lister`.
Sep 20 2019, 10:04 AM · SWH command line interface, Lister
ardumont updated the test plan for D2014: swh-lister: Remove deprecated console scripts `swh-lister`.
Sep 20 2019, 10:04 AM · SWH command line interface, Lister
ardumont created D2014: swh-lister: Remove deprecated console scripts `swh-lister`.
Sep 20 2019, 10:03 AM · SWH command line interface, Lister
ardumont committed rDLDBASE2df3bd9e1c85: loader.pypi: Add tests around sdist_parse (authored by ardumont).
loader.pypi: Add tests around sdist_parse
Sep 20 2019, 7:40 AM
ardumont committed rDLDBASEac5f1a878a16: loader.pypi: Add test around sdist_parse (authored by ardumont).
loader.pypi: Add test around sdist_parse
Sep 20 2019, 7:40 AM
ardumont committed rDLDBASEb2752142cc04: pypi: Fix pep8 violations (authored by ardumont).
pypi: Fix pep8 violations
Sep 20 2019, 7:40 AM
ardumont committed rDLDBASE902845193523: package.pypi: Add tests around PyPIClient (authored by ardumont).
package.pypi: Add tests around PyPIClient
Sep 20 2019, 12:05 AM
ardumont committed rDLDBASEf4c44e49bb3e: package.pypi: Add type annotation (authored by ardumont).
package.pypi: Add type annotation
Sep 20 2019, 12:05 AM
ardumont committed rDLDBASE26190a555ad8: package.pypi: Update docstrings and type annotations (authored by ardumont).
package.pypi: Update docstrings and type annotations
Sep 20 2019, 12:05 AM

Sep 19 2019

ardumont added a comment to T2012: ci: Add a rule to prevent push when ci build failure.

I've definitely got a "build failed" automatic notification after a push I did a while ago. I think it was on swh-environment, before we (recently) disabled the CI on it. If this notification behavior is not uniform across repos, we should make it so.

Sep 19 2019, 11:41 PM · Continuous Integration
zack committed rDENV758f7df1bdb0: make mypy settings per-package (authored by zack).
make mypy settings per-package
Sep 19 2019, 11:01 PM
zack added a comment to T2012: ci: Add a rule to prevent push when ci build failure.
In T2012#37261, @zack wrote:

Count me as -1 on this.

Strict rules like these tend to get in the way of getting work done when you need it.

Sep 19 2019, 10:55 PM · Continuous Integration
zack committed rDVAUfef0300bbc1e: CLI: drop obsolete alias "serve" for "rpc-serve" (authored by zack).
CLI: drop obsolete alias "serve" for "rpc-serve"
Sep 19 2019, 10:49 PM
zack closed D2013: CLI: drop obsolete alias "serve" for "rpc-serve".
Sep 19 2019, 10:49 PM
zack added a comment to T2012: ci: Add a rule to prevent push when ci build failure.

From what you wrote, what I think will actually fix your problem is seeing the OK/KO CI marker in the list of pending review requests, so that you can just skip the ones with failing build without having to click them. Would that be enough?

Sep 19 2019, 10:45 PM · Continuous Integration
ardumont accepted D2013: CLI: drop obsolete alias "serve" for "rpc-serve".
Sep 19 2019, 10:35 PM
ardumont added a comment to T2012: ci: Add a rule to prevent push when ci build failure.

I totally agree that we need safeguards against pushing stuff that breaks CI, but we seem to have plenty already: we use code review thoroughly, and that triggers CI;

Sep 19 2019, 10:34 PM · Continuous Integration
swh-public-ci added a comment to D2013: CLI: drop obsolete alias "serve" for "rpc-serve".

Build is green
See https://jenkins.softwareheritage.org/job/DVAU/job/tox/88/ for more details.

Sep 19 2019, 10:16 PM
zack created D2013: CLI: drop obsolete alias "serve" for "rpc-serve".
Sep 19 2019, 10:14 PM
zack committed rDLDG41af03e8c8df: test_from_disk.py: avoid shadowing base classes in tests (authored by zack).
test_from_disk.py: avoid shadowing base classes in tests
Sep 19 2019, 10:10 PM
zack closed D2011: test_from_disk.py: avoid shadowing base classes in tests.
Sep 19 2019, 10:10 PM
zack committed rDCORE8faa3254ccbf: db_testing.py: do not explode when TEST_DB_DUMP = None (authored by zack).
db_testing.py: do not explode when TEST_DB_DUMP = None
Sep 19 2019, 10:07 PM
zack closed D2012: db_testing.py: do not explode when TEST_DB_DUMP = None.
Sep 19 2019, 10:07 PM
zack committed rDDEP8f39669af9b7: admin CLI: avoid redefining deposit name in admin subcommand (authored by zack).
admin CLI: avoid redefining deposit name in admin subcommand
Sep 19 2019, 10:07 PM
zack closed D2009: admin CLI: avoid redefining deposit name in admin subcommand.
Sep 19 2019, 10:07 PM
ardumont committed rDLDBASE03f5a1f90ea9: test_pypi: Add tests around `author` function (authored by ardumont).
test_pypi: Add tests around `author` function
Sep 19 2019, 9:42 PM
ardumont committed rDLDBASE25aac0ea9f59: loader.package: Bootstrap tests (authored by ardumont).
loader.package: Bootstrap tests
Sep 19 2019, 9:34 PM
ardumont committed rDLDBASE64ba90a75197: loader.package: Fix pep8 violations (authored by ardumont).
loader.package: Fix pep8 violations
Sep 19 2019, 9:34 PM
ardumont committed rDLDBASE102bc7b38c34: package.pypi: Fix __init__ call (authored by ardumont).
package.pypi: Fix __init__ call
Sep 19 2019, 9:34 PM
ardumont committed rDLDBASE9a456a652ac7: package.loader: Fix import (authored by ardumont).
package.loader: Fix import
Sep 19 2019, 9:34 PM
ardumont committed rDLDBASEa62355d56656: package.loader: Remove spurious fixme (authored by ardumont).
package.loader: Remove spurious fixme
Sep 19 2019, 9:34 PM
ardumont committed rDLDBASE3f3e774c47bb: requirements: Add missing pkginfo (authored by ardumont).
requirements: Add missing pkginfo
Sep 19 2019, 9:34 PM
ardumont accepted D2009: admin CLI: avoid redefining deposit name in admin subcommand.
Sep 19 2019, 9:23 PM
ardumont accepted D2012: db_testing.py: do not explode when TEST_DB_DUMP = None.
Sep 19 2019, 9:22 PM
ardumont accepted D2011: test_from_disk.py: avoid shadowing base classes in tests.
Sep 19 2019, 9:22 PM
swh-public-ci added a comment to D2012: db_testing.py: do not explode when TEST_DB_DUMP = None.

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/286/ for more details.

Sep 19 2019, 6:16 PM
zack created D2012: db_testing.py: do not explode when TEST_DB_DUMP = None.
Sep 19 2019, 6:14 PM
zack abandoned D2010: test_loader.py: drop unused (and wrongly typed) TEST_DB_DUMP.
Sep 19 2019, 6:04 PM
zack planned changes to D2010: test_loader.py: drop unused (and wrongly typed) TEST_DB_DUMP.
Sep 19 2019, 5:59 PM
swh-public-ci added a comment to D2011: test_from_disk.py: avoid shadowing base classes in tests.

Build is green
See https://jenkins.softwareheritage.org/job/DLDG/job/tox/98/ for more details.

Sep 19 2019, 5:56 PM
zack created D2011: test_from_disk.py: avoid shadowing base classes in tests.
Sep 19 2019, 5:54 PM
Harbormaster failed remote builds in B7866: Diff 6757 for D2010: test_loader.py: drop unused (and wrongly typed) TEST_DB_DUMP!
Sep 19 2019, 5:52 PM
swh-public-ci added a comment to D2010: test_loader.py: drop unused (and wrongly typed) TEST_DB_DUMP.

Build has FAILED

Sep 19 2019, 5:52 PM
zack created D2010: test_loader.py: drop unused (and wrongly typed) TEST_DB_DUMP.
Sep 19 2019, 5:50 PM
vlorentz requested changes to D1720: Modify API output and test.

@twitu Hi, any news on this?

Sep 19 2019, 5:30 PM
olasd committed rSPSITE076377c4aa17: Use librdkafka1 from backports for journal users (authored by olasd).
Use librdkafka1 from backports for journal users
Sep 19 2019, 4:48 PM
ardumont committed rDLDBASEfc977e6e92cb: wip: Add pypi implementation (authored by ardumont).
wip: Add pypi implementation
Sep 19 2019, 4:40 PM
swh-public-ci added a comment to D2009: admin CLI: avoid redefining deposit name in admin subcommand.

Build is green
See https://jenkins.softwareheritage.org/job/DDEP/job/tox/175/ for more details.

Sep 19 2019, 4:04 PM
zack created D2009: admin CLI: avoid redefining deposit name in admin subcommand.
Sep 19 2019, 4:02 PM
rdicosmo committed R183:f2e65be74a60: Added Abelson and Sussman SICP (authored by rdicosmo).
Added Abelson and Sussman SICP
Sep 19 2019, 3:25 PM
rdicosmo committed R183:6a1ce8cc6810: Added VirtualAGC and Paris Call (authored by rdicosmo).
Added VirtualAGC and Paris Call
Sep 19 2019, 2:57 PM
vlorentz committed rDJNLb6e9288b844a: Add a test directly for the journal client. (authored by vlorentz).
Add a test directly for the journal client.
Sep 19 2019, 2:38 PM
vlorentz closed D2007: Add a test directly for the journal client..
Sep 19 2019, 2:38 PM
anlambert closed T2014: Github lister erroneously delete some loading tasks as Resolved by committing rDLS04d8fdf8df45: github/lister: Prevent erroneous scheduler tasks disabling.
Sep 19 2019, 2:36 PM · GitHub lister
anlambert committed rDLS04d8fdf8df45: github/lister: Prevent erroneous scheduler tasks disabling (authored by anlambert).
github/lister: Prevent erroneous scheduler tasks disabling
Sep 19 2019, 2:36 PM
anlambert closed D2008: Github lister: Prevent erroneous scheduler tasks disabling.
Sep 19 2019, 2:36 PM
ardumont accepted D2008: Github lister: Prevent erroneous scheduler tasks disabling.
Sep 19 2019, 2:34 PM
swh-public-ci added a comment to D2008: Github lister: Prevent erroneous scheduler tasks disabling.

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/373/ for more details.

Sep 19 2019, 2:34 PM
olasd accepted D2008: Github lister: Prevent erroneous scheduler tasks disabling.
Sep 19 2019, 2:34 PM
ardumont accepted D2007: Add a test directly for the journal client..
Sep 19 2019, 2:33 PM
anlambert updated the diff for D2008: Github lister: Prevent erroneous scheduler tasks disabling.

Update: Code simplification

Sep 19 2019, 2:31 PM
swh-public-ci added a comment to D2008: Github lister: Prevent erroneous scheduler tasks disabling.

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/372/ for more details.

Sep 19 2019, 2:29 PM
anlambert created D2008: Github lister: Prevent erroneous scheduler tasks disabling.
Sep 19 2019, 2:26 PM
zack committed R183:8717b3905eba: fix dangling cross reference in Merkle bibliography entry (authored by zack).
fix dangling cross reference in Merkle bibliography entry
Sep 19 2019, 2:15 PM
anlambert triaged T2014: Github lister erroneously delete some loading tasks as Normal priority.
Sep 19 2019, 1:59 PM · GitHub lister
swh-public-ci added a comment to D2007: Add a test directly for the journal client..

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/266/ for more details.

Sep 19 2019, 1:57 PM
zack added a comment to T1964: Timeout reached while assembling the requested bundle (Rocrail).

@sunweaver here it is then: https://annex.softwareheritage.org/public/scratch/36489f4afbc3d2d3a43bf00d79f03deb4e9ed5f7.gz

Sep 19 2019, 1:56 PM · Vault
swh-public-ci added a comment to D2007: Add a test directly for the journal client..

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/265/ for more details.

Sep 19 2019, 1:53 PM
vlorentz updated the diff for D2007: Add a test directly for the journal client..

rebase

Sep 19 2019, 1:49 PM
vlorentz created D2007: Add a test directly for the journal client..
Sep 19 2019, 1:49 PM
vlorentz added a comment to D1999: make codespell pass, fixing false-positives due to single-quoted strings.
In D1999#46521, @zack wrote:

(As a nitpick, I'll go for "[\\w\\-'’\`]+(?=[^'])" instead, but the idea is the same.)

Sep 19 2019, 1:37 PM