Rebase

Rebase

Rebase

Update: Rename some variables and improve comments

Rebase

Looks good to me

Rebase

Update: Address @vlorentz comments

Update: Simplify cypress test

oh with pytest?

In D3079#74970, @vlorentz wrote:

Hmm you're right, it's using now() in addition to a supplied datetime now.

I'll try to make a diff to forbid naive datetimes, like we should always have

In D3079#74963, @vlorentz wrote:

Do you know what update, specifically?

And why did it work so far?

Fix typo in commit message

Django version must be pinned to < 3

There is also a dependency in requirements.txt to update: swh.storage[schemata,listener] => swh.storage[schemata]

Could we manage to launch tox -r -e sphinx-dev when calling make ?

The main drawback of this solution is we loose the possibility of rebuilding
the doc (in tox) while editing a package's documentation without rebuilding
the tox env (i.e. using tox -r). But IMHO this usage has never been
adpoted by anyone, so it's much simpler that way.

Looks good, there is still the doc index.rst to update with component name though.

I added several comments to address regarding a couple of issues I found. I am not really familiar with replayers so another review is needed as I may have missed something.

sphinx 3.0.3 has been released yersteday, fixing the observed autodoc issue (see latest swh-docs build log).

I wrote that little script to check the number of origin IRIs and URIs in the archive

Rebase

Update: Fix some doc issues (thanks to @ardumont)

In D3064#74490, @ardumont wrote:

/me coughs

we probably wants the same url pattern in the /api/1/ btw.

In D3066#74487, @ardumont wrote:

looks fine.

i was gonna ask about the name "url" instead of "origin_url" in the main diff.
But i guess, here as we are not necessarily in the origin context, the name origin is not necessarily present in the base url.
So it's probably best to keep that "origin_url" everywhere.

Update current year in copyright headers

Looks good to me and I also think only percent encoding ;'; and '%' is better for SWHID readability.

For the record, there is currently no origin with a ';' character in its URL but better anticipate that case indeed.

Update: Use "is not None" syntax

Rebase

Thanks !

It was already there, lol

In D3046#74055, @vlorentz wrote:

You can do it in another diff, that will be less code to review

In D3046#74031, @vlorentz wrote:

In D3046#74006, @anlambert wrote:

Wouldn't this be a good time to also move the URL to a query parameter? (Because of the double-slash issue that can happen on clients)

From my point of view, having the browsed object identifier as URL argument is better for consistency with the rest of the browse URL scheme.

Except those with a path, starting with this diff...

Regarding the double-slash issue, I think we already mitigated it in rDWAPPS56fb869644ad45e0648f4ad45c07619d468019b4

That only fixes trailing slashes, not all double slashes (eg. http:// in the origin url)

Update commit message

In D3046#74009, @ardumont wrote:

I agree that restricting the date format is a good idea for consistency. I propose to only support Unix timestamps and ISO dates.

Awesome, i know at least @douardda will be happy to hear it ;)
Maybe make make that happen in a new diff when you have the time (as you wish ;)

Cheers mate ;)

for how long do we deprecate? What's our timeframe policy to remove those, if we have any?