Page MenuHomeSoftware Heritage
Feed Advanced Search

Feb 18 2020

vlorentz committed rDCORE6c5e89a4e029: Change msgpack serialization to be closer to the JSON one. (authored by vlorentz).
Change msgpack serialization to be closer to the JSON one.
Feb 18 2020, 11:31 AM
vlorentz closed D2671: Change msgpack serialization to be closer to the JSON one..
Feb 18 2020, 11:31 AM
vlorentz accepted D2682: apidoc: Fix and improve rst links parsing.
Feb 18 2020, 11:30 AM
vlorentz added inline comments to D2667: apidoc: Add bullet list support in input/output data documentation.
Feb 18 2020, 11:29 AM
vlorentz accepted D2667: apidoc: Add bullet list support in input/output data documentation.
Feb 18 2020, 11:28 AM
vlorentz requested changes to D2681: add annotation type in some lister file.
Feb 18 2020, 10:53 AM
vlorentz added a comment to D2681: add annotation type in some lister file.

Thanks for the Diff. I started reviewing the Diff, and I have a bunch of comments, see below.
Many of these comments apply to other parts of the diff as well, please fix these as well.

Feb 18 2020, 10:53 AM

Feb 17 2020

vlorentz requested changes to D2660: Adding 'Add Origin info' checkbox which was missing.

Just one comment:

Feb 17 2020, 1:15 PM
vlorentz added a comment to T2239: storage: kafka issue: Can't pickle <class 'cimpl.KafkaException'>: import of module 'cimpl' failed.

python-cassandra too has some un-unpicklable errors:

Feb 17 2020, 12:14 PM · Storage manager

Feb 15 2020

vlorentz moved T2175: Deploy swh-icinga-plugins from Backlog to deployed on the Sprint 2019/12 (Monitor and Conquer) board.
Feb 15 2020, 8:18 PM · Sprint 2019/12 (Monitor and Conquer), System administration, Metrics/monitoring
vlorentz moved T2238: Configure Sentry environments from Backlog to deployed on the Sprint 2019/12 (Monitor and Conquer) board.
Feb 15 2020, 8:18 PM · Sprint 2019/12 (Monitor and Conquer)
vlorentz moved T2181: Set SWH_MAIN_PACKAGE and SWH_SENTRY_ENVIRONMENT for all services from Backlog to deployed on the Sprint 2019/12 (Monitor and Conquer) board.
Feb 15 2020, 8:18 PM · Metrics/monitoring, Sprint 2019/12 (Monitor and Conquer), System administration
vlorentz added inline comments to D2667: apidoc: Add bullet list support in input/output data documentation.
Feb 15 2020, 11:07 AM
vlorentz accepted D2665: apidoc: Generate a dedicated doc view for each decorated endpoint.
Feb 15 2020, 11:04 AM

Feb 14 2020

vlorentz updated the diff for D2678: Use iso8601.parse_date instead of dateutil.parser.parse..

fix naive datetime support

Feb 14 2020, 7:36 PM
vlorentz updated the diff for D2675: Add extra_type_encoders and extra_type_decoders attributes to RPC clients and servers..

add tests.

Feb 14 2020, 7:02 PM
vlorentz accepted D2668: api/identifiers: Add /known/ endpoint documentation.
Feb 14 2020, 6:39 PM
vlorentz accepted D2679: apidoc: Simplify HTTP methods extraction from docstrings.
Feb 14 2020, 6:39 PM
vlorentz planned changes to D2678: Use iso8601.parse_date instead of dateutil.parser.parse..
Feb 14 2020, 6:24 PM
vlorentz created D2678: Use iso8601.parse_date instead of dateutil.parser.parse..
Feb 14 2020, 6:21 PM
vlorentz updated the diff for D2664: Make storage proxies use swh-model objects instead of dicts..

add type

Feb 14 2020, 6:13 PM
vlorentz created D2677: Add method BaseModel.hashes()..
Feb 14 2020, 6:07 PM
vlorentz added a comment to D2664: Make storage proxies use swh-model objects instead of dicts..

T2287

Feb 14 2020, 6:05 PM
vlorentz triaged T2287: Improve code in BufferingProxyStorage as Normal priority.
Feb 14 2020, 6:02 PM · Easy hack, Storage manager
vlorentz updated the diff for D2662: Fix inconsistent behavior of skipped_content_missing across backends..

apply comments

Feb 14 2020, 5:49 PM
vlorentz created D2676: Add support for (de)serializing swh-model in RPC calls..
Feb 14 2020, 5:26 PM
vlorentz updated the diff for D2675: Add extra_type_encoders and extra_type_decoders attributes to RPC clients and servers..

fix type

Feb 14 2020, 5:26 PM
vlorentz created D2675: Add extra_type_encoders and extra_type_decoders attributes to RPC clients and servers..
Feb 14 2020, 5:21 PM
vlorentz requested changes to D2674: Force recooking of an object when previous vault task failed.
Feb 14 2020, 5:13 PM
vlorentz added a comment to D2663: Fix FilteringProxy to not drop skipped-contents with a missing sha1_git..
In D2663#63709, @olasd wrote:

I guess this is the minimal step to unbreak the logic

Feb 14 2020, 5:11 PM
vlorentz committed rDWAPPScd078c62521c: Fix URL for non-metadata search. (authored by vlorentz).
Fix URL for non-metadata search.
Feb 14 2020, 4:21 PM
vlorentz closed D2673: Fix URL for non-metadata search..
Feb 14 2020, 4:21 PM
vlorentz created D2673: Fix URL for non-metadata search..
Feb 14 2020, 4:19 PM
vlorentz committed rDWAPPSeb081d9cab51: Fix URL of metadata search. (authored by vlorentz).
Fix URL of metadata search.
Feb 14 2020, 4:16 PM
vlorentz closed D2670: Fix URL of metadata search..
Feb 14 2020, 4:16 PM
vlorentz created D2672: Add support for extra {de,en}coders..
Feb 14 2020, 4:16 PM
vlorentz created D2671: Change msgpack serialization to be closer to the JSON one..
Feb 14 2020, 4:14 PM
vlorentz triaged T2286: Use proper URL building in origin-search.js as Low priority.
Feb 14 2020, 4:00 PM · Easy hack, Web app
vlorentz created D2670: Fix URL of metadata search..
Feb 14 2020, 3:58 PM
vlorentz triaged T2285: Add frontend test for metadata search as Normal priority.
Feb 14 2020, 3:57 PM · Easy hack, Web app
vlorentz committed rDSTO03c2a021c0d6: Re-raise StorageArgumentException through API calls. (authored by vlorentz).
Re-raise StorageArgumentException through API calls.
Feb 14 2020, 1:27 PM
vlorentz closed D2630: Re-raise StorageArgumentException through API calls..
Feb 14 2020, 1:27 PM
vlorentz committed rDCORE08289ce5c33e: In case of errors, return a simple dictionary instead of pickled exception. (authored by vlorentz).
In case of errors, return a simple dictionary instead of pickled exception.
Feb 14 2020, 12:22 PM
vlorentz closed D2627: In case of errors, return a simple dictionary instead of pickled exception..
Feb 14 2020, 12:22 PM
vlorentz updated the diff for D2627: In case of errors, return a simple dictionary instead of pickled exception..

rebase

Feb 14 2020, 12:21 PM
vlorentz accepted D2661: Web API: /known/ input size limit.
Feb 14 2020, 12:08 PM
vlorentz requested changes to D2669: Add ?limit=N method variants to return first N results.

@zack @seirl Could either of you have a look too?

Feb 14 2020, 10:39 AM
vlorentz requested changes to D2668: api/identifiers: Add /known/ endpoint documentation.
Feb 14 2020, 10:30 AM
vlorentz requested changes to D2667: apidoc: Add bullet list support in input/output data documentation.
Feb 14 2020, 10:27 AM
vlorentz accepted D2666: apidoc: Add support for request data documentation.
Feb 14 2020, 10:20 AM
vlorentz added a comment to D2665: apidoc: Generate a dedicated doc view for each decorated endpoint.

As noargs and post_only have the same effect, what about using a single argument for both, that signals a new view should be created?

Feb 14 2020, 10:19 AM

Feb 12 2020

vlorentz committed rDJNL038418a63b70: Use swh-storage validation proxy. (authored by vlorentz).
Use swh-storage validation proxy.
Feb 12 2020, 4:58 PM
vlorentz closed D2658: Use swh-storage validation proxy in swh-journal.
Feb 12 2020, 4:58 PM
vlorentz updated the diff for D2630: Re-raise StorageArgumentException through API calls..

rebase

Feb 12 2020, 4:51 PM
vlorentz created D2664: Make storage proxies use swh-model objects instead of dicts..
Feb 12 2020, 4:49 PM
vlorentz created D2663: Fix FilteringProxy to not drop skipped-contents with a missing sha1_git..
Feb 12 2020, 4:18 PM
vlorentz added inline comments to D2661: Web API: /known/ input size limit.
Feb 12 2020, 4:11 PM
vlorentz created D2662: Fix inconsistent behavior of skipped_content_missing across backends..
Feb 12 2020, 4:09 PM
vlorentz added inline comments to D2661: Web API: /known/ input size limit.
Feb 12 2020, 3:43 PM
vlorentz requested changes to D2661: Web API: /known/ input size limit.
Feb 12 2020, 3:33 PM
vlorentz added a comment to D2661: Web API: /known/ input size limit.

Don't worry about the test failures, they are not related to your changes. I just restarted them.

Feb 12 2020, 3:31 PM
vlorentz added a comment to D2660: Adding 'Add Origin info' checkbox which was missing.

I fixed the build issue in master, and retriggered the builds of this diff. The errors should disappear.

Feb 12 2020, 3:30 PM
vlorentz committed rDWAPPS799044ff0144: Use swh-storage validation proxy. (authored by vlorentz).
Use swh-storage validation proxy.
Feb 12 2020, 3:29 PM
vlorentz closed D2647: Use swh-storage validation proxy..
Feb 12 2020, 3:29 PM
vlorentz added a comment to D2660: Adding 'Add Origin info' checkbox which was missing.

Don't worry about the build failure, it's temporary and not related to your changes

Feb 12 2020, 3:06 PM
vlorentz added a comment to D2660: Adding 'Add Origin info' checkbox which was missing.

Could you add a test for this, to prevent regressions in the future?

Feb 12 2020, 2:52 PM
vlorentz abandoned D2353: keywords and software requirements as string arrays.
Feb 12 2020, 2:41 PM
vlorentz commandeered D2353: keywords and software requirements as string arrays.
Feb 12 2020, 2:41 PM
vlorentz closed D2656: Use swh-storage validation proxy in indexer test.
Feb 12 2020, 2:30 PM
vlorentz committed rDCIDX97710c97d208: Use swh-storage validation proxy. (authored by vlorentz).
Use swh-storage validation proxy.
Feb 12 2020, 2:30 PM
vlorentz committed rDLDSVN40508cea03fd: Use swh-storage validation proxy. (authored by vlorentz).
Use swh-storage validation proxy.
Feb 12 2020, 2:30 PM
vlorentz closed D2655: Use swh-storage validation proxy in svn loader tests.
Feb 12 2020, 2:30 PM
vlorentz committed rDLDHGf7c0a70dfe84: Use swh-storage validation proxy. (authored by vlorentz).
Use swh-storage validation proxy.
Feb 12 2020, 2:30 PM
vlorentz closed D2654: Use swh-storage validation proxy in hg loader tests.
Feb 12 2020, 2:30 PM
vlorentz committed rDLDGaca4575e1995: Use swh-storage validation proxy. (authored by vlorentz).
Use swh-storage validation proxy.
Feb 12 2020, 2:30 PM
vlorentz closed D2653: Use swh-storage validation proxy in git loader tests.
Feb 12 2020, 2:30 PM
vlorentz closed D2652: Use swh-storage validation proxy in loader-core test.
Feb 12 2020, 2:30 PM
vlorentz committed rDLDBASE0378cc0da63a: Use swh-storage validation proxy. (authored by vlorentz).
Use swh-storage validation proxy.
Feb 12 2020, 2:30 PM
vlorentz committed rDVAU4c60d24b4a94: Use swh-storage validation proxy. (authored by vlorentz).
Use swh-storage validation proxy.
Feb 12 2020, 2:29 PM
vlorentz closed D2649: Use swh-storage validation proxy in vault tests.
Feb 12 2020, 2:29 PM
vlorentz committed rDSCHb92e3fd0b2bd: Use swh-storage validation proxy. (authored by vlorentz).
Use swh-storage validation proxy.
Feb 12 2020, 2:29 PM
vlorentz closed D2659: Use swh-storage validation proxy in scheduler.
Feb 12 2020, 2:29 PM
vlorentz retitled D2659: Use swh-storage validation proxy in scheduler from Use swh-storage validation proxy. to Use swh-storage validation proxy in scheduler.
Feb 12 2020, 2:29 PM
vlorentz updated the diff for D2656: Use swh-storage validation proxy in indexer test.

rebase

Feb 12 2020, 2:28 PM
vlorentz committed rDCIDX5783b730645f: Fix type errors with hypothesis 5.5 (authored by vlorentz).
Fix type errors with hypothesis 5.5
Feb 12 2020, 2:27 PM
vlorentz updated the diff for D2647: Use swh-storage validation proxy..

rebase

Feb 12 2020, 2:21 PM
vlorentz created D2659: Use swh-storage validation proxy in scheduler.
Feb 12 2020, 1:48 PM
vlorentz created D2658: Use swh-storage validation proxy in swh-journal.
Feb 12 2020, 1:46 PM
vlorentz requested changes to D2657: code scanner prototype.

I'm missing context on what this code scanner does, so I'm only commenting on documentation for now.

Feb 12 2020, 12:27 PM

Feb 11 2020

vlorentz created D2656: Use swh-storage validation proxy in indexer test.
Feb 11 2020, 6:37 PM
vlorentz retitled D2655: Use swh-storage validation proxy in svn loader tests from Use swh-storage validation proxy. to Use swh-storage validation proxy in svn loader tests.
Feb 11 2020, 6:34 PM
vlorentz retitled D2654: Use swh-storage validation proxy in hg loader tests from Use swh-storage validation proxy. to Use swh-storage validation proxy in hg loader tests.
Feb 11 2020, 6:33 PM
vlorentz retitled D2653: Use swh-storage validation proxy in git loader tests from Use swh-storage validation proxy. to Use swh-storage validation proxy in git loader tests.
Feb 11 2020, 6:33 PM
vlorentz retitled D2652: Use swh-storage validation proxy in loader-core test from Use swh-storage validation proxy. to Use swh-storage validation proxy in loader-core test.
Feb 11 2020, 6:33 PM
vlorentz retitled D2649: Use swh-storage validation proxy in vault tests from Use swh-storage validation proxy. to Use swh-storage validation proxy in vault tests.
Feb 11 2020, 6:33 PM
vlorentz created D2655: Use swh-storage validation proxy in svn loader tests.
Feb 11 2020, 6:33 PM
vlorentz created D2654: Use swh-storage validation proxy in hg loader tests.
Feb 11 2020, 6:30 PM
vlorentz created D2653: Use swh-storage validation proxy in git loader tests.
Feb 11 2020, 6:28 PM
vlorentz created D2652: Use swh-storage validation proxy in loader-core test.
Feb 11 2020, 6:22 PM
vlorentz committed rDLDBASE9524158bcede: Add missing __init__.py and fix tests. (authored by vlorentz).
Add missing __init__.py and fix tests.
Feb 11 2020, 6:21 PM