Rebase on latest master
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jul 9 2020
- Open safelist parameter to allow some objects to be unchecked
- Override check-snapshot for the test_nixguix so tests are fine (using that safelist parameter)
- Improve reported message when failing the assertions so we know what branch and target is reported missing
Looks good.
The good news is that it's getting cleaner ;)
(build currently fails because some loaders inserts incomplete data apparently)
Rebase on latest master
Rebase on latest master
Looks good one question about the tox.ini above.
Thanks.
Fix forgotten f-string f prefix ¯\_(ツ)_/¯
Adapt according to good remark, make DATA and ENCODED_DATA constants (no need
for a pytest fixture indeed)
Rebase on latest master
Improvments
Note: status uneventful with a different snapshot is kinda unexpected for me. Not something drastically problematic though. I'll dig in at some point.
what docstring?
Adapt according to remarks:
- Update docstring
- use the pytest_fixtures definition ourselves
You also need to add that line to your own conftest.py if you're depending on that fixture.
@ardumont , https://archive.softwareheritage.org/api/1/snapshot/869153d018394df0b75789134d87992eb2353bd4/ says this particular snapshot could not be found. Am I missing something?
Second run btw (forgot to hit enter a while back):
Jul 07 12:10:49 worker2 python3[475116]: [2020-07-07 12:10:49,714: INFO/ForkPoolWorker-1] Task swh.loader.package.nixguix.tasks.LoadNixguix[082dd536-6294-421a-881e-e0bf28e94e0b] succeeded in 4497.450984489056s: {'status': 'uneventful', 'snapshot_id': 'ae96e93d0e24fb4ec484d56109c669da0b267908'}
Jul 8 2020
sounds fair
Rebase on latest master
Simplify as proposed ;)
ok then ;)
oh right!
Build has failed
with extra_heades now being an attribute of the Revision entity.
Adapt according to review (concat blackified strings)
Rebase
And it fixes the build ;) [1]
Ideally we should refactor those entirely.
Adapt according to remark