Page MenuHomeSoftware Heritage
Feed Advanced Search

Jul 9 2020

ardumont updated the test plan for D3475: setup: Do no expose the pytest-plugin any longer.
Jul 9 2020, 6:37 PM
ardumont accepted D3487: Clean up the swh.scheduler / swh.storage pytest plugin imports.
Jul 9 2020, 6:35 PM
ardumont updated the diff for D3475: setup: Do no expose the pytest-plugin any longer.

Rebase on latest master

Jul 9 2020, 6:34 PM
ardumont abandoned D3479: Require explicitely the dependencies on storage fixtures.
Jul 9 2020, 6:33 PM
ardumont accepted D3486: Clean up the swh.scheduler / swh.storage pytest plugin imports.
Jul 9 2020, 6:33 PM
ardumont updated the test plan for D3478: loader.core: Make check_snapshot ensure snapshot object references exist.
Jul 9 2020, 6:28 PM
ardumont updated the diff for D3478: loader.core: Make check_snapshot ensure snapshot object references exist.
  • Open safelist parameter to allow some objects to be unchecked
  • Override check-snapshot for the test_nixguix so tests are fine (using that safelist parameter)
  • Improve reported message when failing the assertions so we know what branch and target is reported missing
Jul 9 2020, 6:28 PM
ardumont accepted D3484: in_memory: Fix quadratic run time in snapshot_get_branches..

Looks good.

Jul 9 2020, 6:16 PM
ardumont accepted D3485: Remove overhead of to_dict/from_dict in test_snapshot_large..
Jul 9 2020, 6:14 PM
ardumont accepted D3483: Clean up the swh.scheduler / swh.storage pytest plugin imports.

The good news is that it's getting cleaner ;)

Jul 9 2020, 5:57 PM
ardumont added a comment to D3478: loader.core: Make check_snapshot ensure snapshot object references exist.

(build currently fails because some loaders inserts incomplete data apparently)

Jul 9 2020, 5:56 PM
ardumont updated the test plan for D3478: loader.core: Make check_snapshot ensure snapshot object references exist.
Jul 9 2020, 5:47 PM
ardumont updated the test plan for D3478: loader.core: Make check_snapshot ensure snapshot object references exist.
Jul 9 2020, 5:43 PM
ardumont accepted D3482: Clean up the swh.scheduler / swh.storage pytest plugin imports.
Jul 9 2020, 5:42 PM
ardumont updated the diff for D3478: loader.core: Make check_snapshot ensure snapshot object references exist.

Rebase on latest master

Jul 9 2020, 5:40 PM
ardumont updated the diff for D3473: loader.core: check_snapshot: Allow to check using both Snapshot and dict objects.

Rebase on latest master

Jul 9 2020, 5:37 PM
ardumont accepted D3481: Clean up the swh.scheduler / swh.storage pytest plugin imports.

Looks good one question about the tox.ini above.

Jul 9 2020, 5:32 PM
ardumont added inline comments to D3480: Use the new names for the swh.scheduler test fixtures.
Jul 9 2020, 5:30 PM
ardumont added inline comments to D3480: Use the new names for the swh.scheduler test fixtures.
Jul 9 2020, 5:29 PM
ardumont added inline comments to D3480: Use the new names for the swh.scheduler test fixtures.
Jul 9 2020, 5:27 PM
ardumont accepted D3480: Use the new names for the swh.scheduler test fixtures.

Thanks.

Jul 9 2020, 5:24 PM
ardumont committed rDDEP6b175aec0bef: tests.conftest: Fix type ignore warning (authored by ardumont).
tests.conftest: Fix type ignore warning
Jul 9 2020, 4:43 PM
ardumont updated the summary of D3475: setup: Do no expose the pytest-plugin any longer.
Jul 9 2020, 4:33 PM
ardumont added inline comments to D3479: Require explicitely the dependencies on storage fixtures.
Jul 9 2020, 4:31 PM
ardumont created D3479: Require explicitely the dependencies on storage fixtures.
Jul 9 2020, 4:28 PM
ardumont committed rDLDHG4dbf2c03f237: tests.conftest: Fix type ignore warning (authored by ardumont).
tests.conftest: Fix type ignore warning
Jul 9 2020, 4:26 PM
ardumont created D3478: loader.core: Make check_snapshot ensure snapshot object references exist.
Jul 9 2020, 4:17 PM
ardumont added a revision to T2483: tests: Make check-snapshot utility test function recursively check targetted object exists: D3478: loader.core: Make check_snapshot ensure snapshot object references exist.
Jul 9 2020, 4:17 PM · SVN Loader, Mercurial loader, Git loader, Core Loader
ardumont created P722 new serialization issue kombu/celery.
Jul 9 2020, 4:13 PM
ardumont updated the summary of D3475: setup: Do no expose the pytest-plugin any longer.
Jul 9 2020, 3:52 PM
ardumont updated the diff for D3473: loader.core: check_snapshot: Allow to check using both Snapshot and dict objects.

Fix forgotten f-string f prefix ¯\_(ツ)_/¯

Jul 9 2020, 3:02 PM
ardumont added inline comments to D3473: loader.core: check_snapshot: Allow to check using both Snapshot and dict objects.
Jul 9 2020, 2:57 PM
ardumont added inline comments to D3461: test_serializers: Refactor using pytest.
Jul 9 2020, 2:47 PM
ardumont updated the diff for D3461: test_serializers: Refactor using pytest.

Adapt according to good remark, make DATA and ENCODED_DATA constants (no need
for a pytest fixture indeed)

Jul 9 2020, 2:43 PM
ardumont updated the diff for D3475: setup: Do no expose the pytest-plugin any longer.

Rebase on latest master

Jul 9 2020, 2:38 PM
ardumont updated the summary of D3473: loader.core: check_snapshot: Allow to check using both Snapshot and dict objects.
Jul 9 2020, 2:34 PM
ardumont updated the diff for D3473: loader.core: check_snapshot: Allow to check using both Snapshot and dict objects.

Improvments

Jul 9 2020, 2:34 PM
ardumont added a comment to T2485: staging: Running nixguix on guix sources .

Note: status uneventful with a different snapshot is kinda unexpected for me. Not something drastically problematic though. I'll dig in at some point.

Jul 9 2020, 2:27 PM · Archive coverage
ardumont updated the summary of D3475: setup: Do no expose the pytest-plugin any longer.
Jul 9 2020, 10:44 AM
ardumont added a comment to D3475: setup: Do no expose the pytest-plugin any longer.

what docstring?

Jul 9 2020, 10:44 AM
ardumont updated the diff for D3475: setup: Do no expose the pytest-plugin any longer.

Adapt according to remarks:

  • Update docstring
  • use the pytest_fixtures definition ourselves
Jul 9 2020, 10:41 AM
ardumont updated the summary of D3475: setup: Do no expose the pytest-plugin any longer.
Jul 9 2020, 10:37 AM
ardumont added a comment to D3475: setup: Do no expose the pytest-plugin any longer.

You also need to add that line to your own conftest.py if you're depending on that fixture.

Jul 9 2020, 10:37 AM
ardumont created D3475: setup: Do no expose the pytest-plugin any longer.
Jul 9 2020, 10:22 AM
ardumont added a revision to T2484: Move sharable fixtures out of conftest into a dedicated pytest plugin: D3475: setup: Do no expose the pytest-plugin any longer.
Jul 9 2020, 10:22 AM · SVN Loader, Mercurial loader, Git loader, Core Loader
ardumont added a comment to T2485: staging: Running nixguix on guix sources .

@ardumont , https://archive.softwareheritage.org/api/1/snapshot/869153d018394df0b75789134d87992eb2353bd4/ says this particular snapshot could not be found. Am I missing something?

Jul 9 2020, 10:19 AM · Archive coverage
ardumont added a comment to T2485: staging: Running nixguix on guix sources .

Second run btw (forgot to hit enter a while back):

Jul 07 12:10:49 worker2 python3[475116]: [2020-07-07 12:10:49,714: INFO/ForkPoolWorker-1] Task swh.loader.package.nixguix.tasks.LoadNixguix[082dd536-6294-421a-881e-e0bf28e94e0b] succeeded in 4497.450984489056s: {'status': 'uneventful', 'snapshot_id': 'ae96e93d0e24fb4ec484d56109c669da0b267908'}
Jul 9 2020, 10:18 AM · Archive coverage
ardumont committed rDLDBASE39ffcde65768: test_init: Use swh_storage fixture (authored by ardumont).
test_init: Use swh_storage fixture
Jul 9 2020, 9:28 AM
ardumont closed D3468: test_init: Use swh_storage fixture.
Jul 9 2020, 9:28 AM

Jul 8 2020

ardumont accepted D3474: pytest.ini: Prevent swh-storage pytest plugin loading.
Jul 8 2020, 6:58 PM
ardumont added a comment to D3474: pytest.ini: Prevent swh-storage pytest plugin loading.

sounds fair

Jul 8 2020, 6:58 PM
ardumont added inline comments to D3473: loader.core: check_snapshot: Allow to check using both Snapshot and dict objects.
Jul 8 2020, 6:45 PM
ardumont added inline comments to D3473: loader.core: check_snapshot: Allow to check using both Snapshot and dict objects.
Jul 8 2020, 6:42 PM
ardumont updated the summary of D3473: loader.core: check_snapshot: Allow to check using both Snapshot and dict objects.
Jul 8 2020, 6:41 PM
ardumont added a revision to T2483: tests: Make check-snapshot utility test function recursively check targetted object exists: D3473: loader.core: check_snapshot: Allow to check using both Snapshot and dict objects.
Jul 8 2020, 6:40 PM · SVN Loader, Mercurial loader, Git loader, Core Loader
ardumont created D3473: loader.core: check_snapshot: Allow to check using both Snapshot and dict objects.
Jul 8 2020, 6:40 PM
ardumont updated the diff for D3468: test_init: Use swh_storage fixture.

Rebase on latest master

Jul 8 2020, 6:34 PM
ardumont committed rDLDBASE6dc3da1580d9: Update the revision metadata field as an immutable dict (authored by ardumont).
Update the revision metadata field as an immutable dict
Jul 8 2020, 6:32 PM
ardumont closed D3471: Update the revision metadata field as an immutable dict.
Jul 8 2020, 6:32 PM
ardumont updated the diff for D3471: Update the revision metadata field as an immutable dict.

Simplify as proposed ;)

Jul 8 2020, 6:25 PM
ardumont added inline comments to D3471: Update the revision metadata field as an immutable dict.
Jul 8 2020, 6:23 PM
ardumont accepted D3472: requirements.txt: Set future version to >= 0.16.0.

ok then ;)

Jul 8 2020, 6:16 PM
ardumont accepted D3470: debian: Add pybuild.testfiles fixing tests execution in package build.

oh right!

Jul 8 2020, 6:13 PM
ardumont updated the summary of D3471: Update the revision metadata field as an immutable dict.
Jul 8 2020, 6:12 PM
ardumont created D3471: Update the revision metadata field as an immutable dict.
Jul 8 2020, 6:12 PM
ardumont accepted D3465: identifiers: Add to_dict method to SWHID class.
Jul 8 2020, 5:05 PM
ardumont accepted D3467: api/identifiers: Adapt to swh-model >= 0.5.0.
Jul 8 2020, 5:04 PM
ardumont added a revision to T2481: Migrate dvcs loader tests code to pytest: D3468: test_init: Use swh_storage fixture.
Jul 8 2020, 4:52 PM · SVN Loader, Mercurial loader, Git loader, Core Loader
ardumont created D3468: test_init: Use swh_storage fixture.
Jul 8 2020, 4:52 PM
ardumont closed T2484: Move sharable fixtures out of conftest into a dedicated pytest plugin, a subtask of T2481: Migrate dvcs loader tests code to pytest, as Resolved.
Jul 8 2020, 4:51 PM · SVN Loader, Mercurial loader, Git loader, Core Loader
ardumont closed T2484: Move sharable fixtures out of conftest into a dedicated pytest plugin as Resolved.
Jul 8 2020, 4:51 PM · SVN Loader, Mercurial loader, Git loader, Core Loader
ardumont added a comment to D3466: Migrate from vcversioner to setuptools-scm.

Build has failed

Jul 8 2020, 4:50 PM
ardumont planned changes to D3466: Migrate from vcversioner to setuptools-scm.
Jul 8 2020, 4:48 PM
ardumont added a revision to T2105: Migrate from vcversioner to setuptools-scm: D3466: Migrate from vcversioner to setuptools-scm.
Jul 8 2020, 4:45 PM · Development environment
ardumont created D3466: Migrate from vcversioner to setuptools-scm.
Jul 8 2020, 4:45 PM
ardumont added a comment to D3464: Update the svn loader to new Revision API.

with extra_heades now being an attribute of the Revision entity.

Jul 8 2020, 4:10 PM
ardumont accepted D3464: Update the svn loader to new Revision API.
Jul 8 2020, 4:09 PM
ardumont committed rDCORE0f62f75eb46e: Migrate from vcversioner to setuptools-scm (authored by ardumont).
Migrate from vcversioner to setuptools-scm
Jul 8 2020, 3:43 PM
ardumont closed D3462: Migrate from vcversioner to setuptools-scm.
Jul 8 2020, 3:43 PM
ardumont updated the diff for D3461: test_serializers: Refactor using pytest.

Adapt according to review (concat blackified strings)

Jul 8 2020, 3:43 PM
ardumont added inline comments to D3461: test_serializers: Refactor using pytest.
Jul 8 2020, 3:42 PM
ardumont updated the diff for D3462: Migrate from vcversioner to setuptools-scm.

Rebase

Jul 8 2020, 3:41 PM
ardumont accepted D3463: loader: Adapt to swh-model >= 0.4.0.

And it fixes the build ;) [1]

Jul 8 2020, 3:38 PM
ardumont added a revision to T2105: Migrate from vcversioner to setuptools-scm: D3462: Migrate from vcversioner to setuptools-scm.
Jul 8 2020, 3:29 PM · Development environment
ardumont created D3462: Migrate from vcversioner to setuptools-scm.
Jul 8 2020, 3:29 PM
ardumont updated the summary of D3461: test_serializers: Refactor using pytest.
Jul 8 2020, 3:27 PM
ardumont added a comment to D3460: test_serializers: Move to pytest for that specific erratic assertion.

Ideally we should refactor those entirely.

Jul 8 2020, 3:25 PM
ardumont created D3461: test_serializers: Refactor using pytest.
Jul 8 2020, 3:24 PM
ardumont committed rDLDBASE488b515a1c87: tests: Use dedicated storage and scheduler fixtures (authored by ardumont).
tests: Use dedicated storage and scheduler fixtures
Jul 8 2020, 3:19 PM
ardumont closed D3453: tests: Use dedicated storage and scheduler fixtures.
Jul 8 2020, 3:19 PM
ardumont committed rDSTO7fef9a384a44: d/changelog: Bump new release (authored by ardumont).
d/changelog: Bump new release
Jul 8 2020, 3:01 PM
ardumont committed rDSTOdc1368779e3b: d/control: Add missing runtime dependency (authored by ardumont).
d/control: Add missing runtime dependency
Jul 8 2020, 3:01 PM
ardumont added inline comments to D3453: tests: Use dedicated storage and scheduler fixtures.
Jul 8 2020, 2:58 PM
ardumont updated the test plan for D3453: tests: Use dedicated storage and scheduler fixtures.
Jul 8 2020, 2:51 PM
ardumont added inline comments to D3453: tests: Use dedicated storage and scheduler fixtures.
Jul 8 2020, 2:51 PM
ardumont updated the diff for D3453: tests: Use dedicated storage and scheduler fixtures.

Adapt according to remark

Jul 8 2020, 2:46 PM
ardumont retitled D3453: tests: Use dedicated storage and scheduler fixtures from tests: Use dedicated storage fixture to tests: Use dedicated storage and scheduler fixtures.
Jul 8 2020, 2:34 PM
ardumont added inline comments to D3453: tests: Use dedicated storage and scheduler fixtures.
Jul 8 2020, 2:30 PM
ardumont added inline comments to D3453: tests: Use dedicated storage and scheduler fixtures.
Jul 8 2020, 2:29 PM
ardumont committed rDCORE737b21d3dd66: test_serializers: Move to pytest for that specific erratic assertion (authored by ardumont).
test_serializers: Move to pytest for that specific erratic assertion
Jul 8 2020, 1:38 PM