Could you explain why using loglevels would not work? It feels to me they are meant to solve the problem of selecting the appropriate amount of debug messages… Having a separate flag introduce quite some extra noise in the process.
Nov 29 2022
See D8894 for an alternative implementation.
Nov 28 2022
Nov 21 2022
The second part looks good to me. :)
Review the first part.
Nov 17 2022
Nov 16 2022
After discussing D8833 and discussing the general API with @olasd, it feels like adding a delete method to swh.journal.writer.interface.JournalWriterInterface is the wrong approach. To try to capture our discussion
Nov 15 2022
Nov 14 2022
Fix the issue by adding a level of indirection in the yaml (replacing the job
by an identical job-template, and instantiating it through a project).
It seems jinja2 templates aren't actually supported in direct job definitions,
only in job templates. Thanks to olasd for finding this out and suggesting a fix.
Nov 10 2022
Nov 7 2022
Oct 25 2022
Oct 24 2022
with the same idea as the inline comment, it would be better to rename the network like 'swh-mirror' rather than 'swhtest-mirror'.
- Rename swhtest-mirror network to swh-mirror
- Re-add monitoring nodes to the required services to run the tests
- Add missing label to troubleshooting section
Oct 18 2022
Oct 17 2022
Oct 13 2022
I have missed updating tests/README.md which currently mentions testinfra. I should make the change if the rest of these changes are accepted.
Use the template appropriately to run the Docker agent
Oct 12 2022
Add two more commits required for predictable runs in Jenkins:
- Remove the uneeded tree_sitter from build system dependencies.
- Remove some leftover breakpoints.
Oct 6 2022
Adjust wait_services_status() for a race condition
Oct 5 2022
Oct 3 2022
Have the log instruction perform the formatting intead of using f-strings
Sep 29 2022
Sep 27 2022
Sep 26 2022
It would do nicely. Thanks! :)
Sep 19 2022
Sep 15 2022
Fix the typos spotted by ardumont