Build is green

Drop unnecessary default configuration about log_db

Build is green

Fix and add tests about edge case (no default config provided during read call)

All swh modules updated with the runtime requirements stanza.
Documentation updated as well.

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/304/ for more details.

In T1499#27578, @douardda wrote:

Note that I've modified the original file, so I'm not sure whether we should keep it (swh/core/api/negotiate.py) under its original MIT license (in which case the debian package's copyright file should be modified) or if we put it under the swh.core's LGPL one.

Note that I've modified the original file, so I'm not sure whether we should keep it (swh/core/api/negotiate.py) under its original MIT license (in which case the debian package's copyright file should be modified) or if we put it under the swh.core's LGPL one.

I agree we must be careful with not bloating swh.core, but the current subject, it really makes sense to me to put this basic db access wrapper as a core functionality.

as per discussion, we'd rather keep them self-contained than gain something out of code deduplication

Their content should be moved to swh.core.

You can add swh.indexer.storage.db.Db to your list.

I disagree with the characterization of the default config as bogus. The default configuration is expected to work without change on a "developer" environment (e.g. point to a remote storage listening on localhost:5002, and to the "-dev" variants of any needed local databases).

I disagree with the characterization of the default config as bogus. The default configuration is expected to work without change on a "developer" environment (e.g. point to a remote storage listening on localhost:5002, and to the "-dev" variants of any needed local databases).

It looks like we've moved on onto this, and settled for what we have.
We can reconsider in the future if specific needs arise.