Extra check for object type while returing directory and snapshot
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Aug 11 2022
Aug 11 2022
bug fix
Aug 10 2022
Aug 10 2022
doc string update
jayeshv retitled D8231: Add the possibility to search using a SWHID from WIP: Add the possibility to search using a SWHID to Add the possibility to search using a SWHID.
schema updates
Add functional tests
Aug 9 2022
Aug 9 2022
Aug 8 2022
Aug 8 2022
Aug 4 2022
Aug 4 2022
Jul 6 2022
Jul 6 2022
Not relevant anymore
jayeshv updated the task description for T4367: GraphQL: Pagination fixes to comply with the Relay spec.
In D8077#210155, @vlorentz wrote:Oh wait I get it. Doing a connection with n nodes costs c*n (for a constant c you implicitly decided to be 1), then fetching each of these nodes also costs n, so it's c*n+n.
Yeah that makes sense to me.
But there is also a per-node cost of 1, so that's the incensentive, right?
In D8077#210132, @vlorentz wrote:In D8077#210074, @jayeshv wrote:An issue I have is with calculating cost for connections. As of now, I have hard coded that to 2 for every connection. But I don't really like this.
Why?
Jul 5 2022
Jul 5 2022
In D8077#210071, @vlorentz wrote:These @cost directives will be ignored by parsers that don't support it, right?
jayeshv updated the task description for T4299: GraphQL: Static query validation and max cost limiting.
doc updates
jayeshv retitled D8077: Add a static query cost calculator to reject malicious quries from Add basic rate limiting to Add a basic query cost validator.
Commit message updates
Jul 4 2022
Jul 4 2022
jayeshv retitled D8077: Add a static query cost calculator to reject malicious quries from WIP: Add basic rate limiting to Add basic rate limiting.
functional tests
Remove multiplier for connections; set complexity to 2
cost for nodes
jayeshv updated the task description for T4299: GraphQL: Static query validation and max cost limiting.
Jul 1 2022
Jul 1 2022
jayeshv committed rDGQLe4d4a30b1f36: Add type annotations for base_connection (authored by jayeshv).
Add type annotations for base_connection
Address review comments
Add type annotation on _get_paged_result functions
jayeshv added a revision to T4261: Swh-graphql Code cleanup: D8065: Add type annotations for base_connection.
Jun 30 2022
Jun 30 2022
jayeshv renamed T4367: GraphQL: Pagination fixes to comply with the Relay spec from GraphQL: Fix issue in pagination to GraphQL: Fix issue in pagination 'after' argument.
jayeshv updated the task description for T4299: GraphQL: Static query validation and max cost limiting.
jayeshv updated the task description for T4309: GraphQL: Add missing target types in snapshot branch.
jayeshv closed T4308: GraphQL: Fix missing fields in Content object, a subtask of T4083: New public API (GraphQL + thin layer), as Resolved.
Jun 29 2022
Jun 29 2022
swhid search for contnet
release search with swhid
Swhid search for revision
Jun 28 2022
Jun 28 2022
doc strings update
basic control flow and docs
Jun 24 2022
Jun 24 2022
Refactoring: remove unnecessary code
Jun 23 2022
Jun 23 2022
basic working version
jayeshv committed rDGQLce677e0bdeba: Refactor snapshot branch functional tests (authored by jayeshv).
Refactor snapshot branch functional tests
Jun 22 2022
Jun 22 2022
Jun 20 2022
Jun 20 2022
This change is not required
Jun 17 2022
Jun 17 2022
Add utility function for building param string
Jun 16 2022
Jun 16 2022
jayeshv committed rDGQLed8d98201138: Fix the typo in union resolver test function name (authored by jayeshv).
Fix the typo in union resolver test function name
jayeshv committed rDGQL1bff0aa8725f: Add unit tests for snapshot branch target resolvers (authored by jayeshv).
Add unit tests for snapshot branch target resolvers
In D7994#207820, @ardumont wrote:"if you say so" ;)
jayeshv closed T4306: Use query variables instead of f-strings in swh-graphql tests, a subtask of T4261: Swh-graphql Code cleanup, as Resolved.
Remove unused utility functions
Jun 15 2022
Jun 15 2022
Adressing some review comments
Refactor origin node functional tests
rebase
jayeshv committed rDGQL66c55a2f30ce: Refactor origin connection functional tests (authored by jayeshv).
Refactor origin connection functional tests
adress review comments
rebase
building query params from a dict
Jun 14 2022
Jun 14 2022
jayeshv committed rDGQL2c457bf0bc7f: Use query variables instead of f-strings in functional tests (authored by jayeshv).
Use query variables instead of f-strings in functional tests
jayeshv committed rDGQL67e0bf737061: Add a test case to validate edge cursor in snapshot branch (authored by jayeshv).
Add a test case to validate edge cursor in snapshot branch
In D7980#207558, @douardda wrote:In D7980#207469, @anlambert wrote:In D7980#207468, @jayeshv wrote:In D7980#207464, @vlorentz wrote:Why should this be implemented by the API (as opposed to UIs)?
This is part of our current REST APIs.
which is not a good enough argument to keep it. Let's not reproduce (potential) mistakes, if we can.
I think it makes sense to return
data with or without a slash in both UI and API.I also agree, extra trailing slash or missing trailing slash in origin URL is a common source of errors when searching for an origin,
better handle that case API side.I disagree; one expect the API to behave as dumb/simple as possible: you ask for an origin URL, the API should return data on that very specific URL only. Imagine we do have stored both versions of the origin URL (for historical reasons), with and without a trailing /, we want the API to allow the user query one or the other.
If need be, provide an dedicated API endpoint to search for known similar origins, but make it a dedicated one, not part of the main get_origin endpoint.
As @vlorentz suggested, this "smart" behavior is indeed an UI concern, not an API one.