typo (thx ardumont)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Apr 15 2022
Apr 15 2022
douardda updated the diff for D7531: Regularly check for EOF in Client.process() while waiting for messages.
douardda added inline comments to D7531: Regularly check for EOF in Client.process() while waiting for messages.
douardda requested review of D7589: Add a --margin option to the `swh dataset graph export` command.
Apr 14 2022
Apr 14 2022
douardda added a comment to D7580: sentry: always override init settings with the environment variables.
lgtm, maybe add a comment in test_cli.py to justify the presence of forked over there
douardda committed rDSTOf136559bbdd7: User logger everywhere in tenacious.py (authored by douardda).
User logger everywhere in tenacious.py
Apr 13 2022
Apr 13 2022
Apr 12 2022
Apr 12 2022
lgtm
Apr 11 2022
Apr 11 2022
douardda committed rDMOD85f36f84347a: Add a SWH_MODEL_OBJECT_TYPES map {cls.objet_type: cls} in model.py (authored by douardda).
Add a SWH_MODEL_OBJECT_TYPES map {cls.objet_type: cls} in model.py
douardda updated the diff for D7536: Add a SWH_MODEL_OBJECT_TYPES map {cls.objet_type: cls} in model.py.
rebase
douardda updated the diff for D7536: Add a SWH_MODEL_OBJECT_TYPES map {cls.objet_type: cls} in model.py.
Add type annotation for SWH_MODEL_OBJECT_TYPES
douardda added inline comments to D7536: Add a SWH_MODEL_OBJECT_TYPES map {cls.objet_type: cls} in model.py.
Apr 8 2022
Apr 8 2022
douardda added inline comments to D7536: Add a SWH_MODEL_OBJECT_TYPES map {cls.objet_type: cls} in model.py.
douardda added inline comments to D7536: Add a SWH_MODEL_OBJECT_TYPES map {cls.objet_type: cls} in model.py.
douardda added inline comments to D7536: Add a SWH_MODEL_OBJECT_TYPES map {cls.objet_type: cls} in model.py.
douardda requested review of D7531: Regularly check for EOF in Client.process() while waiting for messages.
douardda requested review of D7536: Add a SWH_MODEL_OBJECT_TYPES map {cls.objet_type: cls} in model.py.
douardda committed rDDATASET18325cc8e78e: Reduce cli's loading time by moving import statements in commands (authored by douardda).
Reduce cli's loading time by moving import statements in commands
douardda added inline comments to D7519: Reduce cli's loading time by moving import statements in commands.
Apr 7 2022
Apr 7 2022
douardda requested review of D7519: Reduce cli's loading time by moving import statements in commands.
douardda committed rDDATASET9d97f0c0826d: Add support for blob in content export (authored by douardda).
Add support for blob in content export
rebase
Apr 6 2022
Apr 6 2022
As I said, I'm not completely enthusiastic by this code (especially the lack of flexibility and versatility to provision for other origin sources than git) but it's a nice start at least.
Thanks
douardda committed rDENVb4ddd00b694a: docker: make yarn run in the local copy of the swh-web source code (authored by douardda).
docker: make yarn run in the local copy of the swh-web source code
douardda committed rDDOC94533948188e: Update the debian local package building section (authored by douardda).
Update the debian local package building section
rebase
douardda updated the diff for D7493: docker: make yarn run in the local copy of the swh-web source code.
adapt code according to anlambert's suggestion
I think I'd prefer not to have 3 versions of almost the same function (corrupt_object_(get|grab_xxx) ).
Apr 5 2022
Apr 5 2022
lgtm but I'm not sure to understand what's at stake here.
specify aptitude is to be used only when needed (sic)
In D7039#194101, @ardumont wrote:Ping, what do we do with this diff?
In D7039#183041, @douardda wrote:In D7039#183023, @olasd wrote:You could add a list of useful third party repositories pulled from https://forge.softwareheritage.org/source/swh-jenkins-jobs/browse/master/jobs/templates/debian/gbp-buildpackage.groovy.j2$122-150
good thinking
typos (thx ardumont) + add a warning about db migration
In D7465#196093, @vlorentz wrote:LGTM, but we should eventually replace self.objstorage.get() with self.objstorage.get_batch(), it is much faster with the Azure backend (and hopefully more backends in the future, inc. Winery!)
Apr 4 2022
Apr 4 2022
douardda committed rDENV995e90739c3d: docker: add librdkakfa-dev so confluent-kafka in pip installable on non-x86… (authored by douardda).
docker: add librdkakfa-dev so confluent-kafka in pip installable on non-x86…
douardda updated the diff for D7493: docker: make yarn run in the local copy of the swh-web source code.
fix indentation and do only call 'yarn build-dev'
douardda committed rDSTOc6dc5cd3b58a: Make postgresql's Storage client options configurable from config (authored by douardda).
Make postgresql's Storage client options configurable from config
douardda updated the diff for D7473: Make postgresql's Storage client options configurable from config.
better docstring (thx olasd)
douardda updated the diff for D7473: Make postgresql's Storage client options configurable from config.
docstring
douardda added a comment to D7473: Make postgresql's Storage client options configurable from config.
In D7473#195294, @vlorentz wrote:Please add a docstring; it's unclear this is used by swh-core otherwise
douardda committed rDCORE2a2615357b07: Make db_transaction's client_options configurable at run time (authored by douardda).
Make db_transaction's client_options configurable at run time
In D7472#195801, @olasd wrote:The duplication between db_transaction and db_transaction_generator looks a bit silly, but I'm not sure there's much to do about it, so this lgtm, thanks.
douardda added inline comments to D7493: docker: make yarn run in the local copy of the swh-web source code.
douardda requested review of D7493: docker: make yarn run in the local copy of the swh-web source code.
douardda updated the diff for D7492: docker: add librdkakfa-dev so confluent-kafka in pip installable on non-x86 platforms.
wrong head...
Apr 1 2022
Apr 1 2022
Mar 31 2022
Mar 31 2022
rebase
douardda committed rDDATASET76eba6595bac: Keep each ORC table in a dedicated directory (authored by douardda).
Keep each ORC table in a dedicated directory
Mar 30 2022
Mar 30 2022
doubleticks
Merge all 4 added tests in a single paramtrized one
douardda added inline comments to D7472: Make db_transaction's client_options configurable at run time.
douardda requested review of D7473: Make postgresql's Storage client options configurable from config.
douardda committed rDDATASET58b9f92e1d4d: Improve the progress reporting look and feel (authored by douardda).
Improve the progress reporting look and feel
douardda committed rDDATASETbe3c5da2bb44: Delay the unsubscribe to the end of handle_messages (authored by douardda).
Delay the unsubscribe to the end of handle_messages
douardda committed rDDATASET3df08fd71759: Add support for limited row numbers in ORC files (authored by douardda).
Add support for limited row numbers in ORC files
douardda committed rDDATASETe01daba4d601: Move exporter config entries in dedicated sections (authored by douardda).
Move exporter config entries in dedicated sections
rebase
rebase
Add a comment
rebase
rebase
rebase
rebase
make it py37 compliant
rebase
rebase
rebase
rebase
check for max_rows validity at ORCExporter class instanciation + copyrights
douardda added inline comments to D7460: docker/build_image.sh: Add script to build/ push to docker registry.
Mar 29 2022
Mar 29 2022