I think you should add some tests checking the expected metrics are sent to statsd by mocking the statsd_timed method.
This will prevent possible regressions on that feature if the code of BaseLoader gets modified.

In D7721#201267, @vlorentz wrote:

Could you add that file in tests?

Add test for pom parsing failure

This is due to the history cache that does not support multiple requests, use this to make it compatible with the many case:

class AddForgeNowRequestSerializer(serializers.ModelSerializer):

That code is too hackish from my point of view, modifying internal private member of a class from the outside is never a good idea in programming.

Reference task in commit message

Rebase

Address @ardumont comments

Indeed some filtering could be added here based on user permission:

• if user has permission swh.web.mailmap, only the mailmaps he created should be displayed
• if user has permission swh.web.admin.mailmap, all mailmaps should be displayed

In D7710#200908, @ardumont wrote:

lgtm

one question inline.

From my point of view, there is still some improvements to bring to that diff and tests must be implemented to validate the feature.
I will do a deeper review once I have some time.

Rebase

In D7700#200559, @ardumont wrote:

I think those similar diffs can be pushed directly once jenkins agrees they build fine.

Update commit message title

In D7694#200395, @vlorentz wrote:

Thanks. Could you mention the behavior change in the commit/diff title?

Update commit message

Actually, I think it would make sense to keep it mandatory from Celery tasks; as visit dates when loading from disk should be the date the local git repo was downloaded, not the date it was loaded.

Restore parsing of visit_date parameter for from disk loader tasks

Remove unnamed arguments use in celery tasks

Remove *args, it's a footgun to allow unnamed arguments over the scheduler/Celery.

Update:

• Remove max_content_size parameter to loaders (already handled by BaseLoader class)
• Ensure to pass loader extra keyword parameters to base class constructor

@anirudhlakhotia, below are some hints about how to add the display of the last moderator name in the add forge requests admin dashboard:

• the purpose is to add a new field moderator_name in the data returned by the endpoint serving the data displayed by the databables
• in that code, page.object_list contains instances of AddForgeRequest django model (grep for it) to serialize and send for display with datatables
• to get the last moderator name, you need to get the list of AddForgeRequestHistory django models associated to each AddForgeRequest model to display (see that example to get the full history for a request) filtered by actor_role being MODERATOR
• as in our case we need to fetch history for multiple requests, you should be able to do that query in an efficient way using django queryset api
• once you get the moderators for each request, you need to insert a moderator_name field in the AddForgeRequest serialized data and display that new field in the datatables

Rebase