improve commit message

rebase

rebase

rebase

rebase and adapt to current master

rebase on current master

rebase

revert the wrong fix but make it depend on D5868 instead

add tests for dates < epoch and microseconds > 0...

please take care of not including unrelated changes in your revisions/diffs

docstring, annotation and better testing

There is still the if revision (RevisonEntry.parents) that needs a fix, otherwise ok.

I still disagree with some parts of this (the blob vs. blobid naming stuff, and more importantly the whole data dict being given as argument of insert_relation() when only one element of this dict is actually needed), but meh.

There are several comments that have not been addressed

I won't discuss more the file format for the tests, it's not that critical, but please remove the implementation of __hash__ methods if they are actually not needed, and simplify the code the the __eq__ as suggested.

Overall ok, but a few things:

• I don't think we need the __hash__ methods at all (unless you want to rewrite the __eq__ ones using hash comparison)
• we usually don't put print statement in tests
• I'd prefer the more explicit file format (see inline comments), then it does not really need to be documented in the README file (but the comment in the code needs to be removed)

I may have other comments to make, but definitely, I'd really prefer having 3 diffs here also...

Actually, I would have much preferred this diff to be 4 diffs also ;-)

rebase

rebase

rebase

rebase

In D5754#148712, @ardumont wrote:

David explained everything already. So you can close this diff and maybe mention the commit closing this at the same time in the comment.

oops, yes, sorry i read too fast. You pushed a remote branch.
You need to follow what david said (and now i'm stopping adding noise here).

In D5754#148709, @douardda wrote:

In D5754#148570, @borisbaldassari wrote:

In D5754#147866, @ardumont wrote:

By the way @borisbaldassari, you can push, that should land and close the diff ;)

Hum.. I pushed a couple of days ago and the diff is still open. I've probably done the wrong thing.

Changes were pushed to origin/T3334_tuleap_lister -- is that ok? should I do something else/more to automatically close the diff (and see the new lister on the master etc.)?

you probably rework your git history without updating the Diff, so phab wait for the revision it knows about to be merged in master (aka 04c0a50706e8 here), but if you modified it, another revision has been pushed in the main repo, and phab is not smart enough to detect it is actually an updated version of the diff that reached the git repo.

In D5754#148570, @borisbaldassari wrote:

In D5754#147866, @ardumont wrote:

By the way @borisbaldassari, you can push, that should land and close the diff ;)

Hum.. I pushed a couple of days ago and the diff is still open. I've probably done the wrong thing.

Changes were pushed to origin/T3334_tuleap_lister -- is that ok? should I do something else/more to automatically close the diff (and see the new lister on the master etc.)?

remove forgotten debugging stuff

rebase

lgtm

please rework your git history, not including revisions unrelated with this diff, etc.

rebase

please don't include the revisions about testing the isochrone graph (nor the merge, which should not be there at all, do rebase instead) in this diff, it is unrelated and should be in a dedicated diff.

rebas