cli run for the bitbucket lister, status ok:
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jan 28 2021
Jan 28 2021
vsellier changed the status of T3001: Webapp is not displaying the origin type on the search results from Open to Work in Progress.
cli run for the github instance, status ok:
DanSeraf committed rDTSCN5e01c09af4c6: retry request in case of backend failure (authored by DanSeraf).
retry request in case of backend failure
DanSeraf committed rDTSCNebad16c02da6: algo_min: remove the current node as well (authored by DanSeraf).
algo_min: remove the current node as well
ardumont committed rDLS72be074a795e: gitlab: Deal with missing or trailing / in url input (authored by ardumont).
gitlab: Deal with missing or trailing / in url input
Build is green
Rebase
ardumont committed rDLS3bede83d0f51: tox.ini: Work around build failure due to upstream release (authored by ardumont).
tox.ini: Work around build failure due to upstream release
yuck
yuck
Build has FAILED
ardumont added a project to T3000: Investigate scheduler journal client discrepancies: Scheduling utilities.
Status update, the main part of the scheduler journal client is done [1]. 98M origins
referenced in the cache table.
Build has FAILED
Harbormaster failed remote builds in B18830: Diff 17689 for D4957: gitlab: Deal with missing or trailing / in url input!
Build has FAILED
Adapt according to suggestions
- make it parametric on both case
- fix test
cli: Make cli work with new lister
Build is green
Rebase
Jan 27 2021
Jan 27 2021
Final version PIDApalooza
Harbormaster failed remote builds in B18827: Diff 17686 for D4958: cli: Make cli work with new lister...!
Build has FAILED
Harbormaster failed remote builds in B18826: Diff 17685 for D4957: gitlab: Deal with missing or trailing / in url input!
Build has FAILED
(for the test and the soon to be adapted, yes, my thoughts exactly ;)
ardumont retitled D4957: gitlab: Deal with missing or trailing / in url input from gitlab: Allow sysadm to forget the trailing / to gitlab: Deal with missing or trailing / in url input.
Use the right repository...
Thanks again!
gitlab instance deployed, status ok:
Legacy option should be removed soon so no tests needed here ;-)
Build is green
Adapt according to review
This would be cleaner to process the url in the lister constructor instead (same as in debian one).
This is a tryout to generate a global schema of the staging environment (P929):
swh-public-ci added a comment to D4936: deposit.cli: Warn users when missing origin tags are detected.
Build is green
Adapt according to review
ardumont added inline comments to D4936: deposit.cli: Warn users when missing origin tags are detected.
ardumont committed rDLScbd2cce33979: test_cli: Drop launchpad lister from the test_get_lister (authored by ardumont).
test_cli: Drop launchpad lister from the test_get_lister
ardumont committed rDLSb11b4d100186: launchpad: Actually mock the anonymous login to launchpad (authored by ardumont).
launchpad: Actually mock the anonymous login to launchpad
It seems to be ok :)
ardumont moved T2979: Port debian lister to the new Lister API from code review to done on the Sprint 2021 01 board.
Build is green
Drop unneeded requests_mock (at some point i wanted to use it)
anlambert changed the status of T2992: Port launchpad lister to the new Lister API from Open to Work in Progress.
anlambert changed the status of T2992: Port launchpad lister to the new Lister API, a subtask of T2442: Provide a unified API for listers to interact with the scheduler, from Open to Work in Progress.
In D4955#124737, @ardumont wrote:@anlambert, thanks, jsyk, i'm working on fixing failing test in the chroot debian in the end goal to deploy the listers in staging.
@anlambert, thanks, jsyk, i'm working on fixing failing test in the chroot debian in the end goal to deploy the listers in staging.
ardumont committed rDLS461bf0997317: Drop no longer swh.lister.core.{indexing,page_by_page}_lister (authored by ardumont).
Drop no longer swh.lister.core.{indexing,page_by_page}_lister
few requests, please:
- add tests with this commit; every introduced function should have at least one test.
- add doctrings to your new functions,
- improve the commit message (see https://chris.beams.io/posts/git-commit/ ); with the current one, I have no idea what exactly is done in this commit, and more importantly, why this is needed for.
Let's consider it as done.
tests: Drop unneeded reset instruction
douardda committed rDJNL9703864ef366: Remove tests' journal_data.py in favor of the version in swh-model (authored by douardda).
Remove tests' journal_data.py in favor of the version in swh-model
counters: batch redis calls
vsellier committed rDSNIPe1076146c645: counters: add local counter to follow the message count (authored by vsellier).
counters: add local counter to follow the message count
vsellier committed rDLSf6f9f1ca28a9: cgit: Don't stop the listing when a repository page is not available (authored by vsellier).
cgit: Don't stop the listing when a repository page is not available
vsellier added a comment to D4954: cgit: Don't stop the listing when a repository page is not available.
Thanks :)
Looks good !
swh-public-ci added a comment to D4954: cgit: Don't stop the listing when a repository page is not available.
Build is green
anlambert added a comment to D4954: cgit: Don't stop the listing when a repository page is not available.
In D4954#124699, @ardumont wrote:Less code to modify and easier to read and understand the intended behavior from my point of view.
maybe so.
One pro I see for your implementation is if at some point the main loop (get_pages)
fails to fetch something (which we don't currently expect to see the assert added
here), we'll have more information available in the log instead of an AssertionError.
We'll indeed have an actual HttpError with the status code and everything in the
stacktrace.All in all, i think you are right ;)