Page MenuHomeSoftware Heritage
Feed All Stories

Jul 3 2020

ardumont committed rDLDSVN5c46affea65d: Start tests with pytest refactoring: Add scenario for 1 visit (authored by ardumont).
Start tests with pytest refactoring: Add scenario for 1 visit
Jul 3 2020, 10:40 AM
ardumont closed D3397: loader.svn: Start tests refactoring with pytest.
Jul 3 2020, 10:40 AM
ardumont created D3403: loader-svn: tests: Refactor svn-eol-style scenario.
Jul 3 2020, 10:39 AM
ardumont added a revision to T2462: svn loader: Refactor tests using pytest fixtures: D3403: loader-svn: tests: Refactor svn-eol-style scenario.
Jul 3 2020, 10:39 AM · SVN Loader
swh-public-ci added a comment to D3397: loader.svn: Start tests refactoring with pytest.

Build is green

Jul 3 2020, 10:38 AM
ardumont updated the diff for D3397: loader.svn: Start tests refactoring with pytest.

Explain datadir override

Jul 3 2020, 10:37 AM
vlorentz accepted D3402: loader-svn: tests: Refactor scenario about starting from existing revision.
Jul 3 2020, 10:34 AM
vlorentz accepted D3401: loader-svn: tests: Refactor start-from-scratch use case.

Also the coverage did not move (iirc).

Jul 3 2020, 10:33 AM
ardumont added a comment to D3401: loader-svn: tests: Refactor start-from-scratch use case.

Here too, you're removing assertions and not adding equivalents

Jul 3 2020, 10:17 AM
ardumont updated the summary of D3402: loader-svn: tests: Refactor scenario about starting from existing revision.
Jul 3 2020, 10:13 AM
ardumont added inline comments to D3399: tests: Refactor scenario about visits on repository with no change.
Jul 3 2020, 10:10 AM
vlorentz added a comment to D3401: loader-svn: tests: Refactor start-from-scratch use case.

Here too, you're removing assertions and not adding equivalents

Jul 3 2020, 10:09 AM
vlorentz accepted D3400: tests: Refactor scenario about visits on repository with changes.
Jul 3 2020, 10:08 AM
vlorentz accepted D3399: tests: Refactor scenario about visits on repository with no change.
Jul 3 2020, 10:06 AM
vlorentz added inline comments to D3399: tests: Refactor scenario about visits on repository with no change.
Jul 3 2020, 10:05 AM
ardumont updated the summary of D3390: Unify object_type some more within the merkle and from_disk modules.
Jul 3 2020, 10:05 AM
ardumont added inline comments to D3397: loader.svn: Start tests refactoring with pytest.
Jul 3 2020, 9:55 AM
ardumont added inline comments to D3399: tests: Refactor scenario about visits on repository with no change.
Jul 3 2020, 9:54 AM
ardumont added inline comments to D3399: tests: Refactor scenario about visits on repository with no change.
Jul 3 2020, 9:52 AM
vlorentz added inline comments to D3397: loader.svn: Start tests refactoring with pytest.
Jul 3 2020, 9:51 AM
ardumont added inline comments to D3397: loader.svn: Start tests refactoring with pytest.
Jul 3 2020, 9:51 AM
vlorentz added inline comments to D3399: tests: Refactor scenario about visits on repository with no change.
Jul 3 2020, 9:50 AM
swh-public-ci added a comment to D3402: loader-svn: tests: Refactor scenario about starting from existing revision.

Build is green

Jul 3 2020, 9:49 AM
ardumont updated the diff for D3402: loader-svn: tests: Refactor scenario about starting from existing revision.

Drop redundant tests (coverage did not bulge on production code after removing it)

Jul 3 2020, 9:47 AM
vlorentz accepted D3397: loader.svn: Start tests refactoring with pytest.
Jul 3 2020, 9:46 AM
swh-public-ci added a comment to D3400: tests: Refactor scenario about visits on repository with changes.

Build is green

Jul 3 2020, 9:44 AM
swh-public-ci added a comment to D3401: loader-svn: tests: Refactor start-from-scratch use case.

Build is green

Jul 3 2020, 9:43 AM
swh-public-ci added a comment to D3402: loader-svn: tests: Refactor scenario about starting from existing revision.

Build is green

Jul 3 2020, 9:41 AM
ardumont updated the diff for D3400: tests: Refactor scenario about visits on repository with changes.

Drop redundant scenario (already tested within that scope)

Jul 3 2020, 9:41 AM
ardumont updated the diff for D3401: loader-svn: tests: Refactor start-from-scratch use case.

Rebase

Jul 3 2020, 9:40 AM
ardumont retitled D3401: loader-svn: tests: Refactor start-from-scratch use case from tests: Refactor start-from-scratch use case to loader-svn: tests: Refactor start-from-scratch use case.
Jul 3 2020, 9:40 AM
ardumont created D3402: loader-svn: tests: Refactor scenario about starting from existing revision.
Jul 3 2020, 9:40 AM
ardumont added a revision to T2462: svn loader: Refactor tests using pytest fixtures: D3402: loader-svn: tests: Refactor scenario about starting from existing revision.
Jul 3 2020, 9:40 AM · SVN Loader
swh-public-ci added a comment to D3401: loader-svn: tests: Refactor start-from-scratch use case.

Build is green

Jul 3 2020, 9:18 AM
ardumont updated the diff for D3401: loader-svn: tests: Refactor start-from-scratch use case.

Add some more assertions on status

Jul 3 2020, 9:16 AM
swh-public-ci added a comment to D3401: loader-svn: tests: Refactor start-from-scratch use case.

Build is green

Jul 3 2020, 9:15 AM
ardumont created D3401: loader-svn: tests: Refactor start-from-scratch use case.
Jul 3 2020, 9:13 AM
ardumont added a revision to T2462: svn loader: Refactor tests using pytest fixtures: D3401: loader-svn: tests: Refactor start-from-scratch use case.
Jul 3 2020, 9:13 AM · SVN Loader
swh-public-ci added a comment to D3400: tests: Refactor scenario about visits on repository with changes.

Build is green

Jul 3 2020, 9:13 AM
ardumont updated the diff for D3400: tests: Refactor scenario about visits on repository with changes.

Add missing pytest-postgresql requirements

Jul 3 2020, 9:11 AM
vlorentz accepted D3398: Add type annotations for swh.core.db.BaseDb.
Jul 3 2020, 8:51 AM
Harbormaster failed remote builds in B13273: Diff 12052 for D3400: tests: Refactor scenario about visits on repository with changes!
Jul 3 2020, 8:13 AM
swh-public-ci added a comment to D3400: tests: Refactor scenario about visits on repository with changes.

Build has FAILED

Jul 3 2020, 8:13 AM
ardumont created D3400: tests: Refactor scenario about visits on repository with changes.
Jul 3 2020, 8:12 AM
ardumont added a revision to T2462: svn loader: Refactor tests using pytest fixtures: D3400: tests: Refactor scenario about visits on repository with changes.
Jul 3 2020, 8:12 AM · SVN Loader
swh-public-ci added a comment to D3397: loader.svn: Start tests refactoring with pytest.

Build is green

Jul 3 2020, 7:36 AM
swh-public-ci added a comment to D3399: tests: Refactor scenario about visits on repository with no change.

Build is green

Jul 3 2020, 7:35 AM
ardumont updated the diff for D3397: loader.svn: Start tests refactoring with pytest.

Rework commit message

Jul 3 2020, 7:34 AM
ardumont created D3399: tests: Refactor scenario about visits on repository with no change.
Jul 3 2020, 7:33 AM
ardumont added a revision to T2462: svn loader: Refactor tests using pytest fixtures: D3399: tests: Refactor scenario about visits on repository with no change.
Jul 3 2020, 7:33 AM · SVN Loader
swh-public-ci added a comment to D3398: Add type annotations for swh.core.db.BaseDb.

Build is green

Jul 3 2020, 1:27 AM
swh-public-ci added a comment to D3394: Improve test coverage and type coverage for copy_to.

Build is green

Jul 3 2020, 1:25 AM
olasd created D3398: Add type annotations for swh.core.db.BaseDb.
Jul 3 2020, 1:24 AM
olasd updated the diff for D3394: Improve test coverage and type coverage for copy_to.

Reimplement copy_to escaping from the ground up.

Jul 3 2020, 1:24 AM

Jul 2 2020

civodul added a comment to T2430: lookup ingested tarballs (or similar source code containers) by container checksum.
In T2430#46040, @zack wrote:

@civodul I wanted to raise the topic of storing container metadata (in the style of what tools like pristine-tar do) here too, so thanks for giving me the chance :-)

Jul 2 2020, 10:44 PM · Data Model
rdicosmo raised the priority of T1099: support origin and SWHID blocklist for archive search and browse from Low to High.

This is an important feature: it has been dormant for a while, but we need to actually start implementing it.

Jul 2 2020, 8:21 PM · General, Web app
ardumont added a comment to D3396: Add raw metadata to the model..

Looks promising ;)

Jul 2 2020, 7:56 PM
ardumont added inline comments to D3397: loader.svn: Start tests refactoring with pytest.
Jul 2 2020, 7:33 PM
swh-public-ci added a comment to D3397: loader.svn: Start tests refactoring with pytest.

Build is green

Jul 2 2020, 7:23 PM
ardumont added a revision to T2462: svn loader: Refactor tests using pytest fixtures: D3397: loader.svn: Start tests refactoring with pytest.
Jul 2 2020, 7:21 PM · SVN Loader
ardumont created D3397: loader.svn: Start tests refactoring with pytest.
Jul 2 2020, 7:21 PM
ardumont created P711 svn test refactoring target!.
Jul 2 2020, 6:06 PM
swh-public-ci added a comment to D3396: Add raw metadata to the model..

Build is green

Jul 2 2020, 5:55 PM
vlorentz created D3396: Add raw metadata to the model..
Jul 2 2020, 5:53 PM
zack committed rMSLD121ad4127166: check-in slides for SoHeal 2020 keynote (authored by zack).
check-in slides for SoHeal 2020 keynote
Jul 2 2020, 5:37 PM
olasd committed rCJSWH4ca591ff184a: Drop obsolete args for the automatic backport job (authored by olasd).
Drop obsolete args for the automatic backport job
Jul 2 2020, 5:25 PM
anlambert committed rDWAPPS299ed02cbebd: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Jul 2 2020, 3:52 PM
anlambert committed rDWAPPSa4da1d819a45: common/service: Ensure to get last status when looking up origin visit (authored by anlambert).
common/service: Ensure to get last status when looking up origin visit
Jul 2 2020, 3:52 PM
anlambert closed D3395: common/service: Ensure to get last status when looking up origin visit.
Jul 2 2020, 3:52 PM
ardumont accepted D3395: common/service: Ensure to get last status when looking up origin visit.
Jul 2 2020, 3:25 PM
ardumont committed rDLDBASEaafac87f5c48: Reuse swh.model.from_disk.iter_directory function (authored by ardumont).
Reuse swh.model.from_disk.iter_directory function
Jul 2 2020, 3:24 PM
ardumont closed D3392: loader-core: Reuse swh.model.from_disk.iter_directory function.
Jul 2 2020, 3:24 PM
ardumont updated the test plan for D3393: loader.svn: Reuse swh.model.from_disk.iter_directory function.
Jul 2 2020, 3:23 PM
ardumont updated the test plan for D3392: loader-core: Reuse swh.model.from_disk.iter_directory function.
Jul 2 2020, 3:23 PM
swh-public-ci added a comment to D3392: loader-core: Reuse swh.model.from_disk.iter_directory function.

Build is green

Jul 2 2020, 3:23 PM
ardumont committed rDLDSVNee23fd758227: Reuse swh.model.from_disk.iter_directory function (authored by ardumont).
Reuse swh.model.from_disk.iter_directory function
Jul 2 2020, 3:22 PM
ardumont closed D3393: loader.svn: Reuse swh.model.from_disk.iter_directory function.
Jul 2 2020, 3:22 PM
swh-public-ci added a comment to D3393: loader.svn: Reuse swh.model.from_disk.iter_directory function.

Build is green

Jul 2 2020, 3:21 PM
swh-public-ci added a comment to D3392: loader-core: Reuse swh.model.from_disk.iter_directory function.

Build has FAILED

Jul 2 2020, 3:20 PM
ardumont committed rDMOD8863b5c186dd: Refactor common loader behavior within from_disk.iter_directory (authored by ardumont).
Refactor common loader behavior within from_disk.iter_directory
Jul 2 2020, 3:13 PM
ardumont closed D3391: Refactor common loader behavior within swh.model.from_disk.iter_directory function.
Jul 2 2020, 3:13 PM
ardumont committed rDMOD363b1659a6f5: Unify object_type some more within the merkle and from_disk modules (authored by ardumont).
Unify object_type some more within the merkle and from_disk modules
Jul 2 2020, 3:13 PM
ardumont closed D3390: Unify object_type some more within the merkle and from_disk modules.
Jul 2 2020, 3:13 PM
swh-public-ci added a comment to D3395: common/service: Ensure to get last status when looking up origin visit.

Build is green

Jul 2 2020, 3:12 PM
swh-public-ci added a comment to D3391: Refactor common loader behavior within swh.model.from_disk.iter_directory function.

Build is green

Jul 2 2020, 3:11 PM
ardumont updated the diff for D3391: Refactor common loader behavior within swh.model.from_disk.iter_directory function.
  • Use "refactor" instead of "factorize" term
  • Adapt according to review
Jul 2 2020, 3:09 PM
swh-public-ci added a comment to D3390: Unify object_type some more within the merkle and from_disk modules.

Build is green

Jul 2 2020, 3:05 PM
ardumont updated the diff for D3390: Unify object_type some more within the merkle and from_disk modules.

Adapt according to review

Jul 2 2020, 3:03 PM
ardumont added inline comments to D3390: Unify object_type some more within the merkle and from_disk modules.
Jul 2 2020, 3:02 PM
anlambert created D3395: common/service: Ensure to get last status when looking up origin visit.
Jul 2 2020, 3:01 PM
anlambert added inline comments to D3390: Unify object_type some more within the merkle and from_disk modules.
Jul 2 2020, 2:57 PM
ardumont retitled D3391: Refactor common loader behavior within swh.model.from_disk.iter_directory function from Factorize common loader behavior within swh.model.from_disk.iter_directory function to Refactor common loader behavior within swh.model.from_disk.iter_directory function.
Jul 2 2020, 2:54 PM
ardumont added a comment to D3390: Unify object_type some more within the merkle and from_disk modules.

kinda hope that solves [1]

Jul 2 2020, 2:48 PM
ardumont added inline comments to D3391: Refactor common loader behavior within swh.model.from_disk.iter_directory function.
Jul 2 2020, 2:45 PM
anlambert accepted D3393: loader.svn: Reuse swh.model.from_disk.iter_directory function.
Jul 2 2020, 2:45 PM
anlambert accepted D3392: loader-core: Reuse swh.model.from_disk.iter_directory function.
Jul 2 2020, 2:44 PM
anlambert accepted D3391: Refactor common loader behavior within swh.model.from_disk.iter_directory function.

Looks good, I added some nitpicking comments.

Jul 2 2020, 2:44 PM
ardumont added inline comments to D3390: Unify object_type some more within the merkle and from_disk modules.
Jul 2 2020, 2:41 PM
anlambert accepted D3390: Unify object_type some more within the merkle and from_disk modules.

LGTM, maybe you could set object_type type as Final like in other model classes (see inline comment).

Jul 2 2020, 2:35 PM
ardumont added a comment to P709 ERROR swh/core/api/tests/test_async.py - ValueError: option names {'--aiohttp-fast'} already added.

Solution that worked for me:

Jul 2 2020, 2:24 PM