be954f2fde39cefa80baeda01381a29582772684
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Apr 8 2020
Apr 8 2020
buffer: filter out duplicate objects.
anlambert committed rSPSITE49ed9869b1b6: webapp: Add keycloak configuration for production and staging (authored by anlambert).
webapp: Add keycloak configuration for production and staging
lgtm
Also, add yourself to the CONTRIBUTORS file (at the top of the repository ;)
(I think it's alphabetic order on the firstname there.)
anlambert updated the diff for D2975: webapp: Add keycloak configuration for production and staging.
Update: Address @ardumont comment.
anlambert added inline comments to D2975: webapp: Add keycloak configuration for production and staging.
Remains mostly nitpicks to fix (type, indentation, docstring updates...)
tox: Remove django 1.11 build
Harbormaster failed remote builds in B11668: Diff 10581 for D2972: test: update storage tests to (future) swh.journal 0.0.30!
Build has FAILED
Harbormaster failed remote builds in B11667: Diff 10580 for D2971: Make Storage.origin_visit_update() add an OriginVisit model entity in the journal!
swh-public-ci added a comment to D2971: Make Storage.origin_visit_update() add an OriginVisit model entity in the journal.
Build has FAILED
Harbormaster failed remote builds in B11666: Diff 10579 for D2970: Make swh/storage/storage.py flake8 compliant!
Build has FAILED
Harbormaster failed remote builds in B11665: Diff 10578 for D2969: Add a setup.cfg file to configure flake8 for black compatibility!
swh-public-ci added a comment to D2969: Add a setup.cfg file to configure flake8 for black compatibility.
Build has FAILED
Build is green
douardda committed rDSTOc51139ef9622: Make Storage.origin_visit_update() add an OriginVisit model entity in the… (authored by douardda).
Make Storage.origin_visit_update() add an OriginVisit model entity in the…
douardda committed rDSTObf48cfe98b33: Make swh/storage/storage.py flake8 compliant (authored by douardda).
Make swh/storage/storage.py flake8 compliant
douardda committed rDSTOfbb51aa0cfdd: Add a setup.cfg file to configure flake8 for black compatibility (authored by douardda).
Add a setup.cfg file to configure flake8 for black compatibility
rebase
douardda updated the diff for D2971: Make Storage.origin_visit_update() add an OriginVisit model entity in the journal.
rebase
rebase
douardda updated the diff for D2969: Add a setup.cfg file to configure flake8 for black compatibility.
rebase
DanSeraf committed rDMOD5d6883b26594: from_disk: path parameter to dir_filter functions (authored by DanSeraf).
from_disk: path parameter to dir_filter functions
DanSeraf added a comment to D2960: swh-model: exclude path support for the function from_disk in Directory.
In D2960#71967, @ardumont wrote:Looks good to me.
Don't you want to implement your callable here (the one which actually exclude stuff)?
Because now, the diff title is no longer in sync with the code ;)
Or do you plan to add it in swh-scanner?
swh-public-ci added a comment to D2966: storage.buffer: Add a new clear_buffers operation for the buffer proxy.
Build is green
ardumont added a comment to D2960: swh-model: exclude path support for the function from_disk in Directory.
Looks good to me.
swh-public-ci added a comment to D2960: swh-model: exclude path support for the function from_disk in Directory.
Build is green
ardumont updated the diff for D2966: storage.buffer: Add a new clear_buffers operation for the buffer proxy.
- storage*: Add clear_buffers operation for proxy storages (including interface, rpc/server)
- test_filter: Extract the filter storage into a fixture
DanSeraf updated the diff for D2960: swh-model: exclude path support for the function from_disk in Directory.
requested changes
ardumont added a comment to D2966: storage.buffer: Add a new clear_buffers operation for the buffer proxy.
You really need to add the clear_buffers method to interface.py as well. The method needs to be available on the rpc client/server, because we're recursively calling it on all backends.
ardumont added a comment to D2966: storage.buffer: Add a new clear_buffers operation for the buffer proxy.
The get_storage_with_filter_config refactoring could have been a new storage fixture (local to this module) instead
olasd requested changes to D2966: storage.buffer: Add a new clear_buffers operation for the buffer proxy.
The get_storage_with_filter_config refactoring could have been a new storage fixture (local to this module) instead (and it should be in a separate commit).
An interesting experiment, disabling the proxy buffer storage in the loader nixguix configuration.
And the number of hashcollision dropped to 0 (no new event for that loader since yesterday around 6pm our time).
vlorentz committed rDSTO8e8577e8d491: Prevent erroneous HashCollisions by using the same ctime for all rows. (authored by vlorentz).
Prevent erroneous HashCollisions by using the same ctime for all rows.
swh-public-ci added a comment to D2977: Prevent erroneous HashCollisions by using the same ctime for all rows..
Build is green
ardumont updated the summary of D2977: Prevent erroneous HashCollisions by using the same ctime for all rows..
ardumont requested changes to D2960: swh-model: exclude path support for the function from_disk in Directory.
Getting there, see my previous comments ;)
ardumont added inline comments to D2975: webapp: Add keycloak configuration for production and staging.
ardumont added inline comments to D2960: swh-model: exclude path support for the function from_disk in Directory.
ardumont added a comment to D2960: swh-model: exclude path support for the function from_disk in Directory.
I did not reply as val did (and i agreed with him ;)
Harbormaster failed remote builds in B11658: Diff 10571 for D2960: swh-model: exclude path support for the function from_disk in Directory!
swh-public-ci added a comment to D2960: swh-model: exclude path support for the function from_disk in Directory.
Build has FAILED
DanSeraf updated the diff for D2960: swh-model: exclude path support for the function from_disk in Directory.
requested changes
Apr 7 2020
Apr 7 2020
Build is green
Closing this as Django has been successfully upgraded to version 2.2 in production.
olasd committed rSPGUNI53aca02c1d81: Always restart crashed gunicorns after 10 seconds (authored by olasd).
Always restart crashed gunicorns after 10 seconds
cd swh-lister git checkout master git pull arc patch D2974 tox -r -- -x -s
@ardumont It seems the build error did not go away
@ardumont It seems the build error did not go away
swh-public-ci added a comment to D2973: package.loader: Insert consistently data to storage, clear buffer proxy state in case of error when skipping artifact.
Build has FAILED
anlambert committed rDENV5bdffaf03067: docker/conftest: Increase wait-for-it timeouts (authored by anlambert).
docker/conftest: Increase wait-for-it timeouts
Update: use pytest fixture instead of private module variable
In D2967#71861, @douardda wrote:why calling it _wfi_timeout (with the leading _)?
Also, in the glorious pytest way, this could be implemented as a fixture!
But yeah.
why calling it _wfi_timeout (with the leading _)?
Could you improve the first line of commit message before merging? (eg. Remove useless copy)
Harbormaster failed remote builds in B11652: Diff 10564 for D2972: test: update storage tests to (future) swh.journal 0.0.30!
Build has FAILED
Harbormaster failed remote builds in B11651: Diff 10563 for D2971: Make Storage.origin_visit_update() add an OriginVisit model entity in the journal!
swh-public-ci added a comment to D2971: Make Storage.origin_visit_update() add an OriginVisit model entity in the journal.
Build has FAILED
Harbormaster failed remote builds in B11650: Diff 10562 for D2970: Make swh/storage/storage.py flake8 compliant!