Two fixes:
- in-mem ignored None keys
- cassandra yielded input dicts as-is instead of a dict with just the hashes
Details
Details
- Reviewers
olasd - Group Reviewers
Reviewers - Commits
- rDSTO51b20164f6eb: Fix inconsistent behavior of skipped_content_missing across backends.
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Branch
- consistent-skipped_content_missing
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10612 Build 15871: tox-on-jenkins Jenkins Build 15870: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/993/ for more details.
Comment Actions
Looks fine save from a few comments/questions.
The "content key algortithm" stuff should probably be moved to a helper in swh.model, as we keep repeating it everywhere.
| swh/storage/in_memory.py | ||
|---|---|---|
| 262–267 | Took me a while to understand this logic. Why not use _content_key_algorithm() here? You could also make a dict with these keys, which would alleviate the n² nature of the lookup (even though it's probably not a big deal considering how tiny n is) | |
| 277–279 | As you only iterate once, no need for the list(content) | |
| swh/storage/tests/test_storage.py | ||
| 341–354 | ?? | |
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1000/ for more details.