I'm not very happy with the names though.
Suggestions welcome
Details
- Reviewers
ardumont olasd - Group Reviewers
Reviewers - Commits
- rDMOD8ebbd2168315: Split Content class into two classes, for missing and non-missing contents.
Diff Detail
- Repository
- rDMOD Data model
- Branch
- missing-content
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10435 Build 15536: tox-on-jenkins Jenkins Build 15535: arc lint + arc unit
Event Timeline
Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/168/ for more details.
s/non missing/present/
would be an improvement.
"Missing" isn't perfect, maybe, but it's consistent with SQL storage tables at least.
Indeed
"Missing" isn't perfect, maybe, but it's consistent with SQL storage tables at least.
No, SQL tables use "skipped". But I prefer "missing" because it's more generic (it also includes content we couldn't find)
"Missing" isn't perfect, maybe, but it's consistent with SQL storage tables at least.
i remembered as much but the table is named skipped, not missing.
what uses missing are the storage endpoints.
so bonus point to improve consistency.
swh/model/hypothesis_strategies.py | ||
---|---|---|
136 | as zack said present is better also i like existing but it can be ambiguous. go for present ;) |
Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/169/ for more details.
- rename missing -> skipped
it avoid confusion with the terminology used in swh-storage,
as "content missing" means we never saw that content before;
while "skipped content" means we saw it but didn't ingest it
for some reason.
Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/170/ for more details.
- rename missing -> skipped
it avoid confusion with the terminology used in swh-storage,
as "content missing" means we never saw that content before;
while "skipped content" means we saw it but didn't ingest it
for some reason.
as per oral discussion, agreed!