Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDSTO1cd53c1fbf57: Implement content_update for the in-mem storage.
Diff Detail
- Repository
- rDSTO Storage manager
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/894/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/894/console
| swh/storage/tests/test_api_client.py | ||
|---|---|---|
| 64 | I don't understand what we are doing with the journal initialization. That reminds me that i discussed with @douardda the possibility to have the journal part moved to a dedicated storage proxy (server side). That would avoid seeing everywhere within our add methods the journal instructions... [1] I'd be less invasive in the _add endpoints. [1] @douardda proposed another approach, keep the original storage (storage.py, cassandra.py) the interface with a default implementation (i call that an abstract class...). And push the abstration over the storage backend (db.py, cql.py). I'm not sure which is better. | |
| swh/storage/tests/test_api_client.py | ||
|---|---|---|
| 64 |
because it's supported in all tests except this one.
I agree, but it will be more work than you assume, and it's out of the scope of my current work on merging the cassandra backend. | |
| swh/storage/tests/test_api_client.py | ||
|---|---|---|
| 64 |
yes, completely out of scope, just a heads up since i started talking journal ;) the good side is that you are in the loop as well ;) | |