Differential D2572

Add environment variable $SWH_SENTRY_ENVIRONMENT
ClosedPublic
Actions

Authored by vlorentz on Jan 22 2020, 2:07 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDCORE0aaab9cfdb3f: Add environment variable $SWH_SENTRY_ENVIRONMENT

Summary

This allows initializing Sentry with the environment the process
is running in (ie. "production" or "staging"), which allows filtering
in the web UI to only show issues happening in one of the environments.

https://docs.sentry.io/enriching-error-data/environments/?platform=python

Diff Detail

Repository

rDCORE Foundations and core functionalities

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 10233
Build 15178: tox-on-jenkins	Jenkins
Build 15177: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jan 22 2020, 2:07 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 22 2020, 2:07 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/389/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/389/console

Harbormaster failed remote builds in B10233: Diff 9172!Jan 22 2020, 2:10 PM

Nice!
Thanks.

Accepted, don't forget to fix the build though.
You are missing mock adaptations for the build to be green ;)

This revision is now accepted and ready to land.Jan 22 2020, 3:25 PM

update tests

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/390/ for more details.

Harbormaster completed remote builds in B10238: Diff 9179.Jan 22 2020, 3:37 PM

fyi, I'm adapting the puppet manifests with this.

@ardumont see T2181

ardumont accepted this revision.Jan 22 2020, 6:37 PM

ardumont mentioned this in D2576: sentry: Define setup for swh services (servers, workers, ...).Jan 22 2020, 6:50 PM

Closed by commit rDCORE0aaab9cfdb3f: Add environment variable $SWH_SENTRY_ENVIRONMENT (authored by vlorentz). · Explain WhyJan 22 2020, 7:13 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCORE0aaab9cfdb3f: Add environment variable $SWH_SENTRY_ENVIRONMENT.

Revision Contents
Changeset List

Path

Size

swh/

core/

sentry.py

2 lines

Diff 9172

View Options

Add environment variable $SWH_SENTRY_ENVIRONMENTClosedPublicActions