origin_save: Properly handle server errors on requests submission
ClosedPublic
Actions

Authored by anlambert on Dec 13 2019, 11:28 AM.

Details

Reviewers

olasd
ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS0c0bc4a59fe4: origin_save: Properly handle server errors on requests submission

Summary

All exceptions were not properly catched when trying to create a scheduler task
associated to a save code now request, so no error was reported in the frontend.

Diff Detail

Repository

rDWAPPS Web applications

Branch

handle-origin-save-server-errors

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 9742
Build 14366: Cypress tests for swh-web diffs	Jenkins
Build 14365: tox-on-jenkins	Jenkins
Build 14364: arc lint + arc unit

Event Timeline

anlambert created this revision.Dec 13 2019, 11:28 AM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/850/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/447/ for more details.

Harbormaster completed remote builds in B9742: Diff 8655.Dec 13 2019, 11:40 AM

ardumont accepted this revision.Dec 13 2019, 11:49 AM

This revision is now accepted and ready to land.Dec 13 2019, 11:49 AM

Closed by commit rDWAPPS0c0bc4a59fe4: origin_save: Properly handle server errors on requests submission (authored by anlambert). · Explain WhyDec 13 2019, 11:56 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS0c0bc4a59fe4: origin_save: Properly handle server errors on requests submission.

Revision Contents
Changeset List

Path

Size

swh/

web/

misc/

origin_save.py

7 lines

tests/

misc/

test_origin_save.py

15 lines

Diff 8655

View Options

swh/web/misc/origin_save.py