Page MenuHomeSoftware Heritage

Deduplicate client code.
ClosedPublic

Authored by vlorentz on Dec 12 2019, 6:17 PM.

Details

Diff Detail

Repository
rDSTO Storage manager
Branch
deduplicate-client
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9731
Build 14344: tox-on-jenkinsJenkins
Build 14343: arc lint + arc unit

Event Timeline

rewrite without requiring the other diff (+ no remote_api_endpoint() for non-POST endpoints)

anlambert added a subscriber: anlambert.

Looks good to me !

swh/storage/api/client.py
200–204

Why omitting these ones ?

This revision is now accepted and ready to land.Dec 13 2019, 4:52 PM
swh/storage/api/client.py
200–204

they are get instead of post

swh/storage/api/client.py
200–204

Oh I see. Maybe the support of the type of requests could be added in the remote_api_endpoint decorator in the future ?

Landed as 869100bc08cf99e5ba2cbf451a1792ba8eb34f43.