Page MenuHomeSoftware Heritage
Differential D2403

core.loader: Drop deprecated behavior
ClosedPublic
Actions

Authored by ardumont on Dec 6 2019, 12:24 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDLDBASE6d28068548d2: core.loader: Drop deprecated behavior
Summary

The old buffer and filter behavior must be installed through configuration now.
It's now delegated to specific buffer and filter storages.

Beware, this broke some dvcs loaders (svn only it seems, D2405) relying on
some removed api. And a pass must be made on those now.

Test Plan

tox

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9691
Build 14286: tox-on-jenkinsJenkins
Build 14285: arc lint + arc unit

Event Timeline

ardumont created this revision.Dec 6 2019, 12:24 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 6 2019, 12:24 PM
swh-public-ci added a comment.Dec 6 2019, 12:26 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/264/ for more details.

Harbormaster completed remote builds in B9549: Diff 8466.Dec 6 2019, 12:26 PM
ardumont edited the summary of this revision. (Show Details)Dec 6 2019, 12:29 PM
ardumont updated this revision to Diff 8485.Dec 6 2019, 2:18 PM

Rebase to latest master

swh-public-ci added a comment.Dec 6 2019, 2:19 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/270/ for more details.

Harbormaster completed remote builds in B9568: Diff 8485.Dec 6 2019, 2:19 PM
anlambert accepted this revision.Dec 6 2019, 2:21 PM
anlambert added a subscriber: anlambert.

All good !

This revision is now accepted and ready to land.Dec 6 2019, 2:21 PM
ardumont mentioned this in D2405: svn.loader: Migrate to new buffer/filter behavior.Dec 6 2019, 2:51 PM
ardumont edited the summary of this revision. (Show Details)Dec 6 2019, 2:51 PM
ardumont updated this revision to Diff 8498.Dec 6 2019, 3:51 PM

Plug to master

swh-public-ci added a comment.Dec 6 2019, 3:53 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/271/ for more details.

Harbormaster completed remote builds in B9581: Diff 8498.Dec 6 2019, 3:53 PM
anlambert mentioned this in D2407: Fix tests data initialization after git loader api changes.Dec 6 2019, 5:32 PM
ardumont updated this revision to Diff 8601.Dec 11 2019, 6:27 PM

Rebase on latest origin/master

swh-public-ci added a comment.Dec 11 2019, 6:28 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/273/ for more details.

Harbormaster completed remote builds in B9683: Diff 8601.Dec 11 2019, 6:28 PM
ardumont updated this revision to Diff 8609.Dec 12 2019, 11:58 AM

Rebase and plug to master

swh-public-ci added a comment.Dec 12 2019, 11:59 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/276/ for more details.

Harbormaster completed remote builds in B9691: Diff 8609.Dec 12 2019, 11:59 AM
Closed by commit rDLDBASE6d28068548d2: core.loader: Drop deprecated behavior (authored by ardumont). · Explain WhyDec 12 2019, 12:01 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLDBASE6d28068548d2: core.loader: Drop deprecated behavior.

Revision Contents
Changeset List

PathSize
2 lines
swh/
loader/
core/
290 lines
tests/
107 lines

Diff 8609

View Options

requirements-swh.txt

Loading...
View Options

swh/loader/core/loader.py

Loading...
View Options

swh/loader/core/queue.py

Loading...
View Options

swh/loader/core/tests/test_loader.py

Loading...
View Options

swh/loader/core/tests/test_queue.py

Loading...
About · Developer information · Legal