Related to T2134
Details
- Reviewers
anlambert - Group Reviewers
Reviewers - Commits
- rDLS5ab9d67d675a: core: Align listers' task output (hg/git tasks) with expected format
tox
Diff Detail
- Repository
- rDLS Listers
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 9611 Build 14153: tox-on-jenkins Jenkins Build 14152: arc lint + arc unit
Event Timeline
Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/510/ for more details.
Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/511/ for more details.
swh/lister/core/lister_base.py | ||
---|---|---|
394–395 | I would rather use the same task arguments format (keyword) for all loaders here. |
swh/lister/core/lister_base.py | ||
---|---|---|
394–395 | I could not really do it before (well morally). |
Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/512/ for more details.
swh/lister/core/lister_base.py | ||
---|---|---|
379 | Something hit me, thus i keep doing that. I thought it was better to be generic in the output (so Mapping here) That's the one thing i remember clearly from zack's slide (and what he told me ;). |
swh/lister/core/lister_base.py | ||
---|---|---|
379 | Yes, the recommended way is the opposite: use a concrete type in the output and a generic type in the input. See https://mypy.readthedocs.io/en/latest/cheat_sheet_py3.html#standard-duck-types |
swh/lister/core/lister_base.py | ||
---|---|---|
379 | Thanks! Will try to fix my erroneous ways ;) |
Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/513/ for more details.
swh/lister/core/lister_base.py | ||
---|---|---|
379 | I checked zack's slide. Be conservative in what you send, be liberal in what you accept. |