Page MenuHomeSoftware Heritage
Differential D2230

typing: add type annotations to make mypy pass
ClosedPublic
Actions

Authored by zack on Nov 7 2019, 1:27 PM.

Details

Reviewers
vlorentz
Commits
rDSEA5f2a19336877: in_memory.py: make flake8 happy again
Test Plan

tox -e mypy

Diff Detail

Repository
rDSEA Archive search
Branch
feature/typing
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8865
Build 12934: tox-on-jenkinsJenkins
Build 12933: arc lint + arc unit

Event Timeline

zack created this revision.Nov 7 2019, 1:27 PM
swh-public-ci added a comment.Nov 7 2019, 1:27 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSEA/job/tox/11/
See console output for more information: https://jenkins.softwareheritage.org/job/DSEA/job/tox/11/console

Harbormaster failed remote builds in B8863: Diff 7696!Nov 7 2019, 1:27 PM
zack updated this revision to Diff 7698.Nov 7 2019, 1:31 PM
  • in_memory.py: make flake8 happy again
swh-public-ci added a comment.Nov 7 2019, 1:33 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSEA/job/tox/13/
See console output for more information: https://jenkins.softwareheritage.org/job/DSEA/job/tox/13/console

Harbormaster failed remote builds in B8865: Diff 7698!Nov 7 2019, 1:33 PM
swh-public-ci added a comment.Nov 7 2019, 2:19 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSEA/job/tox/14/ for more details.

Harbormaster completed remote builds in B8865: Diff 7698.Nov 7 2019, 2:19 PM
vlorentz accepted this revision.Nov 8 2019, 1:16 PM
This revision is now accepted and ready to land.Nov 8 2019, 1:16 PM
Closed by commit rDSEA5f2a19336877: in_memory.py: make flake8 happy again (authored by zack). · Explain WhyNov 8 2019, 1:18 PM
This revision was automatically updated to reflect the committed changes.
zack added a commit: rDSEA5f2a19336877: in_memory.py: make flake8 happy again.

Revision Contents
Changeset List

PathSize
1 line
1 line
18 lines
swh/
5 lines
search/
2 lines
14 lines
19 lines
1 line
10 lines

Diff 7698

View Options

.gitignore

Loading...
View Options

MANIFEST.in

Loading...
View Options

mypy.ini

Loading...
View Options

swh/__init__.py

Loading...
View Options

swh/search/cli.py

Loading...
View Options

swh/search/elasticsearch.py

Loading...
View Options

swh/search/in_memory.py

Loading...
View Options

swh/search/py.typed

Loading...
View Options

tox.ini

Loading...
About · Developer information · Legal