Page MenuHomeSoftware Heritage

Implement timeouts for cloning repositories
ClosedPublic

Authored by olasd on Sep 10 2019, 5:34 PM.

Details

Summary

This is a workaround for T1962.

Test Plan

tox unittests the timeout behavior

Diff Detail

Repository
rDLDHG Mercurial loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7754
Build 11147: tox-on-jenkinsJenkins
Build 11146: arc lint + arc unit

Event Timeline

CI builds are currently failing due to the use of Process.kill method (not available in Python 3.5)

swh/loader/mercurial/loader.py
166

Process.kill has been introduced in Python 3.7

207–212

Just a nitpick, you could add the timeout unity in the debug message.

This revision now requires changes to proceed.Sep 10 2019, 5:51 PM

Use process.terminate instead of process.kill (3.5-compatible)

swh/loader/mercurial/loader.py
166

*barf*

Show timeout unit in log message

This revision is now accepted and ready to land.Sep 10 2019, 6:08 PM
This revision was automatically updated to reflect the committed changes.