Page MenuHomeSoftware Heritage

Test date parsing of origin_metadata_add.
ClosedPublic

Authored by vlorentz on Jun 5 2019, 1:40 PM.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda added a subscriber: douardda.

I'm not very fond of testing several things at once. This does not "Test date parsing of origin_metadata_add" as such, it adds this testing as a side effect, in the middle of an unrelated test. Which is not a good idea. I mean, the test is named 'test_origin_metadata_get' and it does already too many things. Having the test named 'test_origin_metadata_get' fail because of bug in parsing dates in origin_metadata_add does not help the poor guy fixing these...

This revision now requires changes to proceed.Jun 12 2019, 12:32 PM

move date parsing testing to the relevant test.

This revision is now accepted and ready to land.Jun 13 2019, 2:01 PM
This revision was landed with ongoing or failed builds.Jun 13 2019, 2:07 PM
This revision was automatically updated to reflect the committed changes.