Add a test checking that directory_ls does not recurse into subdirs by default.
ClosedPublic
Actions

Authored by vlorentz on Jun 5 2019, 1:33 PM.

Details

Reviewers

Group Reviewers

Commits

rDSTOC34b8c549b113: Add a test checking that directory_ls does not recurse into subdirs by default.
rDSTO34b8c549b113: Add a test checking that directory_ls does not recurse into subdirs by default.

Diff Detail

Repository

rDSTO Storage manager

Branch

directory_ls-nonrecursive

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 6031
Build 8294: tox-on-jenkins	Jenkins
Build 8293: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jun 5 2019, 1:33 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 5 2019, 1:33 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/445/ for more details.

Harbormaster completed remote builds in B6031: Diff 5084.Jun 5 2019, 2:04 PM

It's not that straightforward that this test does indeed do what the commit message pretends... A comment or 2 in the code of the test would not hurt. But meh

This revision is now accepted and ready to land.Jun 12 2019, 12:24 PM

rebase
add comments

In D1548#35350, @douardda wrote:

It's not that straightforward that this test does indeed do what the commit message pretends...

It's clearer when you compare with the code of test above

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/477/ for more details.

Harbormaster completed remote builds in B6172: Diff 5199.Jun 12 2019, 3:53 PM

Closed by commit rDSTO34b8c549b113: Add a test checking that directory_ls does not recurse into subdirs by default. (authored by vlorentz). · Explain WhyJun 13 2019, 2:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

storage/

tests/

test_storage.py

25 lines

Diff 5084

View Options

swh/storage/tests/test_storage.py

Add a test checking that directory_ls does not recurse into subdirs by default.ClosedPublicActions