Unify argument names of the pg and in-mem storage.
ClosedPublic
Actions

Authored by vlorentz on May 29 2019, 3:03 PM.

Details

Reviewers

Group Reviewers

Commits

rDSTOC3556b74791d4: Unify argument names of the pg and in-mem storage.
rDSTO3556b74791d4: Unify argument names of the pg and in-mem storage.

Summary

Argument names matter for the remote API.

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.May 29 2019, 3:03 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 29 2019, 3:03 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/430/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/430/console

Harbormaster failed remote builds in B5961: Diff 5013!May 29 2019, 3:11 PM

fix names

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/431/ for more details.

Harbormaster completed remote builds in B5974: Diff 5023.May 29 2019, 6:19 PM

Some part of me wonders if it wouldn't make sense to unify the other way around, as the argument names you picked in the in-memory storage are way more sensible, but we've not succeeded in making a change in this area without breaking some (or all) clients...

This revision is now accepted and ready to land.Jun 4 2019, 9:29 AM

Closed by commit rDSTO3556b74791d4: Unify argument names of the pg and in-mem storage. (authored by vlorentz). · Explain WhyJun 4 2019, 1:29 PM

This revision was automatically updated to reflect the committed changes.