No idea if that works as i have no idea on how to test this.
Hoping for some clues from you people!
Details
Details
- Reviewers
vlorentz olasd - Group Reviewers
Reviewers - Commits
- R154:d6ea2105c3b4: Explicit regexp fields
R154:a29ca311e8ec: phab/plugin: Change to match reality, there is at most 1 fragment
R154:b811c0f4e960: Phabricator/plugin: Recognize object id even in lower case
R154:39b83e748073: plugin: Factorize full uri computation in get_object_by_phid
R154:10a188841c8a: Refactor: Break out of the loop prior to parse some more the id
R154:85630dbab7d4: Refactor: Use regexp to fetch object type, id and fragment
R154:abbf2f5c9ed3: Phabricator/plugin: Add support for commented links
Diff Detail
Diff Detail
- Repository
- R154 Limnoria plugins
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 5430 Build 7356: arc lint + arc unit
Event Timeline
Comment Actions
Transmit object_fragment to object formatter as well
So that they can build the right url
Comment Actions
- Phabricator/plugin: Add support for commented links
- Refactor: Break out of the loop prior to parse some more the id
- Refactor: Use regexp to fetch object type, id and fragment
@olasd i finally grasped what you meant, thanks.
I iterated over multiple implementations.
In the end, i chose to use regexp consistently.
Comment Actions
Could you factorize this part:
url = full_XXX['uri']
if object_fragment is not None:
url = '%s%s' % (url, object_fragment)by moving it in get_object_by_phid?
| Phabricator/plugin.py | ||
|---|---|---|
| 224 | Replace the last * by a ?, there's at most one fragment. | |
| Phabricator/plugin.py | ||
|---|---|---|
| 224 | Right! | |
Comment Actions
- phab/plugin: Change to match reality, there is at most 1 fragment
- plugin: Factorize full uri computation in get_object_by_phid