Paths

Table of Contentst

Differential D1396

config: Allow to specify development database file
ClosedPublic
Actions

Authored by anlambert on Apr 10 2019, 2:19 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Commits

rDWAPPS275325294bb5: config: Allow to specify development database file

Summary

Related T1639
Related D1391

Diff Detail

Repository

rDWAPPS Web applications

Branch

dev-db-config

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 5303
Build 7187: tox-on-jenkins	Jenkins
Build 7186: arc lint + arc unit

Event Timeline

anlambert created this revision.Apr 10 2019, 2:19 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 10 2019, 2:19 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/381/ for more details.

Harbormaster completed remote builds in B5303: Diff 4493.Apr 10 2019, 2:23 PM

ok but see my comment plz

swh/web/config.py
85	if you want to use the swh/web/settings directory by default, why not retrieve its path from `swh.web.settings.__file__`?

This revision is now accepted and ready to land.Apr 10 2019, 4:12 PM

Update: Address douardda comment

This revision was landed with ongoing or failed builds.Apr 10 2019, 4:54 PM

Closed by commit rDWAPPS275325294bb5: config: Allow to specify development database file (authored by anlambert). · Explain Why

This revision was automatically updated to reflect the committed changes.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/382/ for more details.

Harbormaster completed remote builds in B5308: Diff 4503.Apr 10 2019, 4:56 PM

Revision Contents
Changeset List

Path

Size

swh/

web/

config.py

3 lines

settings/

common.py

2 lines

Diff 4493

View Options

swh/web/config.py