Details
- Reviewers
douardda ardumont - Group Reviewers
Reviewers - Commits
- rDCIDXa8fba6c5abde: Make OriginIndexer call storage.origin_get a single time for all origins.
Diff Detail
- Repository
- rDCIDX Metadata indexer
- Branch
- OriginIndexer-origin_get-single-query
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 4055 Build 5328: tox-on-jenkins Jenkins Build 5327: arc lint + arc unit
Event Timeline
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/323/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/323/console
I see no link between this hunk and the diff's title. Did I miss something?
BTW, I do prefer the version before the diff: easier to read.
Ok I spoke a bit too fast. This does indeed what it pretends. But it's a bit cryptic as is. The 'double loop' on ids is confusing (zip + list comprehension).
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/327/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/327/console
| swh/indexer/indexer.py | ||
|---|---|---|
| 567 | You do not need the zip call, you can use origin['id']. that might also avoid any problem in regards of inconsistency regarding the list's order | |
| swh/indexer/indexer.py | ||
|---|---|---|
| 567 | origin can be None. | |
| swh/indexer/indexer.py | ||
|---|---|---|
| 567 | ok, so the zip call is for logging the missing origin id. | |
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/373/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/373/console