Differential D1031

Extract the escape function declaration from the BaseDb.copy_to method
ClosedPublic
Actions

Authored by douardda on Jan 29 2019, 5:41 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDCOREe87c67e4a849: Extract the escape function declaration from the BaseDb.copy_to method

Summary

There is no need for it to be declared there: it does not use any closure
and defining a function in a function is expensive!

Diff Detail

Repository

rDCORE Foundations and core functionalities

Branch

wip

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 3818
Build 4995: tox-on-jenkins	Jenkins
Build 4994: arc lint + arc unit

Event Timeline

douardda created this revision.Jan 29 2019, 5:41 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 29 2019, 5:41 PM

Harbormaster failed remote builds in B3818: Diff 3265!Jan 29 2019, 5:41 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/132/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/132/console

Thanks!

This revision is now accepted and ready to land.Jan 30 2019, 10:28 AM

Closed by commit rDCOREe87c67e4a849: Extract the escape function declaration from the BaseDb.copy_to method (authored by douardda). · Explain WhyJan 30 2019, 12:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

core/

db/

__init__.py

64 lines

Diff 3265

View Options

Extract the escape function declaration from the BaseDb.copy_to methodClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 3265

swh/core/db/__init__.py

Extract the escape function declaration from the BaseDb.copy_to method
ClosedPublic
Actions

Revision Contents
Changeset List

swh/core/db/init.py