github: Fix fixtures use in tests
ClosedPublic
Actions

Authored by anlambert on Jan 2 2023, 6:07 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLSbcf30aba90ba: github: Fix fixtures use in tests

Summary

requests_ratelimited fixture from swh-core was renamed to
github_requests_ratelimited.

remaining_requests parameter was added to the github_response_callback
function from swh-core, making it no longer compatible with requests_mock
callback for json responses.

Diff Detail

Repository

rDLS Listers

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 33375
Build 52318: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 52317: arc lint + arc unit

Event Timeline

anlambert created this revision.Jan 2 2023, 6:07 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 2 2023, 6:07 PM

Build is green

Patch application report for D8991 (id=32389)

Rebasing onto e218fbfef6...

Current branch diff-target is up to date.

Changes applied before test

commit bcf30aba90ba6e6e0bf71cf44f76ac3d2763e6a2
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Jan 2 14:20:08 2023 +0100

    github: Fix fixtures use in tests
    
    requests_ratelimited fixture from swh-core was renamed to
    github_requests_ratelimited.
    
    remaining_requests parameter was added to the github_response_callback
    function from swh-core, making it no longer compatible with requests_mock
    callback for json responses.

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/877/ for more details.

Harbormaster completed remote builds in B33375: Diff 32389.Jan 2 2023, 6:13 PM

anlambert requested review of this revision.Jan 2 2023, 6:13 PM