Page MenuHomeSoftware Heritage

Remove ambiguous item cursors
ClosedPublic

Authored by jayeshv on Dec 1 2022, 11:34 AM.

Details

Summary

Item cursors in origin, originsearch, visit, visitstatus and snapshotbranch
can not always be determined. This could cause client errors.
They are temporarily removed and can be added after re-factoring backend source
functions.

Diff Detail

Repository
rDGQL GraphQL API
Branch
remove-cursors-D8911
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 33232
Build 52104: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 52103: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D8911 (id=32114)

Rebasing onto c28b65feaf...

Current branch diff-target is up to date.
Changes applied before test
commit 5990678ac2c4dd146ca237df727b8973a4303300
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Nov 30 16:49:55 2022 +0100

    Remove ambiguous item cursors
    
    Item cursors in origin, originsearch, visit, visitstatus and snapshotbranch
    can not always be determined. This could cause client errors.
    They are temporarily removed and can be added after re-factoring backend source
    functions.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/242/ for more details.

extra tests for pagination

Build is green

Patch application report for D8911 (id=32224)

Rebasing onto c28b65feaf...

Current branch diff-target is up to date.
Changes applied before test
commit dd73f7d41a30f774567a9381d2b21236fb255c2f
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Nov 30 16:49:55 2022 +0100

    Remove ambiguous item cursors
    
    Item cursors in origin, originsearch, visit, visitstatus and snapshotbranch
    can not always be determined. This could cause client errors.
    They are temporarily removed and can be added after re-factoring backend source
    functions.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/245/ for more details.

Build is green

Patch application report for D8911 (id=32235)

Rebasing onto c28b65feaf...

Current branch diff-target is up to date.
Changes applied before test
commit 86a48e6663a776aec15129959d2be7a7d337d040
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Nov 30 16:49:55 2022 +0100

    Remove ambiguous item cursors
    
    Item cursors in origin, originsearch, visit, visitstatus and snapshotbranch
    can not always be determined. This could cause client errors.
    They are temporarily removed and can be added after re-factoring backend source
    functions.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/246/ for more details.

jayeshv retitled this revision from [WIP] Remove ambiguous item cursors to Remove ambiguous item cursors.Dec 12 2022, 3:29 PM

Please add comments next to commented out code to explain why it's commented out. (it could be a link to this diff)

jayeshv retitled this revision from Remove ambiguous item cursors to [WP]: Remove ambiguous item cursors.Dec 15 2022, 11:12 AM

Build is green

Patch application report for D8911 (id=32277)

Rebasing onto c664ef42e7...

Current branch diff-target is up to date.
Changes applied before test
commit 19bb17892866cdab9b18a39382aedc8099a88293
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Nov 30 16:49:55 2022 +0100

    Remove ambiguous item cursors
    
    Item cursors in origin, originsearch, visit, visitstatus and snapshotbranch
    can not always be determined. This could cause client errors.
    They are temporarily removed from the schema and can be added after
    re-factoring backend source functions.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/251/ for more details.

remvove unnecessary comment

Build is green

Patch application report for D8911 (id=32278)

Rebasing onto c664ef42e7...

Current branch diff-target is up to date.
Changes applied before test
commit 611b02b936c64f0b668b16ad7110dab56ae88b9f
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Nov 30 16:49:55 2022 +0100

    Remove ambiguous item cursors
    
    Item cursors in origin, originsearch, visit, visitstatus and snapshotbranch
    can not always be determined. This could cause client errors.
    They are temporarily removed from the schema and can be added after
    re-factoring backend source functions.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/252/ for more details.

Build is green

Patch application report for D8911 (id=32279)

Rebasing onto c664ef42e7...

Current branch diff-target is up to date.
Changes applied before test
commit d3aee2f9eb1d3617e5bc62a9b39a17b03393f399
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Nov 30 16:49:55 2022 +0100

    Remove ambiguous item cursors
    
    Item cursors in origin, originsearch, visit, visitstatus and snapshotbranch
    can not always be determined. This could cause client errors.
    They are temporarily removed from the schema and can be added after
    re-factoring backend source functions.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/253/ for more details.

jayeshv retitled this revision from [WP]: Remove ambiguous item cursors to Remove ambiguous item cursors.Dec 15 2022, 12:03 PM
This revision is now accepted and ready to land.Dec 15 2022, 12:07 PM
This revision was automatically updated to reflect the committed changes.