utils/urlsindex: Modify UrlsIndex class to simplify API URLs management
ClosedPublic
Actions

Authored by anlambert on Nov 3 2022, 1:54 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDWAPPSd055e08d8bbc: utils/urlsindex: Modify UrlsIndex class to simplify API URLs management

Summary

Make that class instantiable in order for each swh django application to
manage its related Web API URLs independently from the swh.web.api django
application.

It also simplifies initialization of applications as their ordering does
not matter anymore but also improves tests related to URLs registration
of an application.

Also add typing to UrlsIndex class.

Diff Detail

Repository

rDWAPPS Web applications

Branch

urlsindex-update

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32689
Build 51210: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 51209: arc lint + arc unit

Event Timeline

anlambert created this revision.Nov 3 2022, 1:54 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 3 2022, 1:54 PM

Build is green

Patch application report for D8804 (id=31731)

Rebasing onto 93696b9cc7...

Current branch diff-target is up to date.

Changes applied before test

commit 1e3c1acf7b8695bc3282351488c45f02beb68e32
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Nov 3 13:44:39 2022 +0100

    utils/urlsindex: Modify UrlsIndex class to simplify API URLs management
    
    Make that class instantiable in order for each swh django application to
    manage its related Web API URLs independently from the swh.web.api django
    application.
    
    It also simplifies initialization of applications as their ordering does
    not matter anymore but also improves tests related to URLs registration
    of an application.
    
    Also add typing to UrlsIndex class.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2104/ for more details.

Harbormaster completed remote builds in B32685: Diff 31731.Nov 3 2022, 2:04 PM

anlambert requested review of this revision.Nov 3 2022, 2:04 PM

vlorentz accepted this revision.Nov 3 2022, 2:21 PM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/web/vault/urls.py
26–31	looks better IMO, but it works fine either way

This revision is now accepted and ready to land.Nov 3 2022, 2:21 PM

anlambert added inline comments.Nov 3 2022, 2:51 PM

swh/web/vault/urls.py
26–31	more Pythonic indeed, will update every `urls.py` files with such construct

Use more Pythonic way to concatenate lists

Build is green

Patch application report for D8804 (id=31734)

Rebasing onto 93696b9cc7...

Current branch diff-target is up to date.

Changes applied before test

commit d055e08d8bbcce777e31bb9befdb96cce37f85aa
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Nov 3 13:44:39 2022 +0100

    utils/urlsindex: Modify UrlsIndex class to simplify API URLs management
    
    Make that class instantiable in order for each swh django application to
    manage its related Web API URLs independently from the swh.web.api django
    application.
    
    It also simplifies initialization of applications as their ordering does
    not matter anymore but also improves tests related to URLs registration
    of an application.
    
    Also add typing to UrlsIndex class.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2105/ for more details.

Harbormaster completed remote builds in B32689: Diff 31734.Nov 3 2022, 3:04 PM

Closed by commit rDWAPPSd055e08d8bbc: utils/urlsindex: Modify UrlsIndex class to simplify API URLs management (authored by anlambert). · Explain WhyNov 3 2022, 3:18 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSd055e08d8bbc: utils/urlsindex: Modify UrlsIndex class to simplify API URLs management.