Page MenuHomeSoftware Heritage

gogs/lister: Allow public gogs instance listing
ClosedPublic

Authored by ardumont on Oct 21 2022, 6:03 PM.

Details

Summary

Prior to this commit, the lister assumed authentication was required while it exists
public gogs instances which do not require it.

This also updates documentation to mention the usual api location to check when actually
triggering a listing.

Co-authored with Antoine Lambert (@anlambert) <anlambert@softwareheritage.org>

Related to infra/sysadm-environment#4644
Related to https://gitlab.softwareheritage.org/infra/sysadm-environment/-/issues/4644#note_12601

Diff Detail

Repository
rDLS Listers
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 32505
Build 50905: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 50904: arc lint + arc unit

Event Timeline

swh/lister/gogs/lister.py
102–107

We should remove that method in that lister but also in the gitea one (which simply inherits from the gogs lister) and move the warning in the __init__ method instead.

Build is green

Patch application report for D8752 (id=31549)

Rebasing onto 0baaf68cff...

Current branch diff-target is up to date.
Changes applied before test
commit c99ba8d5150aa09216f5a71e3d1e044930537a10
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 21 17:50:49 2022 +0200

    gogs/lister: Allow listing on public gogs instance
    
    Prior to this commit, the lister assumed authentication was required while it exists
    public gogs instances which do not require it.
    
    This also updates documentation to mention the usual api location to check when actually
    triggering a listing.
    
    Co-authored with Antoine Lambert (@anlambert) <anlambert@softwareheritage.org>
    
    Related to infra/sysadm-environment#4644

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/806/ for more details.

ardumont marked an inline comment as done.

Adapt according to suggestion

swh/lister/gogs/lister.py
102–107

right, done!

ardumont retitled this revision from gogs/lister: Allow listing on public gogs instance to gogs/lister: Allow public gogs instance listing.Oct 21 2022, 6:11 PM

Build is green

Patch application report for D8752 (id=31550)

Rebasing onto 0baaf68cff...

Current branch diff-target is up to date.
Changes applied before test
commit ac95987454d99fe42e2c3c5a3b2c30704add4dcd
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 21 17:50:49 2022 +0200

    gogs/lister: Allow listing on public gogs instance
    
    Prior to this commit, the lister assumed authentication was required while it exists
    public gogs instances which do not require it.
    
    This also updates documentation to mention the usual api location to check when actually
    triggering a listing.
    
    Co-authored with Antoine Lambert (@anlambert) <anlambert@softwareheritage.org>
    
    Related to infra/sysadm-environment#4644

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/807/ for more details.

Build is green

Patch application report for D8752 (id=31551)

Rebasing onto 0baaf68cff...

Current branch diff-target is up to date.
Changes applied before test
commit 05ea67779413c41c7ec6898ff74b568336849ee6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 21 17:50:49 2022 +0200

    gogs/lister: Allow public gogs instance listing
    
    Prior to this commit, the lister assumed authentication was required. It exists public
    gogs instances which do not require it.
    
    This also updates documentation to mention the usual api location. This is useful when
    people wants to actually trigger a listing as a pre-check flight.
    
    Co-authored with Antoine Lambert (@anlambert) <anlambert@softwareheritage.org>.
    
    Related to infra/sysadm-environment#4644

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/808/ for more details.

swh/lister/gogs/lister.py
102–107

You forgot to commit the swh/lister/gitea/lister.py file I think.

This revision is now accepted and ready to land.Oct 21 2022, 6:27 PM

Build is green

Patch application report for D8752 (id=31552)

Rebasing onto 0baaf68cff...

Current branch diff-target is up to date.
Changes applied before test
commit 8a82bbf95fd23a19022541928f54057ed605ed1e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 21 17:50:49 2022 +0200

    gogs/lister: Allow public gogs instance listing
    
    Prior to this commit, the lister assumed authentication was required. It exists public
    gogs instances which do not require it.
    
    This also updates documentation to mention the usual api location. This is useful when
    people wants to actually trigger a listing as a pre-check flight.
    
    This drops repetitive instruction in the gitea lister as well.
    
    Co-authored with Antoine Lambert (@anlambert) <anlambert@softwareheritage.org>.
    
    Related to infra/sysadm-environment#4644

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/809/ for more details.