tests: Simplify git loading tasks creation tests implementation
ClosedPublic
Actions

Authored by anlambert on Oct 18 2022, 1:23 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Commits

rDLDG66413a1552f4: tests: Simplify git loading tasks creation tests implementation

Summary

Use helper fixture loading_task_creation_for_listed_origin_test from
swh-loader-core and remove redundant tests.

Diff Detail

Repository

rDLDG Git loader

Branch

test-tasks-simplify

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32359
Build 50684: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 50683: arc lint + arc unit

Event Timeline

anlambert created this revision.Oct 18 2022, 1:23 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 18 2022, 1:23 PM

Build is green

Patch application report for D8698 (id=31411)

Rebasing onto 1fb1011431...

Current branch diff-target is up to date.

Changes applied before test

commit aabdc1a8db680918442bc55121718271dab43128
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Oct 12 17:27:45 2022 +0200

    tests: Simplify git loading tasks creation tests implementation
    
    Use helper fixture loading_task_creation_for_listed_origin_test from
    swh-loader-core and remove redundant tests.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/227/ for more details.

Harbormaster completed remote builds in B32356: Diff 31411.Oct 18 2022, 1:26 PM

anlambert requested review of this revision.Oct 18 2022, 1:26 PM

Parametrize tests with extra loader aguments

Build is green

Patch application report for D8698 (id=31414)

Rebasing onto 1fb1011431...

Current branch diff-target is up to date.

Changes applied before test

commit 66413a1552f45c634776d2dd7114eb53c866d4f6
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Oct 12 17:27:45 2022 +0200

    tests: Simplify git loading tasks creation tests implementation
    
    Use helper fixture loading_task_creation_for_listed_origin_test from
    swh-loader-core and remove redundant tests.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/228/ for more details.

Harbormaster completed remote builds in B32359: Diff 31414.Oct 18 2022, 1:49 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 18 2022, 3:45 PM

Closed by commit rDLDG66413a1552f4: tests: Simplify git loading tasks creation tests implementation (authored by anlambert). · Explain Why

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDG66413a1552f4: tests: Simplify git loading tasks creation tests implementation.