Page MenuHomeSoftware Heritage
Differential D8349

misc/banners: Move feature into its own django application
ClosedPublic
Actions

Authored by anlambert on Aug 30 2022, 5:10 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T4398: Create one django application for each webapp feature
Commits
rDWAPPSce5c9159933f: misc/banners: Move feature into its own django application
Summary

Related to T4398

Diff Detail

Repository
rDWAPPS Web applications
Branch
django-apps-refactoring-banners
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 31193
Build 48791: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 48790: arc lint + arc unit

Event Timeline

anlambert created this revision.Aug 30 2022, 5:10 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 30 2022, 5:10 PM
swh-public-ci added a comment.Aug 30 2022, 5:26 PM

Build is green

Patch application report for D8349 (id=30148)

Rebasing onto 37e9a300cd...

Current branch diff-target is up to date.
Changes applied before test
commit ce5c9159933fa8cf07ebd57626c6622bd60eec57
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Aug 30 16:33:53 2022 +0200

    misc/banners: Move feature into its own django application
    
    Related to T4398

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2019/ for more details.

Harbormaster completed remote builds in B31193: Diff 30148.Aug 30 2022, 5:26 PM
anlambert requested review of this revision.Aug 30 2022, 5:26 PM
vlorentz accepted this revision.Aug 31 2022, 11:26 AM
This revision is now accepted and ready to land.Aug 31 2022, 11:26 AM
Closed by commit rDWAPPSce5c9159933f: misc/banners: Move feature into its own django application (authored by anlambert). · Explain WhyAug 31 2022, 11:39 AM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPSce5c9159933f: misc/banners: Move feature into its own django application.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
assets/
src/
bundles/
webapp/
18 lines--
swh/
web/
banners/
tests/
misc/
--
banners/
templates/
templates/
misc/
188 lines--
54 lines--
21 lines--
banners/
13 lines100%
Loading...
banners/
misc/
views.py
fundraising.py
18 lines91%
Loading...
1 line95%
Loading...
misc/
--
18 lines56%
Loading...
templates/
24 lines--
misc/
--
--
--
tests/
banners/
misc/
--
8 lines100%
Loading...
banners/
43 lines100%
Loading...
misc/
100%
Loading...
--

Diff 30148

View Options

assets/src/bundles/webapp/webapp.css

Loading...
View Options

swh/web/banners/__init__.py

Loading...
View Options

swh/web/banners/templates/fundraising-banner.html

Loading...
View Options

swh/web/banners/templates/hiring-banner-iframe.html

Loading...
View Options

swh/web/banners/templates/hiring-banner.html

Loading...
View Options

swh/web/banners/urls.py

Loading...
View Options

swh/web/banners/views.py

Loading...
View Options

swh/web/config.py

Loading...
View Options

swh/web/misc/fundraising.py

Loading...
View Options

swh/web/misc/urls.py

Loading...
View Options

swh/web/templates/layout.html

Loading...
View Options

swh/web/templates/misc/fundraising-banner.html

Loading...
View Options

swh/web/templates/misc/hiring-banner-iframe.html

Loading...
View Options

swh/web/templates/misc/hiring-banner.html

Loading...
View Options

swh/web/tests/banners/__init__.py

Loading...
View Options

swh/web/tests/banners/test_app.py

Loading...
View Options

swh/web/tests/banners/test_fundraising.py

Loading...
View Options

swh/web/tests/misc/__init__.py

Loading...
View Options

swh/web/tests/misc/test_fundraising.py

Loading...
About · Developer information · Legal